Skip to content

Self-evolving Context Database for AI Agents. Unify Agent Memory, Knowledge RAG and Skills.

fix(benchmark): commit_session takes the telemetry keyword, not options (#4498)

Ramif13b2153f3ce
diff --git a/benchmark/locomo/openclaw/import_to_ov.py b/benchmark/locomo/openclaw/import_to_ov.py
index 9511f3ed0..a3bd9ec14 100644
--- a/benchmark/locomo/openclaw/import_to_ov.py
+++ b/benchmark/locomo/openclaw/import_to_ov.py
@@ -291,7 +291,7 @@ async def viking_ingest(
)
# Commit
- result = await client.commit_session(session_id, options={"telemetry": True})
+ result = await client.commit_session(session_id, telemetry=True)
# Accept both "committed" and "accepted" as success - accepted means the session was archived
if result.get("status") not in ("committed", "accepted"):
diff --git a/benchmark/longmemeval/openviking/import_to_ov.py b/benchmark/longmemeval/openviking/import_to_ov.py
index 3a50962ec..e69ec9199 100644
--- a/benchmark/longmemeval/openviking/import_to_ov.py
+++ b/benchmark/longmemeval/openviking/import_to_ov.py
@@ -271,7 +271,7 @@ async def submit_viking_ingest(
options={"created_at": msg_created_at} if msg_created_at else None,
)
- result = await client.commit_session(session_id, options={"telemetry": True})
+ result = await client.commit_session(session_id, telemetry=True)
if result.get("status") not in ("committed", "accepted"):
raise RuntimeError(f"Commit failed: {result}")
diff --git a/tests/unit/test_locomo_peer_wiring.py b/tests/unit/test_locomo_peer_wiring.py
index bf85727c6..7419ba85d 100644
--- a/tests/unit/test_locomo_peer_wiring.py
+++ b/tests/unit/test_locomo_peer_wiring.py
@@ -81,17 +81,20 @@ async def test_viking_ingest_uses_message_peer_id(monkeypatch):
async def initialize(self):
return None
- async def create_session(self, memory_policy=None):
- calls.append(("create_session", memory_policy))
+ async def create_session(self, session_id=None, options=None):
+ calls.append(("create_session", options))
return {"session_id": "sess-1"}
- async def get_session(self, session_id):
+ async def get_session(self, session_id, *, auto_create=False):
calls.append(("get_session", session_id))
return {"commit_count": 0}
async def add_message(
- self, session_id=None, role=None, parts=None, created_at=None, peer_id=None
+ self, session_id, role, content=None, parts=None, options=None, peer_id=None
):
+ if peer_id is not None and options and "peer_id" in options:
+ raise ValueError("options cannot override 'peer_id'")
+ option_values = options or {}
calls.append(
(
"add_message",
@@ -99,14 +102,25 @@ async def test_viking_ingest_uses_message_peer_id(monkeypatch):
"session_id": session_id,
"role": role,
"parts": parts,
- "created_at": created_at,
- "peer_id": peer_id,
+ "created_at": option_values.get("created_at"),
+ "peer_id": peer_id if peer_id is not None else option_values.get("peer_id"),
},
)
)
- async def commit_session(self, session_id, telemetry=True, memory_policy=None):
- calls.append(("commit_session", memory_policy))
+ async def commit_session(
+ self,
+ session_id,
+ telemetry=False,
+ *,
+ keep_recent_count=0,
+ retention_mode=None,
+ keep_recent_turn_count=None,
+ retained_message_token_budget=None,
+ min_raw_tail_steps=None,
+ event_tags=None,
+ ):
+ calls.append(("commit_session", telemetry))
return {"status": "accepted", "task_id": None, "trace_id": "trace-1"}
async def close(self):