Skip to content

Self-evolving Context Database for AI Agents. Unify Agent Memory, Knowledge RAG and Skills.

fix(crypto): clear cached ephemeral root key when Volcengine KMS persist fails (#5561)

ordinary beingf20d9a77c741
diff --git a/openviking/crypto/providers.py b/openviking/crypto/providers.py
index 2b5be4a2c..8c4987b84 100644
--- a/openviking/crypto/providers.py
+++ b/openviking/crypto/providers.py
@@ -724,7 +724,11 @@ class VolcengineKMSProvider(BaseProvider):
self._root_key = secrets.token_bytes(32)
- # Encrypt and store root key
+ # Encrypt and store root key. Any failure here (KMS outage, read-only
+ # or full filesystem) must clear the cached ephemeral key before raising:
+ # otherwise a retried get_root_key() hits the `self._root_key is not None`
+ # fast path and encrypts data with a key that was never persisted — the
+ # data-loss class this provider guards.
try:
encrypted_root_key = await self._encrypt_with_kms(self._root_key)
self.key_file.parent.mkdir(parents=True, exist_ok=True)
@@ -732,6 +736,7 @@ class VolcengineKMSProvider(BaseProvider):
f.write(encrypted_root_key)
logger.info(f"Created and stored new root key at {self.key_file}")
except Exception as e:
+ self._root_key = None
raise ConfigError(
f"Failed to persist root key to file. "
f"Refusing to start with ephemeral key (data loss risk): {e}"
diff --git a/tests/unit/crypto/test_providers_mock.py b/tests/unit/crypto/test_providers_mock.py
index 13b3b5cb9..309e53537 100644
--- a/tests/unit/crypto/test_providers_mock.py
+++ b/tests/unit/crypto/test_providers_mock.py
@@ -306,6 +306,25 @@ class TestVolcengineKMSProviderMock:
assert decrypted == plaintext_key
volcengine_mock_provider.decrypt_file_key.assert_called_once_with(encrypted, iv, account_id)
+ @pytest.mark.asyncio
+ async def test_persist_failure_clears_cache_and_retries(
+ self, volcengine_mock_provider, tmp_path
+ ):
+ """A failed persist must not leave an unpersisted ephemeral key cached."""
+ volcengine_mock_provider.key_file = tmp_path / "root-key.enc"
+ volcengine_mock_provider._encrypt_with_kms = AsyncMock(side_effect=RuntimeError("KMS down"))
+
+ with pytest.raises(ConfigError, match="data loss risk"):
+ await volcengine_mock_provider.get_root_key()
+
+ # Cache must be cleared so a retry re-creates and re-persists the key
+ # instead of returning via the get_root_key fast path a key that was
+ # never written to disk.
+ assert volcengine_mock_provider._root_key is None
+ with pytest.raises(ConfigError, match="data loss risk"):
+ await volcengine_mock_provider.get_root_key()
+ assert volcengine_mock_provider._encrypt_with_kms.call_count == 2
+
class TestCrossProviderEnvelope:
"""Tests for cross-provider envelope behavior."""