Self-evolving Context Database for AI Agents. Unify Agent Memory, Knowledge RAG and Skills.
Python agent-contextagent-memoryagent-pluginsagentic-ragcontext-databasedsh-pluginknowledge-basememorymemory-managementself-evolvingvector-database
fix(server): 延迟初始化失败时退出进程 (#1893)
A0nameless0manf4c720291ce3
diff --git a/openviking/server/app.py b/openviking/server/app.pyindex 3be6d76f1..22ff282b0 100644--- a/openviking/server/app.py+++ b/openviking/server/app.py@@ -4,6 +4,7 @@import asyncioimport logging+import osimport timefrom contextlib import asynccontextmanagerfrom pathlib import Path@@ -55,6 +56,22 @@ from openviking_cli.utils.logger import init_otel_log_handler_from_server_configlogger = get_logger(__name__)+def _on_deferred_init_done(task):+ if task.cancelled():+ logger.warning("Deferred initialization cancelled")+ return++ exc = task.exception()+ if exc is None:+ return++ logger.error(+ "Deferred initialization failed, exiting",+ exc_info=(type(exc), exc, exc.__traceback__),+ )+ os._exit(1)++def _format_error_location(loc: object) -> str:if not isinstance(loc, (list, tuple)):return "request"@@ -221,13 +238,7 @@ def create_app(# Start heavy initialization as background task after yieldif service is not None:deferred_task = asyncio.create_task(_deferred_init(service, app, config))- deferred_task.add_done_callback(- lambda t: (- logger.error("Deferred initialization failed", exc_info=t.exception())- if t.exception()- else None- )- )+ deferred_task.add_done_callback(_on_deferred_init_done)yield# Wait for deferred initialization to complete before shutdown@@ -458,9 +469,7 @@ def create_app(return _handlerfor _route, (_fname, _mime) in _favicon_files.items():- app.add_api_route(- _route, _make_favicon_handler(_fname, _mime), include_in_schema=False- )+ app.add_api_route(_route, _make_favicon_handler(_fname, _mime), include_in_schema=False)# MCP endpoint — serves 5 tools (search, read, store, forget, health)# via streamable HTTP for Claude Code and other MCP clients.diff --git a/tests/server/test_server_health.py b/tests/server/test_server_health.pyindex 15d3f1539..763bee2a9 100644--- a/tests/server/test_server_health.py+++ b/tests/server/test_server_health.py@@ -7,11 +7,63 @@ import asyncioimport timeimport httpx+import pytest-from openviking.server.app import create_app+from openviking.server.app import _on_deferred_init_done, create_appfrom openviking.server.config import ServerConfig+class _ExitCalled(Exception):+ def __init__(self, code: int):+ self.code = code+ super().__init__(f"os._exit({code})")+++async def test_deferred_init_failure_exits_process(monkeypatch):+ async def fail_init():+ raise RuntimeError("init failed")++ def fake_exit(code: int):+ raise _ExitCalled(code)++ monkeypatch.setattr("openviking.server.app.os._exit", fake_exit)+ task = asyncio.create_task(fail_init())+ with pytest.raises(RuntimeError):+ await task++ with pytest.raises(_ExitCalled) as exc_info:+ _on_deferred_init_done(task)++ assert exc_info.value.code == 1+++async def test_deferred_init_success_does_not_exit(monkeypatch):+ async def complete_init():+ return None++ monkeypatch.setattr(+ "openviking.server.app.os._exit",+ lambda code: pytest.fail(f"os._exit({code}) should not be called"),+ )+ task = asyncio.create_task(complete_init())+ await task++ _on_deferred_init_done(task)+++async def test_deferred_init_cancellation_does_not_exit(monkeypatch):+ monkeypatch.setattr(+ "openviking.server.app.os._exit",+ lambda code: pytest.fail(f"os._exit({code}) should not be called"),+ )+ task = asyncio.create_task(asyncio.sleep(60))+ task.cancel()+ with pytest.raises(asyncio.CancelledError):+ await task++ _on_deferred_init_done(task)++async def test_health_endpoint(client: httpx.AsyncClient):resp = await client.get("/health")assert resp.status_code == 200@@ -50,6 +102,9 @@ async def test_404_for_unknown_route(client: httpx.AsyncClient):async def test_lifespan_shutdown_ignores_cancelled_service_close():class _Service:+ async def initialize(self):+ pass+async def close(self):raise asyncio.CancelledError("shutdown")