Self-evolving Context Database for AI Agents. Unify Agent Memory, Knowledge RAG and Skills.
Python agent-contextagent-memoryagent-pluginsagentic-ragcontext-databasedsh-pluginknowledge-basememorymemory-managementself-evolvingvector-database
fix(startup): tolerate malformed preset directory abstracts (#4923)
Qin Haojief6ae7814d475
diff --git a/openviking/core/directories.py b/openviking/core/directories.pyindex 5efd2d204..53c20dceb 100644--- a/openviking/core/directories.py+++ b/openviking/core/directories.py@@ -19,6 +19,7 @@ from openviking.core.namespace import (user_space_fragment,)from openviking.server.identity import RequestContext+from openviking.storage.abstract_overview import AbstractOverviewFormatErrorfrom openviking.storage.queuefs.embedding_msg_converter import EmbeddingMsgConverterfrom openviking.storage.vector_ids import vector_record_id@@ -304,7 +305,18 @@ class DirectoryInitializer:from openviking_cli.utils.logger import get_loggerlogger = get_logger(__name__)- if await self._check_agfs_files_exist(target.uri, ctx=target.ctx):+ try:+ directory_exists = await self._check_agfs_files_exist(target.uri, ctx=target.ctx)+ except AbstractOverviewFormatError as exc:+ logger.warning(+ "[VikingFS] Directory %s (account=%s) has an invalid abstract; "+ "preserving existing contents: %s",+ target.uri,+ target.ctx.account_id,+ exc,+ )+ return False+ if directory_exists:logger.debug(f"[VikingFS] Directory {target.uri} already exists")return Falselogger.debug(f"[VikingFS] Creating directory: {target.uri} for scope {target.scope}")diff --git a/tests/unit/test_directory_initializer.py b/tests/unit/test_directory_initializer.pyindex 06c0a7f12..b1a363277 100644--- a/tests/unit/test_directory_initializer.py+++ b/tests/unit/test_directory_initializer.py@@ -1,3 +1,5 @@+from unittest.mock import AsyncMock+import pytestfrom openviking.core.directories import PRESET_DIRECTORIES, DirectoryInitializer@@ -7,6 +9,7 @@ from openviking.core.namespace import (may_include_hidden_actor_peers,)from openviking.server.identity import RequestContext, Role+from openviking.storage.abstract_overview import body_for_previewfrom openviking_cli.session.user_id import UserIdentifier@@ -30,7 +33,7 @@ class _FakeVikingFS:async def abstract(self, uri, ctx):if uri not in self.contexts:raise FileNotFoundError(uri)- return self.contexts[uri]["abstract"]+ return body_for_preview(self.contexts[uri]["abstract"])async def write_context(self, uri, abstract, overview, is_leaf, ctx):if ctx.actor_peer_id and may_include_hidden_actor_peers(uri, ctx):@@ -43,7 +46,7 @@ class _FakeVikingFS:@pytest.mark.asyncio-async def test_initialize_account_workspace_batches_preset_directories():+async def test_initialize_account_workspace_batches_preset_directories(monkeypatch):vikingdb = _FakeVikingDB()viking_fs = _FakeVikingFS()initializer = DirectoryInitializer(vikingdb, viking_fs=viking_fs)@@ -66,12 +69,22 @@ async def test_initialize_account_workspace_batches_preset_directories():assert len(vikingdb.get_calls[0][0]) == 2 * len(vectorized_uris)assert len(vikingdb.embedding_messages) == 2 * len(vectorized_uris)+ malformed_abstract = "---\ndirectory: viking://resources/\n"+ viking_fs.contexts["viking://resources"]["abstract"] = malformed_abstract+second_account_count, second_user_count = await initializer.initialize_account_workspace(ctx)assert (second_account_count, second_user_count) == (0, 0)+ assert viking_fs.contexts["viking://resources"]["abstract"] == malformed_abstractassert set(viking_fs.contexts) == expected_urisassert len(vikingdb.get_calls) == 1+ storage_error = PermissionError("storage access denied")+ monkeypatch.setattr(viking_fs, "abstract", AsyncMock(side_effect=storage_error))+ with pytest.raises(PermissionError) as exc_info:+ await initializer.initialize_account_workspace(ctx)+ assert exc_info.value is storage_error+@pytest.mark.asyncioasync def test_initialize_user_directories_ignores_actor_peer_view_for_preset_structure():