Skip to content

Free, Open Source, Self-Hosted WhatsApp API Gateway

test(message): cover malformed idempotency headers

Yudhi Armyndharis0fa45435ff7e
diff --git a/src/modules/message/idempotency/send-idempotency.interceptor.spec.ts b/src/modules/message/idempotency/send-idempotency.interceptor.spec.ts
index e757d00ad..aa7b64dea 100644
--- a/src/modules/message/idempotency/send-idempotency.interceptor.spec.ts
+++ b/src/modules/message/idempotency/send-idempotency.interceptor.spec.ts
@@ -19,13 +19,17 @@ describe('SendIdempotencyInterceptor', () => {
let interceptor: SendIdempotencyInterceptor;
let setHeader: jest.Mock;
- const contextFor = (headers: Record<string, string | string[]>, body: unknown = { chatId: 'c', text: 't' }) => {
+ const contextFor = (
+ headers: Record<string, string | string[]>,
+ body: unknown = { chatId: 'c', text: 't' },
+ rawHeaders?: string[],
+ ) => {
setHeader = jest.fn();
return {
getType: () => 'http',
getHandler: () => ({ name: 'sendText' }),
switchToHttp: () => ({
- getRequest: () => ({ headers, params: { sessionId: 's1' }, body }),
+ getRequest: () => ({ headers, params: { sessionId: 's1' }, body, rawHeaders }),
getResponse: () => ({ setHeader }),
}),
} as unknown as ExecutionContext;
@@ -44,6 +48,15 @@ describe('SendIdempotencyInterceptor', () => {
const run = async (ctx: ExecutionContext, handler: () => unknown) =>
lastValueFrom(await interceptor.intercept(ctx, { handle: () => handler() as never }));
+ it('rejects duplicate raw headers even when Node joins their values', async () => {
+ const handler = jest.fn(() => of({}));
+ await expect(
+ run(contextFor({ 'idempotency-key': 'a, b' }, {}, ['Idempotency-Key', 'a', 'idempotency-key', 'b']), handler),
+ ).rejects.toBeInstanceOf(BadRequestException);
+ expect(store.claim).not.toHaveBeenCalled();
+ expect(handler).not.toHaveBeenCalled();
+ });
+
it('passes a request without the header straight through, touching no storage', async () => {
const out = await run(contextFor({}), () => of({ messageId: 'm1' }));
diff --git a/src/modules/message/idempotency/send-idempotency.service.spec.ts b/src/modules/message/idempotency/send-idempotency.service.spec.ts
index b4f99c597..8bc4a32a4 100644
--- a/src/modules/message/idempotency/send-idempotency.service.spec.ts
+++ b/src/modules/message/idempotency/send-idempotency.service.spec.ts
@@ -120,7 +120,7 @@ describe('isValidIdempotencyKey', () => {
expect(isValidIdempotencyKey(key)).toBe(true),
);
- it.each(['', ' ', 'has space', 'x'.repeat(256), 'tab\there', 'ünï'])('rejects %p', key =>
+ it.each(['', ' ', 'has space', 'x'.repeat(256), 'tab\there', 'ünï', 'key\n', 'key\r\n'])('rejects %p', key =>
expect(isValidIdempotencyKey(key)).toBe(false),
);
});