Skip to content

Free, Open Source, Self-Hosted WhatsApp API Gateway

test(takeover): drive the inter-launch stagger with fake timers

Yudhi Armyndharis189d7628fba6
diff --git a/src/modules/takeover/session-takeover.service.spec.ts b/src/modules/takeover/session-takeover.service.spec.ts
index 20ddc042f..255f8bf43 100644
--- a/src/modules/takeover/session-takeover.service.spec.ts
+++ b/src/modules/takeover/session-takeover.service.spec.ts
@@ -135,7 +135,11 @@ describe('SessionTakeoverService', () => {
const { svc } = build([lapsed({ name: 'raced' }), lapsed({ name: 'ours' })], { startImpl: start });
const sweep = svc.sweep();
- await jest.advanceTimersByTimeAsync(2100); // the inter-launch stagger
+ // The second launch waits out the inter-launch stagger, to the millisecond.
+ await jest.advanceTimersByTimeAsync(1999);
+ expect(start).toHaveBeenCalledTimes(1);
+ await jest.advanceTimersByTimeAsync(1);
+ expect(start).toHaveBeenCalledTimes(2);
await sweep;
expect(start.mock.calls).toEqual([['id-raced'], ['id-ours']]);
@@ -159,7 +163,7 @@ describe('SessionTakeoverService', () => {
const { svc } = build([lapsed({ name: 'boom' }), lapsed({ name: 'fine' })], { startImpl: start });
const sweep = svc.sweep();
- await jest.advanceTimersByTimeAsync(2100);
+ await jest.advanceTimersByTimeAsync(2000); // the inter-launch stagger
await expect(sweep).resolves.toBeUndefined();
expect(start).toHaveBeenCalledTimes(2);
diff --git a/src/modules/takeover/session-takeover.service.ts b/src/modules/takeover/session-takeover.service.ts
index 7409d8a0f..f0e6b1557 100644
--- a/src/modules/takeover/session-takeover.service.ts
+++ b/src/modules/takeover/session-takeover.service.ts
@@ -1,6 +1,5 @@
import { ConflictException, Injectable, OnApplicationBootstrap, OnModuleDestroy, Optional } from '@nestjs/common';
import { ConfigService } from '@nestjs/config';
-import { setTimeout } from 'node:timers/promises';
import { createLogger } from '../../common/services/logger.service';
import { resolveFeatureFlags } from '../../config/feature-flags';
import { Session, SessionStatus } from '../session/entities/session.entity';
@@ -182,7 +181,7 @@ export class SessionTakeoverService implements OnApplicationBootstrap, OnModuleD
}
}
if (i < eligible.length - 1) {
- await setTimeout(TAKEOVER_START_STAGGER_MS);
+ await new Promise(resolve => setTimeout(resolve, TAKEOVER_START_STAGGER_MS));
}
}
}