Free, Open Source, Self-Hosted WhatsApp API Gateway
TypeScript apibotgatewayself-hostedwhatsappwhatsapp-apiwhatsapp-automationwhatsapp-botwhatsapp-gatewaywhatsapp-gateway-apiwhatsapp-webwhatsapp-web-api
fix(config): reject a zero rate-limit window at boot
Yudhi Armyndharis267008affea5
diff --git a/src/config/env.validation.spec.ts b/src/config/env.validation.spec.tsindex 2625ea096..92b84e28c 100644--- a/src/config/env.validation.spec.ts+++ b/src/config/env.validation.spec.ts@@ -171,13 +171,22 @@ describe('validateEnv', () => {expect(() => validateEnv({})).not.toThrow();});- it('rejects 0 for a rate-limit limit or the webhook timeout (self-DoS), but allows 0 where it is meaningful', () => {+ it('rejects 0 for a rate-limit limit or window or the webhook timeout (self-DoS), but allows 0 where it is meaningful', () => {expect(() => validateEnv({ RATE_LIMIT_SHORT_LIMIT: '0' })).toThrow(/RATE_LIMIT_SHORT_LIMIT/);expect(() => validateEnv({ RATE_LIMIT_MEDIUM_LIMIT: '0' })).toThrow(/RATE_LIMIT_MEDIUM_LIMIT/);expect(() => validateEnv({ RATE_LIMIT_LONG_LIMIT: '0' })).toThrow(/RATE_LIMIT_LONG_LIMIT/);expect(() => validateEnv({ WEBHOOK_TIMEOUT: '0' })).toThrow(/WEBHOOK_TIMEOUT/);- // 0 stays valid where it has a real meaning: unlimited sessions, no webhook retries, a TTL.- expect(() => validateEnv({ MAX_CONCURRENT_SESSIONS: '0', RATE_LIMIT_SHORT_TTL: '0' })).not.toThrow();+ // A 0 window expires every hit as it lands, which switches that tier off just as a 0 limit would.+ for (const key of [+ 'RATE_LIMIT_SHORT_TTL',+ 'RATE_LIMIT_MEDIUM_TTL',+ 'RATE_LIMIT_LONG_TTL',+ 'INGRESS_INSTANCE_TTL',+ ]) {+ expect(() => validateEnv({ [key]: '0' })).toThrow(new RegExp(`${key} must be a positive integer`));+ }+ // 0 stays valid where it has a real meaning: unlimited sessions, no webhook retry backoff.+ expect(() => validateEnv({ MAX_CONCURRENT_SESSIONS: '0', WEBHOOK_RETRY_DELAY: '0' })).not.toThrow();// a positive value still passesexpect(() => validateEnv({ RATE_LIMIT_SHORT_LIMIT: '10', WEBHOOK_TIMEOUT: '10000' })).not.toThrow();});diff --git a/src/config/env.validation.ts b/src/config/env.validation.tsindex f7aa632c5..742a05a14 100644--- a/src/config/env.validation.ts+++ b/src/config/env.validation.ts@@ -211,9 +211,6 @@ export function validateEnv(config: EnvConfig): EnvConfig {}};for (const key of [- 'RATE_LIMIT_SHORT_TTL',- 'RATE_LIMIT_MEDIUM_TTL',- 'RATE_LIMIT_LONG_TTL','WEBHOOK_RETRY_DELAY','DATABASE_POOL_SIZE','DATABASE_STATEMENT_TIMEOUT_MS',@@ -221,7 +218,6 @@ export function validateEnv(config: EnvConfig): EnvConfig {'DATABASE_CONNECTION_TIMEOUT_MS','REDIS_CONNECT_TIMEOUT_MS','MAX_CONCURRENT_SESSIONS', // 0 = unlimited- 'INGRESS_INSTANCE_TTL','WEBHOOK_DISPATCH_MAX_QUEUED','STATS_CACHE_TTL_MS', // 0 = memo disabled'WEBHOOK_MAX_PER_SESSION', // 0 = unlimited@@ -310,6 +306,11 @@ export function validateEnv(config: EnvConfig): EnvConfig {'RATE_LIMIT_SHORT_LIMIT','RATE_LIMIT_MEDIUM_LIMIT','RATE_LIMIT_LONG_LIMIT',+ // A 0 window expires each hit as it lands, so the tier never blocks: the same self-DoS as a 0 limit.+ 'RATE_LIMIT_SHORT_TTL',+ 'RATE_LIMIT_MEDIUM_TTL',+ 'RATE_LIMIT_LONG_TTL',+ 'INGRESS_INSTANCE_TTL',// WebSocket (/events) limits: 0 would disable a tier entirely (a self-DoS on the WS surface).'WS_RATE_LIMIT_FRAME_PER_SECOND','WS_RATE_LIMIT_FRAME_BURST',