Skip to content

Free, Open Source, Self-Hosted WhatsApp API Gateway

fix(sdk-java): accept a catalog product without a price

Yudhi Armyndharis34def6b34f96
diff --git a/sdk/java/src/main/java/com/rmyndharis/openwa/model/CatalogProduct.java b/sdk/java/src/main/java/com/rmyndharis/openwa/model/CatalogProduct.java
index d8fa3c5f5..fe2058e34 100644
--- a/sdk/java/src/main/java/com/rmyndharis/openwa/model/CatalogProduct.java
+++ b/sdk/java/src/main/java/com/rmyndharis/openwa/model/CatalogProduct.java
@@ -5,7 +5,7 @@ public record CatalogProduct(
String id,
String name,
String description,
- double price,
+ Double price,
String currency,
String priceFormatted,
String imageUrl,
diff --git a/sdk/java/src/test/java/com/rmyndharis/openwa/resources/CatalogResourceTest.java b/sdk/java/src/test/java/com/rmyndharis/openwa/resources/CatalogResourceTest.java
index 8def65e24..1ea658fca 100644
--- a/sdk/java/src/test/java/com/rmyndharis/openwa/resources/CatalogResourceTest.java
+++ b/sdk/java/src/test/java/com/rmyndharis/openwa/resources/CatalogResourceTest.java
@@ -1,12 +1,14 @@
package com.rmyndharis.openwa.resources;
import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertNull;
import static org.junit.jupiter.api.Assertions.assertTrue;
import com.rmyndharis.openwa.ClientConfig;
import com.rmyndharis.openwa.OpenWAClient;
import com.rmyndharis.openwa.http.HttpMethod;
import com.rmyndharis.openwa.model.CatalogProductsQuery;
+import com.rmyndharis.openwa.model.PaginatedProducts;
import com.rmyndharis.openwa.model.SendProductRequest;
import com.rmyndharis.openwa.support.MockTransport;
import org.junit.jupiter.api.Test;
@@ -41,6 +43,19 @@ class CatalogResourceTest {
assertEquals(HttpMethod.GET, tx.lastRequest().method());
}
+ @Test
+ void productWithoutAPriceDecodesAsNullPrice() {
+ // A catalog item with no price reaches the wire as "price":null, which a primitive double
+ // component cannot hold: Gson then rejects the whole page.
+ tx.respond(
+ 200,
+ "{\"products\":[{\"id\":\"p1\",\"name\":\"n\",\"price\":null,\"isAvailable\":true}],"
+ + "\"pagination\":{\"page\":1,\"limit\":20,\"total\":1,\"totalPages\":1}}");
+ PaginatedProducts page = catalog.products("s", null);
+ assertEquals("p1", page.products().get(0).id());
+ assertNull(page.products().get(0).price());
+ }
+
@Test
void productEncodesIds() {
tx.respond(