Skip to content

Free, Open Source, Self-Hosted WhatsApp API Gateway

chore(deps): drop the tar override that pins nothing

Yudhi Armyndharis44e3f094c50a
diff --git a/package.json b/package.json
index c339b668f..839ad3def 100644
--- a/package.json
+++ b/package.json
@@ -520,7 +520,6 @@
"brace-expansion": "^5.0.12"
},
"ip-address": "^10.7.1",
- "tar": "^7.5.21",
"js-yaml": "^5.4.1",
"fast-uri": "^3.1.8",
"multer": "2.4.0",
diff --git a/src/common/package-overrides.spec.ts b/src/common/package-overrides.spec.ts
new file mode 100644
index 000000000..5255b48e6
--- /dev/null
+++ b/src/common/package-overrides.spec.ts
@@ -0,0 +1,29 @@
+import { readFileSync } from 'node:fs';
+import { join } from 'node:path';
+
+/**
+ * An `overrides` entry for a package nothing in the tree depends on constrains nothing, yet reads as
+ * an active security pin, and the docs cite these entries as the pins in force. Every package an
+ * override names must be one the lockfile actually installs.
+ */
+describe('package.json overrides', () => {
+ type Overrides = { [name: string]: string | Overrides };
+ const read = (file: string): unknown => JSON.parse(readFileSync(join(__dirname, '..', '..', file), 'utf8'));
+ const pkg = read('package.json') as { overrides?: Overrides };
+ const lock = read('package-lock.json') as { packages: Record<string, unknown> };
+
+ /** Every package an override names, at any depth, without its `@<range>` selector. */
+ const named = (overrides: Overrides): string[] =>
+ Object.entries(overrides).flatMap(([key, value]) => [
+ ...(key === '.' ? [] : [key.replace(/(?!^)@.*$/, '')]),
+ ...(typeof value === 'string' ? [] : named(value)),
+ ]);
+
+ it('names only packages the lockfile installs', () => {
+ const installed = new Set(Object.keys(lock.packages).map(path => path.replace(/^.*node_modules\//, '')));
+ const names = [...new Set(named(pkg.overrides ?? {}))];
+ // Vacuity guard: an unparsed overrides block would pass the check below.
+ expect(names.length).toBeGreaterThan(5);
+ expect(names.filter(name => !installed.has(name))).toEqual([]);
+ });
+});