Skip to content

Free, Open Source, Self-Hosted WhatsApp API Gateway

fix(dashboard): let the phone page header shrink and wrap

Yudhi Armyndharis46cebddd7350
diff --git a/dashboard/src/components/PageHeader.css b/dashboard/src/components/PageHeader.css
index 040409420..8ec1a2383 100644
--- a/dashboard/src/components/PageHeader.css
+++ b/dashboard/src/components/PageHeader.css
@@ -55,7 +55,7 @@
/* Mobile Responsive: stack as title -> subtitle -> actions */
@media (max-width: 768px) {
.page-header {
- grid-template-columns: 1fr;
+ grid-template-columns: minmax(0, 1fr);
grid-template-areas:
'title'
'subtitle'
@@ -69,6 +69,7 @@
.page-header__actions {
justify-self: stretch;
+ flex-wrap: wrap;
margin-top: 0.25rem;
}
@@ -81,7 +82,7 @@
.page-header__actions > button,
.page-header__actions > .btn-primary,
.page-header__actions > .btn-secondary {
- width: 100%;
+ flex: 1 1 0;
justify-content: center;
}
}
diff --git a/dashboard/src/components/PageHeader.responsive.test.ts b/dashboard/src/components/PageHeader.responsive.test.ts
new file mode 100644
index 000000000..7073e09b8
--- /dev/null
+++ b/dashboard/src/components/PageHeader.responsive.test.ts
@@ -0,0 +1,35 @@
+import { test } from 'node:test';
+import assert from 'node:assert/strict';
+import { decl, readRules } from '../test-helpers/css-rules.ts';
+
+// A plain 1fr track never shrinks below the widest content in it. The actions are a nowrap row of buttons, and in
+// German on a phone the two buttons of the Plugins header widened the single track to 348px: the Install button ran
+// past the right edge of a 320px window (44px of page overflow, 4px at 360px). The track may shrink, and actions that
+// do not fit side by side wrap onto a second line.
+const rules = readRules(new URL('./PageHeader.css', import.meta.url));
+const PHONE = '@media (max-width: 768px)';
+const ACTIONS = '.page-header__actions';
+
+test('the phone header track can shrink below its widest content', () => {
+ const header = rules.filter(r => r.media === PHONE && r.selectors.includes('.page-header'));
+ assert.equal(header.length, 1, 'expected one phone rule for the header');
+ assert.equal(decl(header[0].body, 'grid-template-columns'), 'minmax(0, 1fr)');
+});
+
+test('header actions wrap when they do not fit on one line', () => {
+ const wrap = rules.filter(r => r.media === PHONE && r.selectors.includes(ACTIONS) && decl(r.body, 'flex-wrap'));
+ assert.equal(wrap.length, 1, 'expected one phone rule that lets the actions wrap');
+ assert.equal(decl(wrap[0].body, 'flex-wrap'), 'wrap');
+});
+
+// Below 480px each button fills its line. A width of 100% would stack two buttons that fit side by side, as a wrap
+// would put each on a line of its own; a zero flex basis shares the line equally and wraps only when the buttons
+// cannot fit at their own content width.
+test('the full-width buttons share a line and wrap only when they cannot fit', () => {
+ const buttons = rules.filter(
+ r => r.media === '@media (max-width: 480px)' && r.selectors.includes(`${ACTIONS} > button`),
+ );
+ assert.equal(buttons.length, 1, 'no rule for the phone buttons');
+ assert.equal(decl(buttons[0].body, 'width'), undefined);
+ assert.equal(decl(buttons[0].body, 'flex'), '1 1 0');
+});