Free, Open Source, Self-Hosted WhatsApp API Gateway
TypeScript apibotgatewayself-hostedwhatsappwhatsapp-apiwhatsapp-automationwhatsapp-botwhatsapp-gatewaywhatsapp-gateway-apiwhatsapp-webwhatsapp-web-api
fix(infra): drop NUL from a template name on data import
Yudhi Armyndharis4ebf948cd313
diff --git a/src/modules/infra/table-importers.spec.ts b/src/modules/infra/table-importers.spec.tsindex 296323915..d32f91bb8 100644--- a/src/modules/infra/table-importers.spec.ts+++ b/src/modules/infra/table-importers.spec.ts@@ -110,7 +110,8 @@ describe('automationRules table importer', () => {* A restore writes with raw SQL, so the NUL drop the entities apply to their free-text columns never* runs. PostgreSQL rejects U+0000 in a bound parameter, and an older SQLite backup may hold one, also* in template and rule text written before the DTOs refused it, so the importers drop it from those- * columns and leave ids and lookup keys (a template name is unique per session) as they are.+ * columns and leave ids and lookup keys as they are. A template name is dropped too: no request can+ * look up a name holding NUL, so keeping it only made the template unreachable by name.*/describe('table importers: NUL in free text', () => {const nul = 'a\u0000b';@@ -127,7 +128,7 @@ describe('table importers: NUL in free text', () => {],['webhookDeliveryFailures', { id: 'wf1', lastError: nul }, [9]],['integrationDeliveryFailures', { id: 'df1', lastError: nul }, [7]],- ['templates', { id: 't1', name: 'greet', body: nul, header: nul, footer: nul }, [3, 4, 5]],+ ['templates', { id: 't1', name: nul, body: nul, header: nul, footer: nul }, [2, 3, 4, 5]],['automationRules', { id: 'r1', name: nul, replyText: nul }, [2, 5]],])('drops it from the %s text columns', (key, row, columns) => {const params = mapped(key, row);@@ -137,6 +138,5 @@ describe('table importers: NUL in free text', () => {it('keeps it in a lookup column', () => {expect(mapped('messages', { id: 'm1', chatId: nul })[3]).toBe(nul);expect(mapped('statusUpdates', { id: 'su1', contactJid: nul })[2]).toBe(nul);- expect(mapped('templates', { id: 't1', name: nul })[2]).toBe(nul);});});diff --git a/src/modules/infra/table-importers.ts b/src/modules/infra/table-importers.tsindex 32f88d864..f5dbbeff9 100644--- a/src/modules/infra/table-importers.ts+++ b/src/modules/infra/table-importers.ts@@ -70,7 +70,8 @@ function decodeJsonColumn(value: unknown): unknown {// The entity columns that drop U+0000 do it in a TypeORM transformer, which raw SQL never runs. An// older SQLite backup may still hold one, and PostgreSQL refuses it in a bound parameter, failing the// whole restore. Apply the same drop here, to those same free-text columns and to the template and-// rule text the DTOs only refuse from 0.24.0 on; never to an id or a lookup key such as a template name.+// rule text the DTOs only refuse from 0.24.0 on; never to an id or a lookup key. A template name is the+// exception: no request can look up a name holding NUL, so keeping it would only strand the template.function nulFree(value: unknown): unknown {return NulFreeTransformer.to(value);}@@ -230,7 +231,7 @@ export const TABLE_IMPORTERS: AnyTableImporter[] = [map: (tpl: TemplateRow) => [tpl.id,tpl.sessionId,- tpl.name,+ nulFree(tpl.name),nulFree(tpl.body),nulFree(tpl.header ?? null),nulFree(tpl.footer ?? null),