Skip to content

Free, Open Source, Self-Hosted WhatsApp API Gateway

docs(config): note that boot validation now runs before the secret guard

Yudhi Armyndharis7265c78d0532
diff --git a/src/config/bootstrap-security.ts b/src/config/bootstrap-security.ts
index 75bc7c7da..928a31374 100644
--- a/src/config/bootstrap-security.ts
+++ b/src/config/bootstrap-security.ts
@@ -196,8 +196,8 @@ export interface SecretCheckEnv {
* whenever it is set. Throws with the offending var names so the operator can fix them.
*/
export function assertNoDefaultSecretsInProduction(env: SecretCheckEnv): void {
- // Deny-list, not an allow-list: main.ts calls this BEFORE NestFactory.create, so NODE_ENV has not
- // been through boot validation yet and is still an arbitrary string here. Recognising only
+ // Deny-list, not an allow-list: main.ts runs validateEnv first, which already rejects an unknown
+ // NODE_ENV, but this guard must not depend on that ordering. Recognising only
// 'production' meant every unrecognised value — a `prod` typo, a `staging` deployment — skipped the
// guard silently, including the ALLOW_DEV_API_KEY rejection below. Only the two values that are
// deliberately not production (and an unset or blank variable, the standard Node default for local