Free, Open Source, Self-Hosted WhatsApp API Gateway
TypeScript apibotgatewayself-hostedwhatsappwhatsapp-apiwhatsapp-automationwhatsapp-botwhatsapp-gatewaywhatsapp-gateway-apiwhatsapp-webwhatsapp-web-api
fix(sdk-go): refuse a Do path that does not begin with a slash
Yudhi Armyndharis7d82844f517d
diff --git a/sdk/go/client.go b/sdk/go/client.goindex 2220ca308..131d25bbb 100644--- a/sdk/go/client.go+++ b/sdk/go/client.go@@ -191,7 +191,8 @@ func warnIfInsecure(cfg *config) {// Do issues a raw request against the API and decodes the JSON response into// out (pass nil to ignore the body). It is the escape hatch for endpoints the-// typed services do not cover. path must begin with "/".+// typed services do not cover. path must begin with "/"; any other path returns+// an error and nothing is sent.//// A 2xx body is assigned verbatim when out is a *[]byte, and a non-JSON 2xx// body falls back to the raw text when out is a *string — mirroring the@@ -318,9 +319,14 @@ var jidRestorer = strings.NewReplacer("%40", "@", "%3A", ":", "%2B", "+")var dotFolder = strings.NewReplacer("%2e", ".", "%2E", ".")-// checkPathSegments refuses a "." or ".." segment (also written %2e), and an-// empty one unless allowEmpty. The query and fragment are not path segments.+// checkPathSegments refuses a path that does not begin with "/" (appended to the+// base URL, "@host/x" would move the request and its API key to another host), a+// "." or ".." segment (also written %2e), and an empty one unless allowEmpty. The+// query and fragment are not path segments.func checkPathSegments(path string, allowEmpty bool) error {+ if !strings.HasPrefix(path, "/") {+ return fmt.Errorf("openwa: path must begin with \"/\": %q", path)+ }p := pathif i := strings.IndexAny(p, "?#"); i >= 0 {p = p[:i]diff --git a/sdk/go/client_test.go b/sdk/go/client_test.goindex b416eb129..510069f64 100644--- a/sdk/go/client_test.go+++ b/sdk/go/client_test.go@@ -1625,3 +1625,18 @@ func TestRequestEnumWireValues(t *testing.T) {t.Errorf("durationSeconds did not marshal as a bare number: %s", pin)}}++// A Do path that does not begin with "/" would be appended to the base URL's+// authority, so "@evil.example/x" sends the API key to evil.example.+func TestDoPathWithoutLeadingSlashRefused(t *testing.T) {+ rt := &recordTransport{status: 200, body: `{}`}+ c := newTestClient(t, rt)+ for _, path := range []string{"@evil.example/api/x", ".evil.example/api/x", "api/x", ""} {+ if err := c.Do(context.Background(), "GET", path, nil, nil, nil); err == nil {+ t.Errorf("Do %q: want an error", path)+ }+ }+ if rt.lastReq != nil {+ t.Fatalf("request sent to %s, want none", rt.lastReq.URL.Host)+ }+}