Free, Open Source, Self-Hosted WhatsApp API Gateway
TypeScript apibotgatewayself-hostedwhatsappwhatsapp-apiwhatsapp-automationwhatsapp-botwhatsapp-gatewaywhatsapp-gateway-apiwhatsapp-webwhatsapp-web-api
fix(dashboard): show Global values after clearing a session override
Yudhi Armyndharis82dd3b1407e8
diff --git a/dashboard/src/pages/Plugins.test.ts b/dashboard/src/pages/Plugins.test.tsindex a16f38b61..411c482ef 100644--- a/dashboard/src/pages/Plugins.test.ts+++ b/dashboard/src/pages/Plugins.test.ts@@ -1,6 +1,7 @@// Render test for the per-session plugin config override under the bare `node --test` runner, on the// ApiKeys.test.ts harness. PUT /plugins/:id/config/:sessionId reports a rejected save as 200 +-// {success:false}; the override form must show that failure, not "Saved".+// {success:false}; the override form must show that failure, not "Saved". A cleared override must also+// leave the form on the Global values, or the next save writes the cleared ones back.import '../test-helpers/register-hooks.ts';import { test, before, afterEach } from 'node:test';import assert from 'node:assert/strict';@@ -31,15 +32,30 @@ const SESSION = { id: 'sess-1', name: 'Main', status: 'ready', createdAt: '2026-const REJECTION = 'Cannot tell which entry was removed; reload and try again';+// Per-test server state: the session overrides GET returns, what PUT answers, and each PUT body sent.+let sessionConfig: Record<string, Record<string, unknown>> = {};+let putReply: { success: boolean; message?: string } = { success: false, message: REJECTION };+let putBodies: unknown[] = [];+function installFetchStub(): void {globalThis.fetch = ((input: RequestInfo | URL, init?: RequestInit): Promise<Response> => {const url = typeof input === 'string' ? input : input instanceof URL ? input.href : input.url;const path = url.replace(/^https?:\/\/[^/]+/, '');const method = init?.method ?? 'GET';- if (method === 'GET' && path === '/api/plugins') return Promise.resolve(jsonResponse([PLUGIN]));+ if (method === 'GET' && path === '/api/plugins') {+ return Promise.resolve(jsonResponse([{ ...PLUGIN, sessionConfig }]));+ }if (method === 'GET' && path === '/api/sessions') return Promise.resolve(jsonResponse([SESSION]));if (method === 'PUT' && path === `/api/plugins/${PLUGIN.id}/config/${SESSION.id}`) {- return Promise.resolve(jsonResponse({ success: false, message: REJECTION }));+ const body = JSON.parse(String(init?.body)) as { config: Record<string, unknown> };+ putBodies.push(body);+ if (putReply.success) {+ // The server drops an empty override, so the session inherits Global again.+ sessionConfig = { ...sessionConfig };+ if (Object.keys(body.config).length === 0) delete sessionConfig[SESSION.id];+ else sessionConfig[SESSION.id] = body.config;+ }+ return Promise.resolve(jsonResponse(putReply));}return Promise.resolve(jsonResponse([]));}) as typeof fetch;@@ -73,12 +89,15 @@ before(async () => {});afterEach(() => {+ sessionConfig = {};+ putReply = { success: false, message: REJECTION };+ putBodies = [];rtl.cleanup();queryClient?.clear();queryClient = undefined;});-test('a per-session override the server rejects reports the failure, not "Saved"', async () => {+async function openSessionOverride(sessionLabel: string): Promise<void> {const { screen, fireEvent, findByText } = rtl;queryClient = new QueryClient({ defaultOptions: { queries: { retry: false, gcTime: 1_000 } } });rtl.render(@@ -92,10 +111,35 @@ test('a per-session override the server rejects reports the failure, not "Saved"fireEvent.click(await screen.findByTitle('Configure'));fireEvent.click(await screen.findByRole('button', { name: 'Sessions' }));const select = await screen.findByRole('combobox', { name: 'Select a session…' });- await findByText(select, 'Main');+ await findByText(select, sessionLabel);fireEvent.change(select, { target: { value: SESSION.id } });+}++test('a per-session override the server rejects reports the failure, not "Saved"', async () => {+ const { screen, fireEvent } = rtl;+ await openSessionOverride('Main');fireEvent.click(await screen.findByRole('button', { name: 'Save override' }));await screen.findByText(REJECTION);assert.equal(screen.queryByText('Configuration Saved'), null);});++test('clearing an override shows the Global values, so the next save does not pin the cleared ones back', async () => {+ const { screen, fireEvent, waitFor } = rtl;+ sessionConfig = { [SESSION.id]: { greeting: 'hi' } };+ putReply = { success: true };+ await openSessionOverride('Main ●');+ const field = await screen.findByLabelText<HTMLInputElement>('Greeting');+ assert.equal(field.value, 'hi');++ fireEvent.click(screen.getByRole('button', { name: 'Clear override' }));+ await waitFor(() => assert.equal(putBodies.length, 1));+ await waitFor(() => assert.equal(field.value, 'hello'));++ await waitFor(() =>+ assert.equal(screen.getByRole<HTMLButtonElement>('button', { name: 'Save override' }).disabled, false),+ );+ fireEvent.click(screen.getByRole('button', { name: 'Save override' }));+ await waitFor(() => assert.equal(putBodies.length, 2));+ assert.deepEqual(putBodies, [{ config: {} }, { config: {} }]);+});diff --git a/dashboard/src/pages/Plugins.tsx b/dashboard/src/pages/Plugins.tsxindex 8f123d641..6434cd9e6 100644--- a/dashboard/src/pages/Plugins.tsx+++ b/dashboard/src/pages/Plugins.tsx@@ -457,6 +457,16 @@ function SessionsTab({ plugin }: { plugin: Plugin }) {try {const res = await pluginsApi.updateSessionConfig(plugin.id, selSession, {});if (!res.success) throw new Error(res.message);+ // The seed effect does not re-run on the refetch, so reseed from Global here (the seed with an empty+ // override). Left as it was, the form keeps the cleared values and the next save pins them back.+ const props = plugin.configSchema?.properties;+ if (props) {+ setOverrideCfg(+ Object.fromEntries(+ Object.entries(props).map(([key, field]) => [key, plugin.config[key] ?? emptyForField(field)]),+ ),+ );+ }void queryClient.invalidateQueries({ queryKey: queryKeys.plugins });toast.success(t('plugins.toasts.savedTitle'), t('plugins.toasts.savedDesc'));} catch (err) {