Free, Open Source, Self-Hosted WhatsApp API Gateway
TypeScript apibotgatewayself-hostedwhatsappwhatsapp-apiwhatsapp-automationwhatsapp-botwhatsapp-gatewaywhatsapp-gateway-apiwhatsapp-webwhatsapp-web-api
fix(dashboard): stop a bulk number check on a 403
Yudhi Armyndharis87dbdbe72bdd
diff --git a/dashboard/src/components/NumberCheckProvider.test.ts b/dashboard/src/components/NumberCheckProvider.test.tsnew file mode 100644index 000000000..9b6f578a3--- /dev/null+++ b/dashboard/src/components/NumberCheckProvider.test.ts@@ -0,0 +1,80 @@+// A bulk number check stops at the first answer that no later number would change.+import '../test-helpers/register-hooks.ts';+import { test, before, afterEach } from 'node:test';+import assert from 'node:assert/strict';+import { createElement, type ReactNode } from 'react';+import type { NumberCheckProvider as NumberCheckProviderType } from './NumberCheckProvider.tsx';+import type { useNumberCheck as useNumberCheckFn } from '../hooks/useNumberCheck.ts';+import type { ToastContext as ToastContextType } from '../hooks/useToast.ts';++type RTL = typeof import('@testing-library/react');++let rtl: RTL;+let NumberCheckProvider: typeof NumberCheckProviderType;+let useNumberCheck: typeof useNumberCheckFn;+let ToastContext: typeof ToastContextType;++let lookupStatus = 200;+const lookups: string[] = [];++before(async () => {+ const { installJsdomGlobals } = await import('../test-helpers/jsdom.ts');+ await installJsdomGlobals();+ const { i18nReady } = await import('../i18n/index.ts');+ await i18nReady;+ globalThis.fetch = (input: RequestInfo | URL): Promise<Response> => {+ const url = typeof input === 'string' ? input : input instanceof URL ? input.href : input.url;+ lookups.push(url.slice(url.lastIndexOf('/') + 1));+ const body =+ lookupStatus === 200+ ? { number: '', exists: true, whatsappId: null }+ : { statusCode: lookupStatus, message: 'Dummy refusal' };+ return Promise.resolve(new Response(JSON.stringify(body), { status: lookupStatus }));+ };+ rtl = await import('@testing-library/react');+ ({ NumberCheckProvider } = await import('./NumberCheckProvider.tsx'));+ ({ useNumberCheck } = await import('../hooks/useNumberCheck.ts'));+ ({ ToastContext } = await import('../hooks/useToast.ts'));+});++afterEach(() => {+ rtl.cleanup();+ lookupStatus = 200;+ lookups.length = 0;+});++function renderRun() {+ const noop = () => {};+ const value = {+ toasts: [],+ addToast: noop,+ removeToast: noop,+ success: noop,+ error: noop,+ warning: noop,+ info: noop,+ };+ const wrapper = ({ children }: { children: ReactNode }) =>+ createElement(ToastContext.Provider, { value }, createElement(NumberCheckProvider, null, children));+ return rtl.renderHook(() => useNumberCheck(), { wrapper });+}++for (const status of [403, 429]) {+ test(`a ${status} on the first lookup stops the run before the second number is sent`, async () => {+ lookupStatus = status;+ const { result } = renderRun();+ await rtl.act(() => result.current.start(['628111111111', '628222222222', '628333333333'], 'dummy-session', 0));+ assert.equal(lookups.length, 1);+ assert.equal(result.current.running, false);+ assert.equal(result.current.stopped?.status, status);+ assert.equal(result.current.stopped?.attempted, 1);+ });+}++test('a 404 fails that number only and the run goes on', async () => {+ lookupStatus = 404;+ const { result } = renderRun();+ await rtl.act(() => result.current.start(['628111111111', '628222222222'], 'dummy-session', 0));+ assert.equal(lookups.length, 2);+ assert.equal(result.current.stopped, null);+});diff --git a/dashboard/src/components/NumberCheckProvider.tsx b/dashboard/src/components/NumberCheckProvider.tsxindex afb66f240..5720d7636 100644--- a/dashboard/src/components/NumberCheckProvider.tsx+++ b/dashboard/src/components/NumberCheckProvider.tsx@@ -73,10 +73,12 @@ export function NumberCheckProvider({ children }: { children: ReactNode }) {// The gateway keeps refusing this route for the rest of its window, a stopped session or an unreachable// gateway fails every later number too, so each would only become a false "Failed" row (and spend more- // of the limit).- if (isGatewayRefusal(err)) {+ // of the limit). A 403 is the key itself being refused the route (a role, session or chat restriction),+ // which no number changes.+ const status = (err as { status?: number }).status;+ if (isGatewayRefusal(err) || status === 403) {// A rejected fetch carries no status: the gateway never answered.- refusedWith = (err as { status?: number }).status ?? 0;+ refusedWith = status ?? 0;update({ progress: { current: i + 1, total: numbers.length } });break;}