Skip to content

Free, Open Source, Self-Hosted WhatsApp API Gateway

fix(dashboard): cap Message Tester fields at the bounds Send enforces

Yudhi Armyndharis94c10a33c1d6
diff --git a/dashboard/src/pages/MessageTester.test.ts b/dashboard/src/pages/MessageTester.test.ts
index 7776a1171..4d83f8a10 100644
--- a/dashboard/src/pages/MessageTester.test.ts
+++ b/dashboard/src/pages/MessageTester.test.ts
@@ -365,6 +365,25 @@ test('a group poll send holds a question over 255 or an option over 100 characte
await assertLengthBound(rtl.screen.getByPlaceholderText('Option 1'), 100);
});
+test('each bounded single-send field stops taking input at the limit Send enforces', async () => {
+ const maxLength = (element: HTMLElement): number => (element as HTMLInputElement).maxLength;
+ await renderGroupSendOf('Text');
+ assert.equal(maxLength(byId('mt-2')), 4096);
+ rtl.fireEvent.click(rtl.screen.getByRole('button', { name: 'Image' }));
+ assert.equal(maxLength(byId('mt-14')), 1024);
+ rtl.fireEvent.click(rtl.screen.getByRole('button', { name: 'Document' }));
+ assert.equal(maxLength(byId('mt-14')), 255);
+ rtl.fireEvent.click(rtl.screen.getByRole('button', { name: 'Location' }));
+ assert.equal(maxLength(byId('mt-15')), 1024);
+ assert.equal(maxLength(byId('mt-16')), 1024);
+ rtl.fireEvent.click(rtl.screen.getByRole('button', { name: 'Contact' }));
+ assert.equal(maxLength(byId('mt-6')), 255);
+ assert.equal(maxLength(byId('mt-7')), 30);
+ rtl.fireEvent.click(rtl.screen.getByRole('button', { name: 'Poll' }));
+ assert.equal(maxLength(byId('mt-8')), 255);
+ assert.equal(maxLength(rtl.screen.getByPlaceholderText('Option 1')), 100);
+});
+
test('a session that stops being ready is replaced by what the selector shows', async () => {
const status: Record<string, string> = { s1: 'ready', s2: 'ready' };
const sends: string[] = [];
diff --git a/dashboard/src/pages/MessageTester.tsx b/dashboard/src/pages/MessageTester.tsx
index 41fd5de99..52f72c166 100644
--- a/dashboard/src/pages/MessageTester.tsx
+++ b/dashboard/src/pages/MessageTester.tsx
@@ -826,6 +826,7 @@ export function MessageTester() {
value={content}
onChange={e => setContent(e.target.value)}
placeholder={t('messageTester.messagePlaceholder')}
+ maxLength={MESSAGE_TEXT_MAX_LENGTH}
rows={5}
/>
</div>
@@ -844,6 +845,7 @@ export function MessageTester() {
id="mt-14"
type="text"
value={content}
+ maxLength={messageType === 'document' ? MEDIA_FILENAME_MAX_LENGTH : BULK_CAPTION_MAX_LENGTH}
onChange={e => setContent(e.target.value)}
placeholder={
messageType === 'document'
@@ -894,6 +896,7 @@ export function MessageTester() {
id="mt-15"
type="text"
value={locationDescription}
+ maxLength={LOCATION_TEXT_MAX_LENGTH}
onChange={e => setLocationDescription(e.target.value)}
/>
</div>
@@ -905,6 +908,7 @@ export function MessageTester() {
id="mt-16"
type="text"
value={locationAddress}
+ maxLength={LOCATION_TEXT_MAX_LENGTH}
onChange={e => setLocationAddress(e.target.value)}
/>
</div>
@@ -919,6 +923,7 @@ export function MessageTester() {
id="mt-6"
type="text"
value={contactName}
+ maxLength={CONTACT_NAME_MAX_LENGTH}
onChange={e => setContactName(e.target.value)}
placeholder={t('messageTester.contactNamePlaceholder')}
/>
@@ -929,6 +934,7 @@ export function MessageTester() {
id="mt-7"
type="text"
value={contactNumber}
+ maxLength={CONTACT_NUMBER_MAX_LENGTH}
onChange={e => setContactNumber(e.target.value)}
placeholder="+62812345678"
/>
@@ -944,6 +950,7 @@ export function MessageTester() {
id="mt-8"
type="text"
value={pollQuestion}
+ maxLength={POLL_NAME_MAX_LENGTH}
onChange={e => setPollQuestion(e.target.value)}
placeholder={t('messageTester.pollQuestionPlaceholder')}
/>
@@ -955,6 +962,7 @@ export function MessageTester() {
<input
type="text"
value={option}
+ maxLength={POLL_OPTION_MAX_LENGTH}
onChange={e => setPollOptions(prev => prev.map((o, i) => (i === index ? e.target.value : o)))}
placeholder={t('messageTester.pollOptionPlaceholder', { index: index + 1 })}
/>