Skip to content

Free, Open Source, Self-Hosted WhatsApp API Gateway

fix(mcp): log client-caused tool errors at warn without a stack

Yudhi Armyndharis9a5521100353
diff --git a/src/modules/mcp/tool-result.spec.ts b/src/modules/mcp/tool-result.spec.ts
index 41274ee94..f652c2f38 100644
--- a/src/modules/mcp/tool-result.spec.ts
+++ b/src/modules/mcp/tool-result.spec.ts
@@ -1,4 +1,6 @@
-import { smartToolResult } from './tool-result';
+import { NotFoundException, ServiceUnavailableException } from '@nestjs/common';
+import { LoggerService } from '../../common/services/logger.service';
+import { handleToolError, smartToolResult } from './tool-result';
describe('smartToolResult', () => {
it('inlines a small object as JSON text', () => {
@@ -24,3 +26,26 @@ describe('smartToolResult', () => {
expect(result.content[1]).toMatchObject({ type: 'resource', resource: { mimeType: 'application/json' } });
});
});
+
+describe('handleToolError logging', () => {
+ let error: jest.SpyInstance;
+ let warn: jest.SpyInstance;
+ beforeEach(() => {
+ error = jest.spyOn(LoggerService.prototype, 'error').mockImplementation(() => undefined);
+ warn = jest.spyOn(LoggerService.prototype, 'warn').mockImplementation(() => undefined);
+ });
+ afterEach(() => jest.restoreAllMocks());
+
+ it('logs a client-caused 4xx at warn without a stack, as REST leaves it unlogged', () => {
+ handleToolError(new NotFoundException('Session x not found'));
+ expect(error).not.toHaveBeenCalled();
+ expect(warn).toHaveBeenCalledWith('MCP tool error 404: Session x not found');
+ });
+
+ it('keeps a 5xx at error with its stack', () => {
+ const failure = new ServiceUnavailableException('engine down');
+ handleToolError(failure);
+ expect(error).toHaveBeenCalledWith('engine down', failure.stack);
+ expect(warn).not.toHaveBeenCalled();
+ });
+});
diff --git a/src/modules/mcp/tool-result.ts b/src/modules/mcp/tool-result.ts
index ff7e3ab47..2575b7db1 100644
--- a/src/modules/mcp/tool-result.ts
+++ b/src/modules/mcp/tool-result.ts
@@ -47,7 +47,10 @@ export function jsonToolResult(data: object, isError = false): CallToolResult {
*/
export function handleToolError(error: unknown): CallToolResult {
if (error instanceof HttpException) {
- logger.error(error.message, error.stack);
+ // A 4xx is the client's mistake (unknown session, bad input, missing role), which REST does not
+ // log at all: a warn line without a stack, so error-level alerting fires on server faults only.
+ if (error.getStatus() >= 500) logger.error(error.message, error.stack);
+ else logger.warn(`MCP tool error ${error.getStatus()}: ${error.message}`);
const res = error.getResponse();
const message =
typeof res === 'object' && res !== null && 'message' in res