Skip to content

Free, Open Source, Self-Hosted WhatsApp API Gateway

docs(session): list a delete in flight where liveness is described

Yudhi Armyndharis9ec3b52dfbbf
diff --git a/src/modules/session/session-engine-controls.ts b/src/modules/session/session-engine-controls.ts
index 32c9f955b..71da82798 100644
--- a/src/modules/session/session-engine-controls.ts
+++ b/src/modules/session/session-engine-controls.ts
@@ -199,7 +199,10 @@ export class SessionEngineControls {
this.initializingSessions = host.initializingSessions;
}
- /** True while a delete of the session runs, from its engine teardown until its rows are gone or it failed. */
+ /**
+ * True while a delete of the session runs: from just before its engine teardown until it returns or
+ * throws, credential purge included.
+ */
isDeleting(id: string): boolean {
return this.deleting.has(id);
}
diff --git a/src/modules/session/session-engine-lifecycle.service.ts b/src/modules/session/session-engine-lifecycle.service.ts
index a74460d84..2efa70f6c 100644
--- a/src/modules/session/session-engine-lifecycle.service.ts
+++ b/src/modules/session/session-engine-lifecycle.service.ts
@@ -557,8 +557,8 @@ export class SessionEngineLifecycle {
/**
* True while this process still has anything alive for the session: a registered engine, an
* in-flight start(), reconnect state whose armed/executing attempt will re-register one, or a
- * delete still removing its rows (its engine is gone by then, but a peer that adopted the lapsed
- * lease would start the session being deleted).
+ * delete still running (its engine is gone by then, but a peer that adopted the lapsed lease
+ * would start the session being deleted).
* The ownership heartbeat consults this so a claim that no longer covers an engine stops being
* renewed and can lapse for a peer to adopt; the service-level release paths consult it so an
* "already starting/started" refusal never releases a session this node genuinely runs.
diff --git a/src/modules/session/session-ownership.service.ts b/src/modules/session/session-ownership.service.ts
index 380b9b710..cfb596ecd 100644
--- a/src/modules/session/session-ownership.service.ts
+++ b/src/modules/session/session-ownership.service.ts
@@ -317,8 +317,8 @@ export class SessionOwnershipService {
/**
* Register the probe renew() consults before extending a lease. Wired by SessionService to the
- * engine lifecycle (engine registered, start in flight, or reconnect pending). Optional like the
- * lease-loss handler: without it every held claim renews unconditionally.
+ * engine lifecycle (engine registered, start in flight, reconnect pending, or delete in flight).
+ * Optional like the lease-loss handler: without it every held claim renews unconditionally.
*/
setEngineLiveness(probe: (sessionId: string) => boolean): void {
this.engineLiveness = probe;
diff --git a/src/modules/session/session.service.ts b/src/modules/session/session.service.ts
index e411d242c..87382b46c 100644
--- a/src/modules/session/session.service.ts
+++ b/src/modules/session/session.service.ts
@@ -963,7 +963,10 @@ export class SessionService implements OnModuleDestroy, OnModuleInit, OnApplicat
await this.releaseUnlessEngineActive(id);
}
- /** Hand the claim back unless something still runs here (engine, in-flight start, pending reconnect). */
+ /**
+ * Hand the claim back unless something still runs here (engine, in-flight start, pending reconnect,
+ * delete in flight).
+ */
private async releaseUnlessEngineActive(id: string): Promise<void> {
if (!this.ownership || this.engineLifecycle.isEngineActive(id)) {
return;