Skip to content

Free, Open Source, Self-Hosted WhatsApp API Gateway

fix(engine): cap the init deadline at the largest Node timer delay

Yudhi Armyndharisb844b9d08f08
diff --git a/src/engine/adapters/whatsapp-web-js.adapter.spec.ts b/src/engine/adapters/whatsapp-web-js.adapter.spec.ts
index dae5de622..88ffc7a82 100644
--- a/src/engine/adapters/whatsapp-web-js.adapter.spec.ts
+++ b/src/engine/adapters/whatsapp-web-js.adapter.spec.ts
@@ -19,6 +19,7 @@ import {
NAVIGATION_EPISODE_CAP_MS,
} from './whatsapp-web-js.adapter';
import { getEffectiveWebVersionInfo, resolveWebVersionPin, __resetWebVersionCache } from '../wa-web-version';
+import { resolveEngineInitTimeoutMs } from '../engine-init-timeout';
import * as fs from 'fs';
import * as path from 'path';
import * as qrcode from 'qrcode';
@@ -3127,6 +3128,17 @@ describe('resolveAuthTimeoutMs (#353 — configurable first-boot init wait)', ()
process.env.WWEBJS_AUTH_TIMEOUT_MS = '600000';
expect(resolveAuthTimeoutMs()).toBe(600000);
});
+
+ // The outer init deadline is a setTimeout, and Node fires any delay above 2^31-1 after 1 ms: every
+ // start on either engine was then a 504. whatsapp-web.js times its own wait with Date.now, so the
+ // auth value itself is kept.
+ it('keeps the derived init deadline within what a Node timer can hold', () => {
+ process.env.WWEBJS_AUTH_TIMEOUT_MS = '3000000000';
+ expect(resolveAuthTimeoutMs()).toBe(3000000000);
+ expect(resolveEngineInitTimeoutMs()).toBe(2_147_483_647);
+ process.env.WWEBJS_AUTH_TIMEOUT_MS = '600000';
+ expect(resolveEngineInitTimeoutMs()).toBe(630000);
+ });
});
describe('WhatsAppWebJsAdapter inbound media (MEDIA_DOWNLOAD_ENABLED=false)', () => {
diff --git a/src/engine/engine-init-timeout.ts b/src/engine/engine-init-timeout.ts
index e2b46007e..090a189e8 100644
--- a/src/engine/engine-init-timeout.ts
+++ b/src/engine/engine-init-timeout.ts
@@ -42,5 +42,7 @@ export function resolveAuthTimeoutMs(): number | undefined {
* behaviour change, not part of moving this out of the adapter.
*/
export function resolveEngineInitTimeoutMs(): number {
- return Math.max(60_000, (resolveAuthTimeoutMs() ?? 30_000) + 30_000);
+ // Capped at the largest delay a Node timer holds: above it setTimeout fires after 1 ms, so a huge
+ // WWEBJS_AUTH_TIMEOUT_MS failed every start at once instead of waiting longer.
+ return Math.min(2_147_483_647, Math.max(60_000, (resolveAuthTimeoutMs() ?? 30_000) + 30_000));
}