Free, Open Source, Self-Hosted WhatsApp API Gateway
TypeScript apibotgatewayself-hostedwhatsappwhatsapp-apiwhatsapp-automationwhatsapp-botwhatsapp-gatewaywhatsapp-gateway-apiwhatsapp-webwhatsapp-web-api
test(config): pin the dotenv banner guard on stderr as well as stdout
Yudhi Armyndharisc1b387b4063a
diff --git a/src/config/load-env.spec.ts b/src/config/load-env.spec.tsindex 050bf3942..28e9a313d 100644--- a/src/config/load-env.spec.ts+++ b/src/config/load-env.spec.ts@@ -71,8 +71,10 @@ describe('loadEnvironment', () => {expect(workerConnectionOptions().host).toBe('host-from-process-env');});- // dotenv 17 prints an "injected env ... // tip: ..." line to stdout on every load unless told to be- // quiet. It bypasses the logger, so in production it lands as plain text in the JSON log stream.+ // dotenv prints an "injected env" line on every load unless told to be quiet: to stdout up to dotenv 17,+ // to stderr (console.error) from 18. It bypasses the logger, so in production it lands as plain text in+ // the JSON log stream. Every console channel is watched, so the guard does not depend on which one the+ // installed version writes to.it.each<[string, Record<string, string>]>([['a saved configuration',@@ -80,13 +82,17 @@ describe('loadEnvironment', () => {],['a first run', { '.env': 'REDIS_HOST=redis.internal\n' }],])('keeps dotenv from printing its own load banner on %s', (_case, files) => {+ delete process.env.DOTENV_QUIET;delete process.env.DOTENV_CONFIG_QUIET;makeTempCwd(files);- const log = jest.spyOn(console, 'log').mockImplementation(() => undefined);+ const lines: string[] = [];+ for (const channel of ['log', 'info', 'warn', 'error', 'debug'] as const) {+ jest.spyOn(console, channel).mockImplementation((...args: unknown[]) => void lines.push(args.join(' ')));+ }runLoader();- expect(log.mock.calls.map(args => args.join(' '))).not.toContainEqual(expect.stringContaining('injected env'));+ expect(lines).not.toContainEqual(expect.stringContaining('injected env'));});// The image runs with NODE_ENV=production, where the logger emits JSON. A raw console line from thediff --git a/src/database/load-cli-env.spec.ts b/src/database/load-cli-env.spec.tsindex aed8b74bd..f38b8a241 100644--- a/src/database/load-cli-env.spec.ts+++ b/src/database/load-cli-env.spec.ts@@ -49,16 +49,23 @@ describe('loadCliEnv (migration CLI env precedence)', () => {expect(process.env[KEY]).toBe('postgres');});- it("loads both files without printing dotenv's banner to stdout", () => {+ // dotenv writes its "injected env" banner to stdout up to dotenv 17 and to stderr (console.error) from 18,+ // so every console channel is watched, not the one the installed version happens to use.+ it("loads both files without printing dotenv's banner", () => {+ delete process.env.DOTENV_QUIET;+ delete process.env.DOTENV_CONFIG_QUIET;fs.writeFileSync(path.join(dir, '.env'), 'DATABASE_TYPE=postgres\n');fs.writeFileSync(path.join(dir, 'data', '.env.generated'), 'DATABASE_TYPE=sqlite\n');- const log = jest.spyOn(console, 'log').mockImplementation(() => undefined);+ const lines: string[] = [];+ const spies = (['log', 'info', 'warn', 'error', 'debug'] as const).map(channel =>+ jest.spyOn(console, channel).mockImplementation((...args: unknown[]) => void lines.push(args.join(' '))),+ );try {loadCliEnv(dir);- expect(log).not.toHaveBeenCalled();+ expect(lines).not.toContainEqual(expect.stringContaining('injected env'));} finally {- log.mockRestore();+ for (const spy of spies) spy.mockRestore();}});});