Free, Open Source, Self-Hosted WhatsApp API Gateway
TypeScript apibotgatewayself-hostedwhatsappwhatsapp-apiwhatsapp-automationwhatsapp-botwhatsapp-gatewaywhatsapp-gateway-apiwhatsapp-webwhatsapp-web-api
docs(docker): name the socket-proxy version the stop-only note covers
Yudhi Armyndhariscc4cbb38972c
diff --git a/scripts/smoke-test-docker-proxy.sh b/scripts/smoke-test-docker-proxy.shindex 289aca3d6..f0ac1f03f 100755--- a/scripts/smoke-test-docker-proxy.sh+++ b/scripts/smoke-test-docker-proxy.sh@@ -72,7 +72,7 @@ if [ "$CODE" != "403" ]; thenfiecho "PASS: GET /networks via proxy -> 403 (denied)"# NOTE: there is intentionally no "DELETE is rejected" check. With POST=1 the pinned proxy-# (tecnativa/docker-socket-proxy v0.4.2) admits EVERY method to the enabled paths — its+# (tecnativa/docker-socket-proxy v0.5.0) admits EVERY method to the enabled paths — its# DELETE env flag is dead config — so such a check would fail against the working# configuration. OpenWA itself never issues deletes (profile teardown is stop-only);# see SECURITY.md "Docker socket proxy — scope and residual risk".diff --git a/src/modules/docker/docker.service.spec.ts b/src/modules/docker/docker.service.spec.tsindex 98ca2aace..f93c9a6ff 100644--- a/src/modules/docker/docker.service.spec.ts+++ b/src/modules/docker/docker.service.spec.ts@@ -82,7 +82,7 @@ describe('DockerService.buildDockerOptions', () => {});describe('DockerService.stopManagedService (stop-only teardown)', () => {- // Teardown is deliberately stop-only: the pinned docker-socket-proxy v0.4.2 never reads its+ // Teardown is deliberately stop-only: the pinned docker-socket-proxy v0.5.0 never reads its// DELETE env flag (deletion is admitted only as an undocumented side effect of its POST// method gate), so the code must not depend on container.remove() at all.const makeService = (container: unknown) => {diff --git a/src/modules/docker/docker.service.ts b/src/modules/docker/docker.service.tsindex 1ccc40134..0a44d73c6 100644--- a/src/modules/docker/docker.service.ts+++ b/src/modules/docker/docker.service.ts@@ -501,7 +501,7 @@ export class DockerService implements OnModuleInit {* Stop a managed profile's container and RETAIN it for a later re-enable.** Deliberately stop-only — no `container.remove()`. The bundled docker-socket-proxy- * (tecnativa/docker-socket-proxy, pinned v0.4.2) never reads its `DELETE` env flag: its+ * (tecnativa/docker-socket-proxy, pinned v0.5.0) never reads its `DELETE` env flag: its* haproxy.cfg method gate is `deny unless METH_GET || env(POST)`, so container deletion is* admitted only as an undocumented side effect of POST being enabled — a contract any proxy* upgrade may withdraw. Stopping needs nothing beyond POST /containers/{id}/stop, which the