Skip to content

Free, Open Source, Self-Hosted WhatsApp API Gateway

fix(dashboard): reset the result filter when a bulk run starts

Yudhi Armyndharisd47a5b5af28a
diff --git a/dashboard/src/pages/NumberChecker.test.ts b/dashboard/src/pages/NumberChecker.test.ts
index a61a620d2..eb8733804 100644
--- a/dashboard/src/pages/NumberChecker.test.ts
+++ b/dashboard/src/pages/NumberChecker.test.ts
@@ -611,6 +611,23 @@ test('NumberChecker: a lookup error that is not a gateway refusal fails that num
assert.equal(container.querySelector('.nc-batch-stopped'), null);
});
+test('NumberChecker: a new run starts on the All filter, so a Failed filter left over does not hide its rows', async () => {
+ stubLookups(number =>
+ number === '911111111111' ? jsonResponse({ message: 'engine hiccup' }, 500) : registered(number),
+ );
+ const { container } = renderComponent();
+ const textarea = await openBulkTab();
+ rtl.fireEvent.change(textarea, { target: { value: '911111111111' } });
+ rtl.fireEvent.click(rtl.screen.getByRole('button', { name: /Start Batch Check/i }));
+ rtl.fireEvent.click(await rtl.screen.findByRole('button', { name: /^Failed \(1\)/ }));
+
+ rtl.fireEvent.change(textarea, { target: { value: '912222222222' } });
+ rtl.fireEvent.click(rtl.screen.getByRole('button', { name: /Start Batch Check/i }));
+
+ await rtl.screen.findByText('+912222222222');
+ assert.match(container.querySelector('.nc-filter-btn.active')?.textContent ?? '', /^All \(1\)/);
+});
+
test('NumberChecker: a run in which every lookup failed is not reported as completed', async () => {
const lookups = stubLookups(() => jsonResponse({ message: 'engine hiccup' }, 500));
const { container } = renderComponent();
diff --git a/dashboard/src/pages/NumberChecker.tsx b/dashboard/src/pages/NumberChecker.tsx
index 1411e7070..bb3ebe5e2 100644
--- a/dashboard/src/pages/NumberChecker.tsx
+++ b/dashboard/src/pages/NumberChecker.tsx
@@ -270,6 +270,7 @@ export function NumberChecker() {
const runId = ++batchRunIdRef.current;
setIsCheckingBatch(true);
setBatchResults([]);
+ setBatchFilter('all');
setBatchStop(null);
setBatchProgress({ current: 0, total: numbers.length });