Free, Open Source, Self-Hosted WhatsApp API Gateway
TypeScript apibotgatewayself-hostedwhatsappwhatsapp-apiwhatsapp-automationwhatsapp-botwhatsapp-gatewaywhatsapp-gateway-apiwhatsapp-webwhatsapp-web-api
fix(dashboard): cap the Templates session select width
Yudhi Armyndharise1028fa6abad
diff --git a/dashboard/src/pages/Templates.css b/dashboard/src/pages/Templates.cssindex dace30582..c12df2ce1 100644--- a/dashboard/src/pages/Templates.css+++ b/dashboard/src/pages/Templates.css@@ -19,6 +19,9 @@.templates-page .templates-session-select {min-width: 240px;+ /* A native select is as wide as its longest option, and a percentage width does not bound the header column+ it sits in; only max-width does. A longer session name is cut inside the select, not over the title. */+ max-width: 20rem;}.templates-page .templates-workspace {@@ -478,6 +481,13 @@}}+/* The page header is one column from here, so the select has no title beside it to cover. */+@media (max-width: 768px) {+ .templates-page .templates-session-select {+ max-width: none;+ }+}+@media (max-width: 640px) {.templates-page .templates-library-header,.templates-page .template-editor-header,diff --git a/dashboard/src/pages/Templates.responsive.test.ts b/dashboard/src/pages/Templates.responsive.test.tsindex f9274fb28..3ebfa9a6d 100644--- a/dashboard/src/pages/Templates.responsive.test.ts+++ b/dashboard/src/pages/Templates.responsive.test.ts@@ -22,3 +22,24 @@ test('the workspace keeps two columns until three of them fit', () => {assert.equal(two.length, 1, 'expected one rule for the two-column workspace');assert.ok(widthOf(two[0].media) >= 1286, `two columns apply at ${two[0].media || 'every width'}`);});++// A native select is as wide as its longest option, and the header column it sits in is sized to that: a session with+// a long name made the column as wide as the name, the title column shrank to nothing and the select covered the+// title (between about 770 and 1100px). A percentage in `width` does not count towards the column, so the bound is+// max-width; the select then cuts a long name inside itself.+const SELECT = '.templates-page .templates-session-select';++test('the session select is capped so a long session name cannot take the header from the title', () => {+ const capped = rules.find(r => !r.media && r.selectors.includes(SELECT));+ assert.ok(capped, 'no base rule for the session select');+ assert.equal(decl(capped.body, 'max-width'), '20rem');+});++test('the cap is lifted where the header is one column and the select has no title beside it', () => {+ // PageHeader.css stacks the title, the subtitle and the actions below 769px.+ const lifted = rules.filter(r => r.selectors.includes(SELECT) && decl(r.body, 'max-width') === 'none');+ assert.deepEqual(+ lifted.map(r => r.media),+ ['@media (max-width: 768px)'],+ );+});