Skip to content

Free, Open Source, Self-Hosted WhatsApp API Gateway

fix(identity): retry a lid phone write that failed

Yudhi Armyndharisf05e85521554
diff --git a/src/engine/identity/lid-mapping-store.service.ts b/src/engine/identity/lid-mapping-store.service.ts
index 4fc4a9ea6..3278d9c18 100644
--- a/src/engine/identity/lid-mapping-store.service.ts
+++ b/src/engine/identity/lid-mapping-store.service.ts
@@ -300,6 +300,8 @@ export class LidMappingStoreService implements LidMappingStore, OnModuleInit {
if (phone === null) await this.clear(lid, sessionId ?? null);
else await this.repo.upsert({ lid, phone, sessionId: sessionId ?? null, updatedAt: new Date() }, ['lid']);
} catch (err) {
+ // The table does not have this report, so the session's next one writes again.
+ if (sessionId) this.seenBy.get(lid)?.delete(sessionId);
this.logger.warn(
`Failed to persist lid->phone mapping for ${lid}: ${err instanceof Error ? err.message : String(err)}`,
);
diff --git a/src/engine/identity/lid-mapping-store.spec.ts b/src/engine/identity/lid-mapping-store.spec.ts
index 728ac2766..48248dc12 100644
--- a/src/engine/identity/lid-mapping-store.spec.ts
+++ b/src/engine/identity/lid-mapping-store.spec.ts
@@ -1051,6 +1051,21 @@ describe('LidMappingStoreService: a negative result on the shared table', () =>
expect(upsert).toHaveBeenCalledTimes(1);
});
+ it('takes the row on the next report when taking it failed to write', async () => {
+ await store.remember('111', '628111', s1);
+ jest.spyOn(repo, 'upsert').mockRejectedValueOnce(new Error('connection lost'));
+ await expect(store.remember('111', '628111', s2)).resolves.toBeUndefined();
+ expect(warn).toHaveBeenCalledTimes(1);
+ warn.mockClear();
+ expect(await row('111')).toMatchObject({ phone: '628111', sessionId: s1 });
+
+ await store.remember('111', '628111', s2);
+ expect(await row('111')).toMatchObject({ phone: '628111', sessionId: s2 });
+ await store.remember('111', null, s1);
+
+ expect(await row('111')).toMatchObject({ phone: '628111', sessionId: s2 });
+ });
+
it('keeps a phone stored while the negative of another session is being written', async () => {
const update = hold('update');
const negative = store.remember('111', null, s2);