Skip to content

Beautiful Open-Source Form Builder

4.7 KB
Raw Blame
<?php

use App\Http\Controllers\Forms\FormController;
use Illuminate\Http\UploadedFile;
use Illuminate\Routing\Middleware\ThrottleRequests;
use Illuminate\Support\Facades\Storage;
use Illuminate\Support\Str;

it('rejects html uploads in the temp upload endpoint', function () {
    Storage::fake();

    $response = $this->post('/upload-file', [
        'file' => UploadedFile::fake()->createWithContent('evil.html', '<html><script>alert(1)</script></html>'),
    ]);

    $response->assertStatus(422)
        ->assertJsonValidationErrors('file');
});

it('rejects xml uploads in the temp upload endpoint', function () {
    Storage::fake();

    $response = $this->post('/upload-file', [
        'file' => UploadedFile::fake()->createWithContent('evil.xml', '<?xml version="1.0"?><root><script/></root>'),
    ]);

    $response->assertStatus(422)
        ->assertJsonValidationErrors('file');
});

it('sanitizes svg uploads before storing them in temporary storage', function () {
    Storage::fake();

    $response = $this->post('/upload-file', [
        'file' => UploadedFile::fake()->createWithContent('evil.svg', '<svg xmlns="http://www.w3.org/2000/svg"><script>alert(1)</script><rect width="5" height="5"/></svg>'),
    ]);

    $response->assertCreated();

    $storedContents = Storage::get($response->json('key'));
    expect($storedContents)
        ->not->toContain('<script')
        ->toContain('<svg');
});

it('rejects blocked active content when moving temp files to public assets', function () {
    Storage::fake();

    $uuid = (string) Str::uuid();
    Storage::put('tmp/' . $uuid, '<html><script>alert(1)</script></html>');

    $response = $this->postJson('/open/forms/assets/upload', [
        'url' => 'evil_' . $uuid . '.html',
        'type' => 'files',
    ]);

    $response->assertStatus(422)
        ->assertJsonValidationErrors('url');
});

it('sanitizes svg files when moving them to public assets', function () {
    Storage::fake();

    $uuid = (string) Str::uuid();
    Storage::put('tmp/' . $uuid, '<svg xmlns="http://www.w3.org/2000/svg"><script>alert(1)</script><rect width="5" height="5"/></svg>');

    $response = $this->postJson('/open/forms/assets/upload', [
        'url' => 'evil_' . $uuid . '.svg',
        'type' => 'files',
    ]);

    $response->assertOk();

    $storedContents = Storage::get(FormController::ASSETS_UPLOAD_PATH . '/evil_' . $uuid . '.svg');
    expect($storedContents)
        ->not->toContain('<script')
        ->toContain('<svg');
});

it('throttles the unauthenticated upload endpoints without triple-counting a request', function () {
    Storage::fake();
    config([
        'opnform.public_uploads.rate_limit.per_minute' => 10,
        'opnform.public_uploads.rate_limit.per_hour' => 30,
    ]);
    $this->withMiddleware(ThrottleRequests::class);
    $this->withServerVariables(['REMOTE_ADDR' => '192.0.2.10']);

    for ($attempt = 0; $attempt < 10; $attempt++) {
        $response = $this->post('/upload-file', [
            'file' => UploadedFile::fake()->createWithContent('note-' . $attempt . '.txt', 'ok'),
        ]);

        $response->assertCreated();
    }

    $this->post('/upload-file', [
        'file' => UploadedFile::fake()->createWithContent('note-throttled.txt', 'ok'),
    ])->assertStatus(429);

    $this->withServerVariables(['REMOTE_ADDR' => '192.0.2.11']);

    for ($attempt = 0; $attempt < 10; $attempt++) {
        $uuid = (string) Str::uuid();
        Storage::put('tmp/' . $uuid, 'safe file');

        $response = $this->postJson('/open/forms/assets/upload', [
            'url' => 'asset_' . $uuid . '.txt',
            'type' => 'files',
        ]);

        $response->assertOk();
    }

    $uuid = (string) Str::uuid();
    Storage::put('tmp/' . $uuid, 'safe file');

    $this->postJson('/open/forms/assets/upload', [
        'url' => 'asset_' . $uuid . '.txt',
        'type' => 'files',
    ])->assertStatus(429);
});

it('keeps public upload endpoint rate limit buckets separate for the same client', function () {
    Storage::fake();
    config([
        'opnform.public_uploads.rate_limit.per_minute' => 10,
        'opnform.public_uploads.rate_limit.per_hour' => 30,
    ]);
    $this->withMiddleware(ThrottleRequests::class);
    $this->withServerVariables(['REMOTE_ADDR' => '192.0.2.12']);

    for ($attempt = 0; $attempt < 10; $attempt++) {
        $response = $this->post('/upload-file', [
            'file' => UploadedFile::fake()->createWithContent('note-' . $attempt . '.txt', 'ok'),
        ]);

        $response->assertCreated();
    }

    $uuid = (string) Str::uuid();
    Storage::put('tmp/' . $uuid, 'safe file');

    $this->postJson('/open/forms/assets/upload', [
        'url' => 'asset_' . $uuid . '.txt',
        'type' => 'files',
    ])->assertOk();
});