Beautiful Open-Source Form Builder
on fetch submission data display error if there (#608)
Chirag Chhatrala2c8f7d5d54b3
diff --git a/api/app/Http/Controllers/Forms/PublicFormController.php b/api/app/Http/Controllers/Forms/PublicFormController.phpindex 059b829e9..0110ab823 100644--- a/api/app/Http/Controllers/Forms/PublicFormController.php+++ b/api/app/Http/Controllers/Forms/PublicFormController.php@@ -141,7 +141,14 @@ class PublicFormController extends Controller]);}- $submission = new FormSubmissionResource(FormSubmission::findOrFail($submissionId));+ $submission = FormSubmission::find($submissionId);+ if (!$submission) {+ return $this->error([+ 'message' => 'Submission not found.',+ ]);+ }++ $submission = new FormSubmissionResource($submission);$submission->publiclyAccessed();if ($submission->form_id != $form->id) {diff --git a/client/components/open/forms/OpenForm.vue b/client/components/open/forms/OpenForm.vueindex 6e06072ea..2569ca42d 100644--- a/client/components/open/forms/OpenForm.vue+++ b/client/components/open/forms/OpenForm.vue@@ -418,6 +418,9 @@ export default {await this.recordsStore.loadRecord(opnFetch('/forms/' + this.form.slug + '/submissions/' + this.form.submission_id).then((data) => {return {submission_id: this.form.submission_id, id: this.form.submission_id, ...data.data}+ }).catch((error) => {+ useAlert().error(error?.data?.message || 'Something went wrong')+ return null}))return this.recordsStore.getByKey(this.form.submission_id)