Skip to content

Beautiful Open-Source Form Builder

Refactor VSelect component and theme styles for improved option presentation

Chirag Chhatrala344cd59c1912
diff --git a/client/components/forms/core/components/VSelect.vue b/client/components/forms/core/components/VSelect.vue
index f0f534c4a..767a74077 100644
--- a/client/components/forms/core/components/VSelect.vue
+++ b/client/components/forms/core/components/VSelect.vue
@@ -163,7 +163,6 @@
role="option"
:aria-selected="filteredOptions[virtualItem.index] ? isSelected(filteredOptions[virtualItem.index]) : false"
:data-index="virtualItem.index"
- :ref="virtualizer ? virtualizer.measureElement : null"
:style="[
optionStyle,
{
@@ -568,8 +567,7 @@ export default {
count: this.filteredOptions.length,
getScrollElement: () => this.$refs.scrollRef,
estimateSize: () => this.estimatedItemSizePx,
- overscan: 5,
- measureElement: (el) => el?.getBoundingClientRect().height ?? 0
+ overscan: 5
})
restoreScroll()
diff --git a/client/lib/forms/themes/v-select.theme.js b/client/lib/forms/themes/v-select.theme.js
index 8004126e8..c8220645d 100644
--- a/client/lib/forms/themes/v-select.theme.js
+++ b/client/lib/forms/themes/v-select.theme.js
@@ -117,7 +117,7 @@ export const vSelectTheme = {
placeholder: 'text-xs',
clearButton: 'py-1.5',
dropdown: 'text-xs',
- option: 'px-2.5 min-h-[28px]'
+ option: 'px-2.5'
},
sm: {
button: 'px-2 py-1.5',
@@ -125,7 +125,7 @@ export const vSelectTheme = {
placeholder: 'text-sm',
clearButton: 'py-1.5',
dropdown: 'text-sm',
- option: 'px-2 py-0.5 min-h-[32px]'
+ option: 'px-2 py-0.5'
},
md: {
button: 'px-4 py-2',
@@ -133,7 +133,7 @@ export const vSelectTheme = {
placeholder: 'text-base',
clearButton: 'py-2',
dropdown: 'text-base',
- option: 'px-4 py-1.5 min-h-[40px]'
+ option: 'px-4 py-1.5'
},
lg: {
button: 'px-5 py-3',
@@ -141,7 +141,7 @@ export const vSelectTheme = {
placeholder: 'text-lg',
clearButton: 'py-3',
dropdown: 'text-lg',
- option: 'px-5 py-2 min-h-[52px]'
+ option: 'px-5 py-2'
}
},
borderRadius: {