Skip to content

Beautiful Open-Source Form Builder

Fix user impersonation

Julien Nahum34cb84d6592b
diff --git a/client/app.vue b/client/app.vue
index 142e9ce4e..80c8e1dcb 100644
--- a/client/app.vue
+++ b/client/app.vue
@@ -11,7 +11,7 @@
<ClientOnly>
<div
- class="fixed left-0 bottom-0 p-4"
+ class="fixed z-[9999] left-0 bottom-0 p-4" id="admin-actions"
>
<UButtonGroup size="sm">
<ToolsStopImpersonation />
diff --git a/client/components/pages/admin/ImpersonateUser.vue b/client/components/pages/admin/ImpersonateUser.vue
index c1459cf64..98174268b 100644
--- a/client/components/pages/admin/ImpersonateUser.vue
+++ b/client/components/pages/admin/ImpersonateUser.vue
@@ -1,6 +1,5 @@
<template>
<UButton
- variant="outline"
icon="i-heroicons-eye-16-solid"
:loading="loading"
@click="impersonate"
@@ -9,7 +8,7 @@
</template>
<script setup>
-import { adminApi, authApi } from '~/api'
+import { adminApi } from '~/api'
import { useQueryClient } from '@tanstack/vue-query'
const props = defineProps({
@@ -21,8 +20,6 @@ const queryClient = useQueryClient()
const loading = ref(false)
-const { invalidateAll: invalidateWorkspaces } = useWorkspaces()
-const { invalidateAll: invalidateForms } = useForms()
const { user } = useAuth()
const { data: userData } = user()
@@ -34,15 +31,7 @@ const impersonate = () => {
// Save the token with its expiration time.
authStore.setToken(data.token, data.expires_in)
-
- // Fetch the user.
- await authApi.user.get()
- useAuth().invalidateUser()
-
- // Clear all query cache and invalidate to refetch fresh data for the impersonated user
- queryClient.clear()
- await invalidateWorkspaces()
- await invalidateForms()
+ await queryClient.invalidateQueries()
useAlert().success(`Impersonating ${userData.value.name}`)
useRouter().push({ name: 'home' })
diff --git a/client/components/tools/StopImpersonation.vue b/client/components/tools/StopImpersonation.vue
index dfcc08c8b..c95c80182 100644
--- a/client/components/tools/StopImpersonation.vue
+++ b/client/components/tools/StopImpersonation.vue
@@ -6,7 +6,6 @@
<UButton
color="neutral"
variant="outline"
- :loading="loading"
icon="i-heroicons-arrow-left-start-on-rectangle-20-solid"
@click="reverseImpersonation"
/>
@@ -14,25 +13,15 @@
</template>
<script setup>
-import { authApi } from "~/api/auth"
-
+import { useQueryClient } from '@tanstack/vue-query'
const authStore = useAuthStore()
-const router = useRouter()
+const queryClient = useQueryClient()
const isImpersonating = computed(() => authStore.isImpersonating)
-const loading = ref(false)
function reverseImpersonation() {
- loading.value = true
authStore.stopImpersonating()
-
- // Fetch the user.
- authApi.user.get().then(() => {
- useAuth().invalidateUser()
- useWorkspaces().invalidateAll()
- router.push({ name: 'admin' })
- loading.value = false
- })
+ queryClient.invalidateQueries()
}
</script>