Skip to content

Beautiful Open-Source Form Builder

Fix impersonation for moderator

Julien Nahum3a25178697d1
diff --git a/app/Http/Controllers/Admin/ImpersonationController.php b/app/Http/Controllers/Admin/ImpersonationController.php
index 8f7275304..c2dbf8ae0 100644
--- a/app/Http/Controllers/Admin/ImpersonationController.php
+++ b/app/Http/Controllers/Admin/ImpersonationController.php
@@ -39,7 +39,6 @@ class ImpersonationController extends Controller
]);
}
-
\Log::warning('Impersonation started',[
'from_id' => auth()->id(),
'from_email' => auth()->user()->email,
@@ -47,15 +46,11 @@ class ImpersonationController extends Controller
'target_email' => $user->id,
]);
- // Be this user
- if (auth()->user()->moderator) {
- $token = auth()->claims([
- 'impersonating' => true,
- 'impersonator_id' => auth()->id(),
- ])->login($user);
- } else {
- $token = auth()->login($user);
- }
+ $token = auth()->claims(auth()->user()->admin ? [] : [
+ 'impersonating' => true,
+ 'impersonator_id' => auth()->id(),
+ ])->login($user);
+
return $this->success([
'token' => $token
]);
diff --git a/routes/api.php b/routes/api.php
index b381f5d9b..eaa87d666 100644
--- a/routes/api.php
+++ b/routes/api.php
@@ -116,7 +116,7 @@ Route::group(['middleware' => 'auth:api'], function () {
});
});
- Route::group(['middleware' => 'admin', 'prefix' => 'admin'], function () {
+ Route::group(['middleware' => 'moderator', 'prefix' => 'admin'], function () {
Route::get('impersonate/{identifier}',
[\App\Http\Controllers\Admin\ImpersonationController::class, 'impersonate']);
});