Skip to content

Beautiful Open-Source Form Builder

Enhance ESLint Configuration and Improve Code Consistency

Julien Nahum3dd3147b19c5
diff --git a/client/.eslintrc.cjs b/client/.eslintrc.cjs
index cdf4982d1..e6e9b6af5 100644
--- a/client/.eslintrc.cjs
+++ b/client/.eslintrc.cjs
@@ -14,5 +14,7 @@ module.exports = {
"prefer-rest-params": "off",
"vue/valid-template-root": "off",
"no-undef": "off",
+ "no-unused-vars": ["error", { "argsIgnorePattern": "^_" }],
+ "@typescript-eslint/no-unused-vars": ["error", { "argsIgnorePattern": "^_" }]
},
};
diff --git a/client/components/open/forms/OpenForm.vue b/client/components/open/forms/OpenForm.vue
index 97706fcd7..e8b299481 100644
--- a/client/components/open/forms/OpenForm.vue
+++ b/client/components/open/forms/OpenForm.vue
@@ -134,6 +134,7 @@ import CachedDefaultTheme from "~/lib/forms/themes/CachedDefaultTheme.js"
import FormTimer from './FormTimer.vue'
import { storeToRefs } from 'pinia'
import { FormMode, createFormModeStrategy } from "~/lib/forms/FormModeStrategy.js"
+import clonedeep from 'clone-deep'
export default {
name: 'OpenForm',
diff --git a/client/components/open/forms/components/form-logic-components/ColumnCondition.vue b/client/components/open/forms/components/form-logic-components/ColumnCondition.vue
index 4dba8dd2a..46f036a64 100644
--- a/client/components/open/forms/components/form-logic-components/ColumnCondition.vue
+++ b/client/components/open/forms/components/form-logic-components/ColumnCondition.vue
@@ -104,7 +104,7 @@ export default {
},
operators() {
return Object.entries(this.available_filters[this.property.type].comparators)
- .filter(([filterKey, value]) => this.customValidation || (!this.customValidation && !value.custom_validation_only))
+ .filter(([_, value]) => this.customValidation || (!this.customValidation && !value.custom_validation_only))
.map(([filterKey]) => {
return {
value: filterKey,
diff --git a/client/composables/useAlert.js b/client/composables/useAlert.js
index 2de068e98..67781d4e9 100644
--- a/client/composables/useAlert.js
+++ b/client/composables/useAlert.js
@@ -66,11 +66,11 @@ export function useAlert () {
let description = ''
if (Object.keys(error.errors).length > 0) {
const errorLines = Object.entries(error.errors)
- .map(([field, messages]) => {
+ .map(([_, messages]) => {
// Format each message
const formattedMessages = messages.map(message => {
return `<li>${message}</li>`
- });
+ })
return formattedMessages.join('')
})
diff --git a/client/plugins/pinia-history.js b/client/plugins/pinia-history.js
index a1e7bcdb5..1940dc522 100644
--- a/client/plugins/pinia-history.js
+++ b/client/plugins/pinia-history.js
@@ -12,12 +12,10 @@ function mergeOptions(options) {
max: 30,
persistent: false,
persistentStrategy: {
- // eslint-disable-next-line no-unused-vars
- get: function (store, type) {
+ get: function (_store, _type) {
// Todo
},
- // eslint-disable-next-line no-unused-vars
- set: function (store, type, value) {
+ set: function (_store, _type, _value) {
// Todo
},
remove: function (store, type) {