Beautiful Open-Source Form Builder
Remove unused public form users endpoint (#1309)
Julien Nahum413c20cb837f
diff --git a/api/app/Http/Controllers/Forms/PublicFormController.php b/api/app/Http/Controllers/Forms/PublicFormController.phpindex d415cc603..6cdc53858 100644--- a/api/app/Http/Controllers/Forms/PublicFormController.php+++ b/api/app/Http/Controllers/Forms/PublicFormController.php@@ -14,7 +14,6 @@ use App\Service\Forms\FormSubmissionProcessor;use App\Service\Forms\FormCleaner;use App\Service\Forms\SubmissionUrlService;use App\Service\Storage\SafeFileResponseService;-use App\Service\WorkspaceHelper;use Illuminate\Http\Request;use Illuminate\Support\Facades\Auth;use Illuminate\Support\Facades\Storage;@@ -77,19 +76,6 @@ class PublicFormController extends Controller]);}- public function listUsers(Request $request, Form $form)- {- // Check that form has user field- if (!$form->has_user_field) {- return [];- }-- // Use serializer- $workspace = $form->workspace;-- return (new WorkspaceHelper($workspace))->getAllUsers();- }-public function showAsset(string $assetFileName, SafeFileResponseService $safeFileResponseService){$path = FormController::ASSETS_UPLOAD_PATH . '/' . $assetFileName;diff --git a/api/app/Http/Middleware/ImpersonationMiddleware.php b/api/app/Http/Middleware/ImpersonationMiddleware.phpindex 45b1656a0..271afe770 100644--- a/api/app/Http/Middleware/ImpersonationMiddleware.php+++ b/api/app/Http/Middleware/ImpersonationMiddleware.php@@ -29,7 +29,6 @@ class ImpersonationMiddleware'forms.show','forms.answer','forms.fetchSubmission',- 'forms.users.index','open.forms.index-all','open.forms.show','open.forms.import',diff --git a/api/routes/api.php b/api/routes/api.phpindex d94b9beae..f6a552225 100644--- a/api/routes/api.php+++ b/api/routes/api.php@@ -492,12 +492,6 @@ Route::prefix('forms')->name('forms.')->group(function () {Route::post('{form}/answer', [PublicFormController::class, 'answer'])->name('answer')->middleware(HandlePrecognitiveRequests::class);Route::get('{form}/stripe-connect/get-account', [FormPaymentController::class, 'getAccount'])->name('stripe-connect.get-account')->middleware(HandlePrecognitiveRequests::class);Route::post('{form}/stripe-connect/payment-intent', [FormPaymentController::class, 'createIntent'])->name('stripe-connect.create-intent')->middleware(HandlePrecognitiveRequests::class);-- // Form content endpoints (user lists, relation lists etc.)- Route::get(- '{form}/users',- [PublicFormController::class, 'listUsers']- )->name('users.index');});// File uploadsdiff --git a/api/tests/Feature/Forms/PublicFormUsersTest.php b/api/tests/Feature/Forms/PublicFormUsersTest.phpnew file mode 100644index 000000000..a950cdd7d--- /dev/null+++ b/api/tests/Feature/Forms/PublicFormUsersTest.php@@ -0,0 +1,18 @@+<?php++it('does not expose a public form users endpoint', function (bool $selfHosted) {+ config(['app.self_hosted' => $selfHosted]);++ $user = $this->createUser();+ $workspace = $this->createUserWorkspace($user);+ $form = $this->createForm($user, $workspace, ['visibility' => 'public']);++ $this->getJson('/forms/'.$form->slug.'/users')->assertNotFound();+ $this->getJson('/forms/'.$form->id.'/users?has_user_field=1')->assertNotFound();++ $this->actingAsUser($user);+ $this->getJson('/forms/'.$form->slug.'/users')->assertNotFound();+})->with([+ 'cloud' => [false],+ 'self-hosted' => [true],+]);diff --git a/docs/api-reference/changelog.mdx b/docs/api-reference/changelog.mdxindex 2bcd8e5d2..341f3e217 100644--- a/docs/api-reference/changelog.mdx+++ b/docs/api-reference/changelog.mdx@@ -3,6 +3,12 @@ title: "Changelog"description: "Notable updates to the OpnForm API."---+## 2026-10-01 – Removed unused public form users endpoint++`GET /forms/{form}/users` has been removed and now returns `404`. The application does not use this endpoint.++To list workspace members, use the authenticated `GET /open/workspaces/{workspaceId}/users` endpoint with the `workspace-users-read` token ability.+## 2026-05-27 – Workspace invite listing requires admin accessThe workspace invite listing endpoint now requires workspace admin access: