Skip to content

Beautiful Open-Source Form Builder

Enhance FormController to include cleaning data in form responses (#875)

Chirag Chhatrala45cf07181bf8
diff --git a/api/app/Http/Controllers/Forms/FormController.php b/api/app/Http/Controllers/Forms/FormController.php
index 2fc83f192..e6a501bd0 100644
--- a/api/app/Http/Controllers/Forms/FormController.php
+++ b/api/app/Http/Controllers/Forms/FormController.php
@@ -42,14 +42,23 @@ class FormController extends Controller
->orderByDesc('updated_at')
->paginate(10);
- return FormResource::collection($forms);
+ $formCollection = FormResource::collection($forms);
+ $formCollection->each(function ($formResource) {
+ $formResource->setCleanings(
+ $this->formCleaner->processForm(request(), $formResource->resource)->simulateCleaning($formResource->resource->workspace)->getPerformedCleanings()
+ );
+ });
+
+ return $formCollection;
}
public function show(Form $form)
{
$this->authorize('view', $form);
- return new FormResource($form);
+ return (new FormResource($form))->setCleanings(
+ $this->formCleaner->processForm(request(), $form)->simulateCleaning($form->workspace)->getPerformedCleanings()
+ );
}
/**
diff --git a/client/components/open/forms/components/FormEditor.vue b/client/components/open/forms/components/FormEditor.vue
index fd7eb78ad..1f5e9e299 100644
--- a/client/components/open/forms/components/FormEditor.vue
+++ b/client/components/open/forms/components/FormEditor.vue
@@ -297,10 +297,7 @@ const saveFormEdit = () => {
form_id: updatedForm.id,
form_slug: updatedForm.slug,
})
- displayFormModificationAlert({
- form: updatedForm,
- message: "Form successfully saved.",
- })
+ displayFormModificationAlert(response)
} catch (error) {
console.error("Analytics error", error)
}
@@ -352,10 +349,7 @@ const saveFormCreate = () => {
} catch (error) {
console.error("Analytics error", error)
}
- displayFormModificationAlert({
- form: newForm,
- message: "Form successfully created.",
- })
+ displayFormModificationAlert(response)
useRouter().push({
name: "forms-slug-show-share",