Skip to content

Beautiful Open-Source Form Builder

ESC-872 - feat: add 'status' column to form submission export request validation (#1102)

Chirag Chhatrala6e9661067d15
diff --git a/api/app/Http/Requests/FormSubmissionExportRequest.php b/api/app/Http/Requests/FormSubmissionExportRequest.php
index 89f1dd511..e5bd065e0 100644
--- a/api/app/Http/Requests/FormSubmissionExportRequest.php
+++ b/api/app/Http/Requests/FormSubmissionExportRequest.php
@@ -23,6 +23,7 @@ class FormSubmissionExportRequest extends FormRequest
$this->form->removed_properties ?? []
))->pluck('id')->toArray();
$validColumns[] = 'created_at';
+ $validColumns[] = 'status';
return [
'columns' => [
diff --git a/api/tests/Feature/Forms/FormSubmissionExportTest.php b/api/tests/Feature/Forms/FormSubmissionExportTest.php
index 1138ea00b..6102f56e8 100644
--- a/api/tests/Feature/Forms/FormSubmissionExportTest.php
+++ b/api/tests/Feature/Forms/FormSubmissionExportTest.php
@@ -139,6 +139,31 @@ it('rejects submission ids that do not belong to the form', function () {
->assertJsonValidationErrors(['submissionIds.0']);
});
+it('accepts status as a valid export column', function () {
+ $user = $this->actingAsProUser();
+ $workspace = $this->createUserWorkspace($user);
+ $form = $this->createForm($user, $workspace);
+
+ $textField = collect($form->properties)->firstWhere('type', 'text');
+ $submissionData = $this->generateFormSubmissionData($form, [
+ $textField['id'] => 'John Doe',
+ ]);
+ $this->postJson(route('forms.answer', $form->slug), $submissionData)
+ ->assertSuccessful();
+
+ $response = $this->postJson(route('open.forms.submissions.export', [
+ 'form' => $form,
+ ]), [
+ 'columns' => [
+ $textField['id'] => true,
+ 'status' => true,
+ ],
+ ]);
+
+ $response->assertSuccessful()
+ ->assertHeader('content-disposition', 'attachment; filename=' . $form->slug . '-submission-data.csv');
+});
+
it('cannot export form submissions with invalid columns', function () {
$user = $this->actingAsProUser();
$workspace = $this->createUserWorkspace($user);