Skip to content

Beautiful Open-Source Form Builder

Truncate long form titles (#1166)

Julien Nahumb7b42ff961fa
diff --git a/api/app/Http/Requests/UserFormRequest.php b/api/app/Http/Requests/UserFormRequest.php
index 37f6fe9da..1d5a26d7e 100644
--- a/api/app/Http/Requests/UserFormRequest.php
+++ b/api/app/Http/Requests/UserFormRequest.php
@@ -13,6 +13,7 @@ use Illuminate\Contracts\Validation\Validator;
use Illuminate\Validation\Rule;
use Illuminate\Http\Request;
use App\Rules\CssOnlyRule;
+use Illuminate\Support\Str;
use Stevebauman\Purify\Facades\Purify;
/**
@@ -34,6 +35,10 @@ abstract class UserFormRequest extends \Illuminate\Foundation\Http\FormRequest
{
$data = $this->all();
+ if (isset($data['title']) && is_string($data['title'])) {
+ $data['title'] = Str::substr(trim($data['title']), 0, 255);
+ }
+
if (isset($data['properties']) && is_array($data['properties'])) {
$data['properties'] = array_map(function ($property) {
if (!is_array($property)) {
@@ -157,7 +162,7 @@ abstract class UserFormRequest extends \Illuminate\Foundation\Http\FormRequest
return [
// Form Info
- 'title' => 'required|string|max:60',
+ 'title' => 'required|string|max:255',
'description' => 'nullable|string|max:2000',
'tags' => 'nullable|array',
'visibility' => ['required', Rule::in(Form::VISIBILITY)],
@@ -259,6 +264,8 @@ abstract class UserFormRequest extends \Illuminate\Foundation\Http\FormRequest
{
// Note: Property-specific messages are now handled by FormPropertiesRule
// for better performance (single-pass validation)
- return [];
+ return [
+ 'title.max' => 'Form name must be 255 characters or fewer.',
+ ];
}
}
diff --git a/api/app/Service/FormImport/Importers/FilloutImporter.php b/api/app/Service/FormImport/Importers/FilloutImporter.php
index bfc8861fb..ca3e3152e 100644
--- a/api/app/Service/FormImport/Importers/FilloutImporter.php
+++ b/api/app/Service/FormImport/Importers/FilloutImporter.php
@@ -55,7 +55,7 @@ class FilloutImporter extends AbstractImporter
throw new FormImportException('Could not find form data in the page structure.');
}
- $title = $this->sanitizeText($pageProps['flow']['name'] ?? 'Imported Fillout Form', 60);
+ $title = $this->sanitizeText($pageProps['flow']['name'] ?? 'Imported Fillout Form', 255);
$template = $pageProps['flowSnapshot']['template'] ?? [];
$stepsMap = $this->asMap($template['steps'] ?? []);
diff --git a/api/app/Service/FormImport/Importers/GoogleFormsImporter.php b/api/app/Service/FormImport/Importers/GoogleFormsImporter.php
index 2c7d0ba74..92eb36a13 100644
--- a/api/app/Service/FormImport/Importers/GoogleFormsImporter.php
+++ b/api/app/Service/FormImport/Importers/GoogleFormsImporter.php
@@ -122,7 +122,7 @@ class GoogleFormsImporter extends AbstractImporter
private function parseFormData(array $data): array
{
- $title = $this->sanitizeText($data['info']['title'] ?? $data['info']['documentTitle'] ?? 'Imported Google Form', 60);
+ $title = $this->sanitizeText($data['info']['title'] ?? $data['info']['documentTitle'] ?? 'Imported Google Form', 255);
$description = $this->sanitizeText($data['info']['description'] ?? '', 8000);
$items = $data['items'] ?? [];
diff --git a/api/app/Service/FormImport/Importers/TallyImporter.php b/api/app/Service/FormImport/Importers/TallyImporter.php
index 91347f965..32078c06a 100644
--- a/api/app/Service/FormImport/Importers/TallyImporter.php
+++ b/api/app/Service/FormImport/Importers/TallyImporter.php
@@ -90,7 +90,7 @@ class TallyImporter extends AbstractImporter
throw new FormImportException('Could not find Tally form blocks in the page data.');
}
- $title = $this->sanitizeText($pageProps['name'] ?? $pageProps['title'] ?? 'Imported Tally Form', 60);
+ $title = $this->sanitizeText($pageProps['name'] ?? $pageProps['title'] ?? 'Imported Tally Form', 255);
['properties' => $properties, 'settings' => $settings] = $this->mapBlocks($blocks);
return [
diff --git a/api/app/Service/FormImport/Importers/TypeformImporter.php b/api/app/Service/FormImport/Importers/TypeformImporter.php
index 8590f94ba..0536bb423 100644
--- a/api/app/Service/FormImport/Importers/TypeformImporter.php
+++ b/api/app/Service/FormImport/Importers/TypeformImporter.php
@@ -48,7 +48,7 @@ class TypeformImporter extends AbstractImporter
$html = $this->fetchHtml($url);
$formData = $this->extractFormData($html);
- $title = $this->sanitizeText($formData['title'] ?? 'Imported Typeform', 60);
+ $title = $this->sanitizeText($formData['title'] ?? 'Imported Typeform', 255);
$properties = [];
if ($welcome = $this->renderWelcomeScreen($formData['welcome_screens'] ?? [])) {
$properties[] = $welcome;
diff --git a/api/tests/Feature/Forms/FormTest.php b/api/tests/Feature/Forms/FormTest.php
index 4127097fb..29f6cd47c 100644
--- a/api/tests/Feature/Forms/FormTest.php
+++ b/api/tests/Feature/Forms/FormTest.php
@@ -146,6 +146,24 @@ it('can update a form', function () {
]);
});
+it('truncates form titles longer than the database limit when updating a form', function () {
+ $user = $this->actingAsUser();
+ $workspace = $this->createUserWorkspace($user);
+ $form = $this->createForm($user, $workspace);
+
+ $formData = (new \App\Http\Resources\FormResource($form))->toArray(request());
+ $formData['title'] = str_repeat('a', 300);
+
+ $this->putJson(route('open.forms.update', $form->id), $formData)
+ ->assertSuccessful()
+ ->assertJsonPath('form.title', str_repeat('a', 255));
+
+ $this->assertDatabaseHas('forms', [
+ 'id' => $form->id,
+ 'title' => str_repeat('a', 255),
+ ]);
+});
+
it('backfills missing select option ids when creating a form', function () {
$user = $this->actingAsUser();
$workspace = $this->createUserWorkspace($user);
diff --git a/client/components/app/EditableTag.vue b/client/components/app/EditableTag.vue
index 292d2abef..bafb6fde3 100644
--- a/client/components/app/EditableTag.vue
+++ b/client/components/app/EditableTag.vue
@@ -27,6 +27,7 @@
v-model="content"
class="absolute inset-0 focus:outline-hidden bg-white rounded-sm transition-colors px-2"
:class="[{ 'bg-blue-50': editing }, contentClass]"
+ :maxlength="maxLength"
@blur="editing = false"
@keyup.enter="editing = false"
@input="handleInput"
@@ -43,6 +44,7 @@ const props = defineProps({
textAlign: { type: String, default: "left" },
contentClass: { type: String, default: "" },
element: { type: String, default: 'div' }, // New prop for element type
+ maxLength: { type: Number, default: null },
})
const emit = defineEmits(['update:modelValue'])
diff --git a/client/components/open/forms/components/FormEditorNavbar.vue b/client/components/open/forms/components/FormEditorNavbar.vue
index 96eac24cd..3ec0e9214 100644
--- a/client/components/open/forms/components/FormEditorNavbar.vue
+++ b/client/components/open/forms/components/FormEditorNavbar.vue
@@ -46,6 +46,7 @@
id="form-editor-title"
v-model="form.title"
element="h3"
+ :max-length="255"
class="font-medium py-1 text-md w-48 text-neutral-500 truncate form-editor-title"
/>
<UBadge
diff --git a/client/components/open/forms/components/form-components/FormErrorModal.vue b/client/components/open/forms/components/form-components/FormErrorModal.vue
index b12df0037..fc77c2cd8 100644
--- a/client/components/open/forms/components/form-components/FormErrorModal.vue
+++ b/client/components/open/forms/components/form-components/FormErrorModal.vue
@@ -14,12 +14,15 @@
class="text-red-800 mb-3"
v-text="validationErrorResponse.message"
/>
- <ul class="list-disc list-inside text-red-700 space-y-1">
+ <ul
+ v-if="validationErrors.length > 0"
+ class="list-disc list-inside text-red-700 space-y-1"
+ >
<li
- v-for="(err, key) in validationErrorResponse.errors"
+ v-for="(err, key) in validationErrors"
:key="key"
>
- {{ Array.isArray(err) ? err[0] : err }}
+ {{ err }}
</li>
</ul>
</div>
@@ -47,6 +50,18 @@ const props = defineProps({
const emit = defineEmits(['close'])
+const validationErrors = computed(() => {
+ if (!props.validationErrorResponse?.errors) {
+ return []
+ }
+
+ const errors = Object.values(props.validationErrorResponse.errors).map((err) => {
+ return Array.isArray(err) ? err[0] : err
+ })
+
+ return errors.filter((err) => err !== props.validationErrorResponse.message)
+})
+
// Modal state
const isOpen = computed({
get: () => props.show,
diff --git a/client/components/open/forms/components/form-components/FormInformation.vue b/client/components/open/forms/components/form-components/FormInformation.vue
index 48201fe20..01a487326 100644
--- a/client/components/open/forms/components/form-components/FormInformation.vue
+++ b/client/components/open/forms/components/form-components/FormInformation.vue
@@ -16,6 +16,8 @@
class="mt-4 max-w-xs"
label="Form Name"
placeholder="My form"
+ :max-char-limit="255"
+ :show-char-limit="true"
/>
<select-input
name="tags"