Skip to content

Beautiful Open-Source Form Builder

fix image block (#919)

Chirag Chhatralac0677d8b5a6f
diff --git a/client/components/open/forms/BlockRenderer.vue b/client/components/open/forms/BlockRenderer.vue
index aa5a6bafa..64aa98afe 100644
--- a/client/components/open/forms/BlockRenderer.vue
+++ b/client/components/open/forms/BlockRenderer.vue
@@ -41,6 +41,31 @@
:key="'divider-' + block.id"
class="border-b my-4 w-full mx-2"
/>
+ <div
+ v-else-if="block.type === 'nf-image'"
+ :id="block.id"
+ :key="block.id"
+ class="my-4 w-full px-2"
+ :class="[getFieldAlignClasses(block)]"
+ @dblclick="editFieldOptions"
+ >
+ <div
+ v-if="!block.image_block"
+ class="p-4 border border-dashed text-center"
+ >
+ <a
+ href="#"
+ class="text-blue-800 dark:text-blue-200"
+ @click.prevent="editFieldOptions"
+ >Open block settings to upload image.</a>
+ </div>
+ <img
+ v-else
+ :alt="block.name"
+ :src="block.image_block"
+ class="max-w-full inline-block rounded-lg"
+ >
+ </div>
</div>
</template>
@@ -54,6 +79,8 @@ const props = defineProps({
formManager: { type: Object, required: true }
})
+const workingFormStore = useWorkingFormStore()
+
const form = computed(() => props.formManager?.config?.value || {})
const dataForm = computed(() => props.formManager?.form || {})
const darkMode = computed(() => props.formManager?.darkMode?.value || false)
@@ -217,6 +244,10 @@ const boundProps = computed(() => {
return inputProperties
})
+
+const editFieldOptions = () => {
+ workingFormStore.openSettingsForField(props.block, true)
+}
</script>
diff --git a/client/components/open/forms/OpenFormField.vue b/client/components/open/forms/OpenFormField.vue
index 513feb7a6..18fe3877b 100644
--- a/client/components/open/forms/OpenFormField.vue
+++ b/client/components/open/forms/OpenFormField.vue
@@ -80,55 +80,7 @@
<div v-if="field">
<BlockRenderer :block="field" :form-manager="formManager" />
</div>
- <template v-else>
- <div
- v-if="field.type === 'nf-text' && field.content"
- :id="field.id"
- :key="field.id"
- class="nf-text w-full my-1.5 break-words whitespace-break-spaces"
- :class="[getFieldAlignClasses(field)]"
- v-html="field.content"
- @dblclick="editFieldOptions"
- />
- <div
- v-if="field.type === 'nf-code' && field.content"
- :id="field.id"
- :key="field.id"
- class="nf-code w-full px-2 my-1.5"
- v-html="field.content"
- />
- <div
- v-if="field.type === 'nf-divider'"
- :id="field.id"
- :key="field.id"
- class="border-b my-4 w-full mx-2"
- />
- <div
- v-if="field.type === 'nf-image' && (field.image_block || !isPublicFormPage)"
- :id="field.id"
- :key="field.id"
- class="my-4 w-full px-2"
- :class="[getFieldAlignClasses(field)]"
- @dblclick="editFieldOptions"
- >
- <div
- v-if="!field.image_block"
- class="p-4 border border-dashed text-center"
- >
- <a
- href="#"
- class="text-blue-800 dark:text-blue-200"
- @click.prevent="editFieldOptions"
- >Open block settings to upload image.</a>
- </div>
- <img
- v-else
- :alt="field.name"
- :src="field.image_block"
- class="max-w-full inline-block rounded-lg"
- >
- </div>
- </template>
+
<div
class="hidden group-hover/nffield:flex translate-x-full absolute right-0 top-0 h-full w-5 flex-col justify-center pl-1 pt-3"
>
@@ -178,8 +130,6 @@ const isAdminPreview = computed(() => strategy.value?.admin?.showAdminControls |
// Computed properties
// Field rendering is delegated to BlockRenderer
-const isPublicFormPage = computed(() => useRoute().name === 'forms-slug')
-
const isFieldHidden = computed(() => !showHidden.value && shouldBeHidden.value)
const shouldBeHidden = computed(() =>
@@ -221,17 +171,6 @@ function removeField() {
workingFormStore.removeField(props.field)
}
-function getFieldAlignClasses(field) {
- if (!field.align || field.align === 'left') return 'text-left'
- else if (field.align === 'right') {
- return 'text-right'
- } else if (field.align === 'center') {
- return 'text-center'
- } else if (field.align === 'justify') {
- return 'text-justify'
- }
-}
-
/**
* Get the right input component options for the field/options
*/
diff --git a/client/components/open/forms/fields/components/BlockOptions.vue b/client/components/open/forms/fields/components/BlockOptions.vue
index 7d8d42311..028530781 100644
--- a/client/components/open/forms/fields/components/BlockOptions.vue
+++ b/client/components/open/forms/fields/components/BlockOptions.vue
@@ -23,7 +23,7 @@
<OptionSelectorInput
v-model="field.width"
name="width"
- class="grow"
+ class="grow mt-4"
:form="field"
label="Block Width"
seamless
@@ -43,7 +43,7 @@
v-if="['nf-text', 'nf-image'].includes(field.type)"
v-model="field.align"
name="align"
- class="w-2/3"
+ class="mt-4 w-2/3"
:form="field"
label="Text Alignment"
seamless