Skip to content

Beautiful Open-Source Form Builder

Refactor condition checking logic in FormLogicConditionChecker.js (#872)

Chirag Chhatralac7d055546075
diff --git a/client/lib/forms/FormLogicConditionChecker.js b/client/lib/forms/FormLogicConditionChecker.js
index 7cc5ce29b..de329201f 100644
--- a/client/lib/forms/FormLogicConditionChecker.js
+++ b/client/lib/forms/FormLogicConditionChecker.js
@@ -84,11 +84,12 @@ function areValidNumbers(condition, fieldValue) {
}
function checkEquals(condition, fieldValue) {
+ const conditionValue = condition.value
// For numeric values, convert to numbers before comparison
- if (areValidNumbers(condition, fieldValue)) {
- return parseFloat(condition.value) === parseFloat(fieldValue)
+ if (areValidNumbers(condition, fieldValue) && typeof conditionValue === 'number' && typeof fieldValue === 'number') {
+ return parseFloat(conditionValue) === parseFloat(fieldValue)
}
- return condition.value === fieldValue
+ return conditionValue === fieldValue
}
function checkObjectEquals(condition, fieldValue) {