Skip to content

armgit / Orkas

Public Imported from GitHub
0

Orkas is an open-source (MIT), local-first AI team for your desktop: a Commander turns your goal into to-dos and coordinates 16 built-in specialist agents plus Claude Code, Codex, OpenCode, OpenClaw and Hermes, with projects, scheduled automations and connectors. Free app for macOS & Windows; built-in models or your own keys.

fix(browser): report the configured tab limit

wyt0cca14d2a326
diff --git a/src/main/features/web_assist.ts b/src/main/features/web_assist.ts
index 9f85728f..24e7dc8d 100644
--- a/src/main/features/web_assist.ts
+++ b/src/main/features/web_assist.ts
@@ -1662,7 +1662,7 @@ function createTabWithinLimit(
const removable = tabCapacityVictims(record, conversationId, openerId);
if (!removable) return null;
// Allocate first: a native-view creation failure must not lose existing work.
- // createTab does not emit state, so the renderer never sees an eleventh tab.
+ // createTab does not emit state, so the renderer never sees tabs beyond the limit.
const tab = createTab(record, conversationId, label, createdBy, options);
for (const old of removable) removeTab(record, old, false);
return { tab, closedTabIds: removable.map(old => old.id) };
@@ -1671,7 +1671,7 @@ function createTabWithinLimit(
function tabLimitFailure() {
return {
ok: false as const, code: 'too_many_tabs', tab_limit: MAX_TABS_PER_CONVERSATION,
- error: 'This task has reached its 10-tab limit with no safely removable old model tab. Reuse an existing tab with navigate, or close an unneeded tab before opening another.',
+ error: `This task has reached its ${MAX_TABS_PER_CONVERSATION}-tab limit with no safely removable old model tab. Reuse an existing tab with navigate, or close an unneeded tab before opening another.`,
};
}
diff --git a/test/main/features/web-assist-control.test.ts b/test/main/features/web-assist-control.test.ts
index 98e9539c..b8e1250c 100644
--- a/test/main/features/web-assist-control.test.ts
+++ b/test/main/features/web-assist-control.test.ts
@@ -1603,7 +1603,7 @@ describe('Web Assist controlled connector lifecycle', () => {
if (!created.at(-1)?.ok) throw new Error('tab setup failed');
expect(created.at(-1)!.state.tabs).toHaveLength(TAB_LIMIT);
expect(addWebAssistTab('u1', renderer, { conversationId: 'c-limit' }))
- .toMatchObject({ ok: false, code: 'too_many_tabs' });
+ .toMatchObject({ ok: false, code: 'too_many_tabs', error: expect.stringContaining(`${TAB_LIMIT}-tab limit`) });
await expect(openWebAssist('u1', renderer, {
conversationId: 'c-limit',
url: 'https://example.com/eleventh',