Skip to content

armgit / Orkas

Public Imported from GitHub
0

Orkas is an open-source (MIT), local-first AI team for your desktop: a Commander turns your goal into to-dos and coordinates 16 built-in specialist agents plus Claude Code, Codex, OpenCode, OpenClaw and Hermes, with projects, scheduled automations and connectors. Free app for macOS & Windows; built-in models or your own keys.

Fix model authorization add flow

wyt16cd12d6be91
diff --git a/src/renderer/index.html b/src/renderer/index.html
index 3c83e793..ba328656 100644
--- a/src/renderer/index.html
+++ b/src/renderer/index.html
@@ -1180,6 +1180,15 @@
<div class="agent-row-menu-item is-danger" data-action="delete" data-i18n="agents.delete">Delete</div>
</div>
+ <!-- Add-account modal (settings page) -->
+ <div class="modal-overlay" id="add-account-modal">
+ <div class="modal add-account-modal">
+ <h3 id="add-account-title" data-i18n="add_account.title">Add account</h3>
+ <div class="add-account-body" id="add-account-body"></div>
+ <div class="modal-actions" id="add-account-actions"></div>
+ </div>
+ </div>
+
<!-- Auto-task create / edit modal (see modules/auto.js). Reused by the
Automation tab AND the project-detail page's "自动化" tab. Opens via
`window.openAutoTaskDialog({ task?, projectId?, onSaved? })`. -->
diff --git a/src/renderer/modules/settings.js b/src/renderer/modules/settings.js
index 71f1b488..91284e61 100644
--- a/src/renderer/modules/settings.js
+++ b/src/renderer/modules/settings.js
@@ -17,7 +17,9 @@ let _settingsState = {
modelsCache: {}, // provider → [{id, name}]
pickerProviderSel: null,
pickerModelSel: null,
- addBtnBound: false,
+ pickerProviderEl: null,
+ pickerModelEl: null,
+ addBtnEl: null,
dragState: null,
clientConfigBound: false,
};
@@ -374,7 +376,11 @@ async function _settingsRenderPicker() {
return { value: p.id, label, hint };
});
- if (!_settingsState.pickerProviderSel) {
+ const prevProvider = _settingsState.pickerProviderSel?.getValue()
+ || providerEl.dataset.value
+ || '';
+ if (!_settingsState.pickerProviderSel || _settingsState.pickerProviderEl !== providerEl) {
+ _settingsState.pickerProviderEl = providerEl;
_settingsState.pickerProviderSel = _aiSelectMount(providerEl, {
placeholder: t('settings.picker.select_provider'),
});
@@ -384,13 +390,16 @@ async function _settingsRenderPicker() {
_settingsSetStatus('settings-picker-status', '', '');
});
}
- const prevProvider = _settingsState.pickerProviderSel.getValue();
_settingsState.pickerProviderSel.setOptions(providerOptions, {
value: prevProvider,
placeholder: t('settings.picker.select_provider'),
});
- if (!_settingsState.pickerModelSel) {
+ const prevModel = _settingsState.pickerModelSel?.getValue()
+ || modelEl.dataset.value
+ || '';
+ if (!_settingsState.pickerModelSel || _settingsState.pickerModelEl !== modelEl) {
+ _settingsState.pickerModelEl = modelEl;
_settingsState.pickerModelSel = _aiSelectMount(modelEl, {
placeholder: t('settings.picker.pick_provider_first'),
});
@@ -401,12 +410,12 @@ async function _settingsRenderPicker() {
}
await _settingsPopulatePickerModel(
_settingsState.pickerProviderSel.getValue(),
- _settingsState.pickerModelSel.getValue(),
+ prevModel,
);
const addBtn = document.getElementById('settings-add-entry-btn');
- if (addBtn && !_settingsState.addBtnBound) {
- _settingsState.addBtnBound = true;
+ if (addBtn && _settingsState.addBtnEl !== addBtn) {
+ _settingsState.addBtnEl = addBtn;
addBtn.addEventListener('click', _settingsClickAddEntry);
}
}
diff --git a/test/renderer/settings-open.test.ts b/test/renderer/settings-open.test.ts
index caf906ed..904e4e45 100644
--- a/test/renderer/settings-open.test.ts
+++ b/test/renderer/settings-open.test.ts
@@ -60,6 +60,27 @@ describe('open-source Settings sync guards', () => {
expect(settingsJs).toContain('videoAuth.add');
});
+ it('keeps model authorization add flow usable after open-source stripping', () => {
+ for (const id of [
+ 'settings-picker-provider',
+ 'settings-picker-model',
+ 'settings-add-entry-btn',
+ 'settings-picker-status',
+ 'add-account-modal',
+ 'add-account-title',
+ 'add-account-body',
+ 'add-account-actions',
+ ]) {
+ expect(indexHtml).toContain(`id="${id}"`);
+ }
+
+ expect(settingsJs).not.toContain('addBtnBound');
+ expect(settingsJs).toContain('addBtnEl');
+ expect(settingsJs).toContain('_settingsState.addBtnEl !== addBtn');
+ expect(settingsJs).toContain('_settingsState.pickerProviderEl !== providerEl');
+ expect(settingsJs).toContain('_settingsState.pickerModelEl !== modelEl');
+ });
+
it('isolates settings refresh/render failures while loading BYO provider sections', () => {
expect(settingsJs).toContain('async function _settingsSafeCall');