Skip to content

armgit / Orkas

Public Imported from GitHub
0

Orkas is an open-source (MIT), local-first AI team for your desktop: a Commander turns your goal into to-dos and coordinates 16 built-in specialist agents plus Claude Code, Codex, OpenCode, OpenClaw and Hermes, with projects, scheduled automations and connectors. Free app for macOS & Windows; built-in models or your own keys.

Restore BYO API key settings

wyt1b70888b7573
diff --git a/src/renderer/index.html b/src/renderer/index.html
index 7c8274a6..d73a464d 100644
--- a/src/renderer/index.html
+++ b/src/renderer/index.html
@@ -966,7 +966,7 @@
</div>
</div>
- <div class="settings-group" hidden data-open-unsupported="1">
+ <div class="settings-group">
<div class="settings-group-head">
<div class="settings-group-title" data-i18n="settings.search.title">Search API Key</div>
<div class="settings-group-sub" data-i18n="settings.search.sub">Priority: paid API &gt; model-native search &gt; built-in keyless scraper.</div>
@@ -988,7 +988,7 @@
</div>
</div>
- <div class="settings-group" hidden data-open-unsupported="1">
+ <div class="settings-group">
<div class="settings-group-head">
<div class="settings-group-title" data-i18n="settings.image.title">Image generation API Key</div>
<div class="settings-group-sub" data-i18n="settings.image.sub">API for the generate_image tool. Falls back to chat keys when those target OpenAI or Google.</div>
diff --git a/src/renderer/modules/settings.js b/src/renderer/modules/settings.js
index 8786bcd2..a022fbbf 100644
--- a/src/renderer/modules/settings.js
+++ b/src/renderer/modules/settings.js
@@ -39,11 +39,6 @@ function _settingsTrackModelSelect(surface, provider, model) {
_settingsTrackClick('model_model_select', payload);
}
-function _settingsIsOpenUnsupported(id) {
- const el = document.getElementById(id);
- return !!(el && el.closest('[data-open-unsupported]'));
-}
-
async function _settingsSafeCall(label, fn) {
if (typeof fn !== 'function') return;
try {
@@ -64,12 +59,8 @@ async function loadSettings() {
_settingsSafeCall('settings providers refresh', _settingsRefreshProviders),
_settingsSafeCall('settings entries refresh', _settingsRefreshEntries),
_settingsSafeCall('settings local execution refresh', _settingsRefreshLocalExec),
- _settingsIsOpenUnsupported('settings-search-provider')
- ? Promise.resolve()
- : _settingsSafeCall('settings search refresh', _settingsRefreshSearchProfiles),
- _settingsIsOpenUnsupported('settings-image-provider')
- ? Promise.resolve()
- : _settingsSafeCall('settings image refresh', _settingsRefreshImageProfiles),
+ _settingsSafeCall('settings search refresh', _settingsRefreshSearchProfiles),
+ _settingsSafeCall('settings image refresh', _settingsRefreshImageProfiles),
_settingsSafeCall('settings commander avatar refresh', _settingsRefreshCommanderAvatar),
_settingsSafeCall('settings metacognition refresh', _settingsRefreshMetacognition),
_settingsSafeCall('settings data root refresh', _settingsRefreshDataRoot),
@@ -77,12 +68,8 @@ async function loadSettings() {
await _settingsSafeCall('settings picker render', _settingsRenderPicker);
await _settingsSafeCall('settings entries render', _settingsRenderEntries);
await _settingsSafeCall('settings local execution render', _settingsRenderLocalExec);
- if (!_settingsIsOpenUnsupported('settings-search-provider')) {
- await _settingsSafeCall('settings search render', _settingsRenderSearchSection);
- }
- if (!_settingsIsOpenUnsupported('settings-image-provider')) {
- await _settingsSafeCall('settings image render', _settingsRenderImageSection);
- }
+ await _settingsSafeCall('settings search render', _settingsRenderSearchSection);
+ await _settingsSafeCall('settings image render', _settingsRenderImageSection);
await _settingsSafeCall('settings commander avatar render', _settingsRenderCommanderAvatar);
await _settingsSafeCall('settings metacognition render', _settingsRenderMetacognition);
await _settingsSafeCall('settings data root render', _settingsRenderDataRoot);
@@ -335,8 +322,8 @@ window.addEventListener('i18n-change', () => {
_settingsRenderLocalExec();
_settingsRenderPicker();
_settingsRenderEntries();
- if (!_settingsIsOpenUnsupported('settings-search-provider')) _settingsRenderSearchSection();
- if (!_settingsIsOpenUnsupported('settings-image-provider')) _settingsRenderImageSection();
+ _settingsRenderSearchSection();
+ _settingsRenderImageSection();
if (typeof _settingsRenderVideoSection === 'function') _settingsRenderVideoSection();
_settingsRenderMetacognition();
});
diff --git a/test/renderer/settings-open.test.ts b/test/renderer/settings-open.test.ts
index 954eb91f..71a3c1eb 100644
--- a/test/renderer/settings-open.test.ts
+++ b/test/renderer/settings-open.test.ts
@@ -32,10 +32,6 @@ function liveLines(raw: string) {
.filter((line) => line && !line.startsWith('//') && !line.startsWith('*'));
}
-function count(raw: string, needle: string) {
- return raw.split(needle).length - 1;
-}
-
describe('open-source Settings sync guards', () => {
it('loads the standalone settings tabs module before settings.js', () => {
const tabsScript = '<script src="./modules/settings_tabs.js"></script>';
@@ -50,15 +46,19 @@ describe('open-source Settings sync guards', () => {
expect(indexHtml).toMatch(/class=["'][^"']*\bsettings-tab\b[^"']*\bis-active\b[^"']*["'][^>]*data-settings-tab=["']data["']/);
});
- it('keeps unsupported search and image provider controls hidden from Orkas', () => {
+ it('keeps BYO search and image provider controls visible and wired', () => {
for (const controlId of ['settings-search-provider', 'settings-image-provider']) {
const groupTag = previousSettingsGroupTag(controlId);
- expect(groupTag).toMatch(/\bhidden\b/);
- expect(groupTag).toMatch(/\bdata-open-unsupported=["']1["']/);
+ expect(groupTag).not.toMatch(/\bhidden\b/);
+ expect(groupTag).not.toMatch(/\bdata-open-unsupported=["']1["']/);
}
+ expect(settingsJs).toContain('searchAuth.list');
+ expect(settingsJs).toContain('searchAuth.add');
+ expect(settingsJs).toContain('imageAuth.list');
+ expect(settingsJs).toContain('imageAuth.add');
});
- it('isolates settings refresh/render failures and skips hidden provider sections', () => {
+ it('isolates settings refresh/render failures while loading BYO provider sections', () => {
expect(settingsJs).toContain('async function _settingsSafeCall');
const loadSettingsStart = settingsJs.indexOf('async function loadSettings()');
@@ -68,15 +68,32 @@ describe('open-source Settings sync guards', () => {
for (const marker of [
"_settingsSafeCall('settings providers refresh'",
"_settingsSafeCall('settings entries refresh'",
+ "_settingsSafeCall('settings search refresh'",
+ "_settingsSafeCall('settings image refresh'",
"_settingsSafeCall('settings picker render'",
"_settingsSafeCall('settings entries render'",
+ "_settingsSafeCall('settings search render'",
+ "_settingsSafeCall('settings image render'",
]) {
expect(loadSettingsSnippet).toContain(marker);
}
expect(loadSettingsSnippet).not.toMatch(/await\s+Promise\.all\s*\(\s*\[\s*_settingsRefresh/);
- expect(count(settingsJs, "_settingsIsOpenUnsupported('settings-search-provider')")).toBeGreaterThanOrEqual(2);
- expect(count(settingsJs, "_settingsIsOpenUnsupported('settings-image-provider')")).toBeGreaterThanOrEqual(2);
+ expect(settingsJs).not.toContain('_settingsIsOpenUnsupported');
+ });
+
+ it('does not expose Orkas-managed search or image providers', () => {
+ for (const marker of [
+ ['Orkas', 'Search'].join('-'),
+ ['orkas', 'search'].join('-'),
+ ['orkas', 'search'].join('_'),
+ ['Orkas', 'Image'].join('-'),
+ ['orkas', 'image'].join('-'),
+ ['orkas', 'image'].join('_'),
+ ]) {
+ expect(settingsJs).not.toContain(marker);
+ expect(indexHtml).not.toContain(marker);
+ }
});
it('does not leave bare PC-only settings renderer calls after stripping', () => {