Orkas is an open-source (MIT), local-first AI team for your desktop: a Commander turns your goal into to-dos and coordinates 16 built-in specialist agents plus Claude Code, Codex, OpenCode, OpenClaw and Hermes, with projects, scheduled automations and connectors. Free app for macOS & Windows; built-in models or your own keys.
JavaScript agent-collaborationagent-harnessagent-orchestrationagent-teamagent-workflowai-assistantai-automationai-employeeai-productivityai-teamai-workflowautonomous-agentsclaude-code-guiclaude-coworkdesktop-agentlocal-firstmulti-agentmulti-agent-systemself-evolving-agentstask-automation
fix(preview): keep private file details out of failure logs
BlueSkyID6661b8064355e4f
diff --git a/src/renderer/modules/chat-file-viewer.js b/src/renderer/modules/chat-file-viewer.jsindex 55aaa374..8c875032 100644--- a/src/renderer/modules/chat-file-viewer.js+++ b/src/renderer/modules/chat-file-viewer.js@@ -593,7 +593,7 @@ function _teardownViewerContent(reason = 'replaced') {_viewerFinishHtmlPreview(reason);if (_viewerEditController) {try { _viewerEditController.destroy(); }- catch (err) { _viewerLog.warn('edit controller destroy threw', err); }+ catch { _viewerLog.warn('edit controller destroy failed', { error_code: 'destroy_failed' }); }}_viewerEditController = null;_viewerDirty = false;@@ -725,9 +725,9 @@ async function _refreshSaveAppButton(path) {if (!_isViewerOpen() || _viewerCurrentPath !== path) return;const canSave = !!(inspected && inspected.ok !== false && inspected.canSave);_setSaveAppVisible(canSave);- } catch (err) {+ } catch {if (!_isViewerOpen() || _viewerCurrentPath !== path) return;- _viewerLog.warn('inspect app bundle failed', { path, error: String(err && err.message || err) });+ _viewerLog.warn('inspect app bundle failed', { error_code: 'inspect_failed' });_setSaveAppVisible(false);}}@@ -1314,9 +1314,9 @@ async function _readTextFile(absPath, cid, projectId, seq, preview) {});}return null;- } catch (e) {+ } catch {if (seq && seq !== _viewerRenderSeq) return null;- _viewerLog.warn('readText threw', { path: absPath, error: String(e && e.message || e) });+ _viewerLog.warn('readText failed', { error_code: 'read_failed' });await closeChatFileViewer({ force: true });await _showUnsupportedDialog(absPath, cid, projectId, {messageKey: 'chat.preview_read_failed_message',@@ -1360,9 +1360,9 @@ async function _showUnsupportedDialog(absPath, cid, projectId, opts) {if (cid) payload.cid = cid;if (projectId) payload.projectId = projectId;const res = await window.orkas.invoke('workspace.revealPath', payload);- if (!res || !res.ok) _viewerLog.warn('fallback reveal failed', { path: absPath, error: res && res.error });- } catch (err) {- _viewerLog.warn('fallback reveal threw', { path: absPath, error: String(err && err.message || err) });+ if (!res || !res.ok) _viewerLog.warn('fallback reveal failed', { error_code: 'reveal_failed' });+ } catch {+ _viewerLog.warn('fallback reveal failed', { error_code: 'reveal_failed' });}}@@ -1392,8 +1392,8 @@ async function _ensureViewerFileExists(absPath, cid, projectId) {if (typeof uiToast === 'function') uiToast(message, { variant: 'warning' });else if (typeof uiAlert === 'function') await uiAlert(message);return false;- } catch (err) {- _viewerLog.warn('statPath threw', { path: absPath, error: String(err && err.message || err) });+ } catch {+ _viewerLog.warn('statPath failed', { error_code: 'stat_failed' });return true;}}diff --git a/test/renderer/chat-file-viewer.test.ts b/test/renderer/chat-file-viewer.test.tsindex b01f057f..69b15d4a 100644--- a/test/renderer/chat-file-viewer.test.ts+++ b/test/renderer/chat-file-viewer.test.ts@@ -92,6 +92,84 @@ describe('chat-file-viewer › _kindOf', () => {});describe('file preview availability feedback', () => {+ it.each(['stat', 'reveal', 'reveal-response'])('keeps private file details out of %s failure diagnostics', async (failure) => {+ const privatePath = '/private/account/todo/brief.png';+ const privateError = `EACCES: ${privatePath}`;+ const warnings: unknown[] = [];+ const invoke = vi.fn(async (channel: string) => {+ if (channel === 'workspace.statPath') {+ if (failure === 'stat') throw new Error(privateError);+ return { ok: false, error: 'unavailable' };+ }+ if (failure === 'reveal-response') return { ok: false, error: privateError };+ throw new Error(privateError);+ });+ const openChatImageLightbox = vi.fn();+ const context = vm.createContext({+ window: { orkas: { invoke } },+ createLogger: () => ({ warn: (...args: unknown[]) => warnings.push(args), info: () => {}, error: () => {} }),+ uiConfirm: vi.fn(async () => true),+ openChatImageLightbox,+ console,+ });+ vm.runInContext(readFileSync(require.resolve('../../src/renderer/modules/chat-file-viewer.js'), 'utf8'), context);+ await context.openChatFileViewer(privatePath, 'brief.png');+ expect(warnings).toHaveLength(1);+ expect(JSON.stringify(warnings)).not.toContain(privatePath);+ expect(JSON.stringify(warnings)).not.toContain('EACCES');+ expect(warnings).toEqual([[expect.any(String), { error_code: failure === 'stat' ? 'stat_failed' : 'reveal_failed' }]]);+ expect(openChatImageLightbox).toHaveBeenCalledTimes(failure === 'stat' ? 1 : 0);+ expect(context.uiConfirm).toHaveBeenCalledTimes(failure === 'stat' ? 0 : 1);+ expect(invoke.mock.calls.map(([channel]) => channel)).toEqual(failure === 'stat'+ ? ['workspace.statPath'] : ['workspace.statPath', 'workspace.revealPath']);+ });++ it.each(['read', 'inspect', 'destroy'])('keeps %s failure diagnostics private while preserving recovery', async (failure) => {+ const privatePath = '/private/account/todo/brief.txt';+ const warnings: unknown[] = [];+ const fail = () => { throw new Error(`EACCES: ${privatePath}`); };+ const invoke = vi.fn(async () => fail());+ const button = { hidden: false, disabled: false };+ const classes = new Set(['is-open']);+ const root = {+ classList: {+ contains: (name: string) => classes.has(name),+ remove: (...names: string[]) => names.forEach((name) => classes.delete(name)),+ },+ setAttribute: vi.fn(),+ };+ const setDirty = vi.fn();+ const context = vm.createContext({+ window: { orkas: { invoke }, OrkasPreviewHost: { setDirty } },+ createLogger: () => ({ warn: (...args: unknown[]) => warnings.push(args), info: () => {}, error: () => {} }),+ uiConfirm: vi.fn(async () => false),+ root, button, privatePath, fail, console,+ });+ vm.runInContext(readFileSync(require.resolve('../../src/renderer/modules/chat-file-viewer.js'), 'utf8'), context);+ vm.runInContext('_viewerEl = root; _viewerCurrentPath = privatePath; _viewerSaveAppBtn = button;', context);+ if (failure === 'read') {+ expect(await context._readTextFile(privatePath, 'task', 'project')).toBeNull();+ expect(classes.has('is-open')).toBe(false);+ expect(context.uiConfirm).toHaveBeenCalledExactlyOnceWith(expect.objectContaining({+ message: 'Could not read this file. Open the containing folder?',+ }));+ expect(invoke).toHaveBeenCalledExactlyOnceWith('produced.readText', { path: privatePath, cid: 'task', projectId: 'project' });+ } else if (failure === 'inspect') {+ await context._refreshSaveAppButton(privatePath);+ expect(button).toEqual({ hidden: true, disabled: true });+ expect(classes.has('is-open')).toBe(true);+ expect(invoke).toHaveBeenCalledExactlyOnceWith('savedApps.inspectBundleFromPath', { path: privatePath });+ } else {+ vm.runInContext('_viewerEditController = { destroy: fail }; _viewerDirty = true;', context);+ expect(await context.closeChatFileViewer({ force: true })).toBe(true);+ expect(classes.has('is-open')).toBe(false);+ expect(setDirty).toHaveBeenCalledExactlyOnceWith(false);+ await context.closeChatFileViewer({ force: true });+ expect(invoke).not.toHaveBeenCalled();+ }+ expect(warnings).toEqual([[expect.any(String), { error_code: `${failure}_failed` }]]);+ });+it.each([[{ ok: true, exists: false }, 'missing'],[{ ok: false, error: 'path is outside the user workspace' }, 'unreadable'],