Skip to content

armgit / Orkas

Public Imported from GitHub
0

Orkas is an open-source (MIT), local-first AI team for your desktop: a Commander turns your goal into to-dos and coordinates 16 built-in specialist agents plus Claude Code, Codex, OpenCode, OpenClaw and Hermes, with projects, scheduled automations and connectors. Free app for macOS & Windows; built-in models or your own keys.

Fix passive macOS notification permission queries

CloudTianTian3a503c47bf87
diff --git a/src/main/features/notification_permissions.ts b/src/main/features/notification_permissions.ts
index 8d04d4de..37b40099 100644
--- a/src/main/features/notification_permissions.ts
+++ b/src/main/features/notification_permissions.ts
@@ -184,13 +184,16 @@ async function queryWindowsPermission(appId: string): Promise<SystemNotification
export async function getSystemNotificationPermission(): Promise<SystemNotificationPermission> {
let result: SystemNotificationPermission;
- if (!Notification.isSupported()) {
- result = { state: 'unsupported', can_open_settings: false };
- } else if (process.platform === 'darwin') {
+ if (process.platform === 'darwin') {
+ // Electron 42 initializes its macOS presenter in isSupported(), whose
+ // constructor requests authorization. Status reads must use only the
+ // existing native query so opening Settings cannot trigger that prompt.
result = {
state: await queryMacPermission(),
can_open_settings: true,
};
+ } else if (!Notification.isSupported()) {
+ result = { state: 'unsupported', can_open_settings: false };
} else if (process.platform === 'win32') {
result = {
state: await queryWindowsPermission(notificationAppId()),
diff --git a/test/main/features/notification_permissions.test.ts b/test/main/features/notification_permissions.test.ts
index db10cb1d..bf64b952 100644
--- a/test/main/features/notification_permissions.test.ts
+++ b/test/main/features/notification_permissions.test.ts
@@ -1,8 +1,9 @@
import { afterEach, describe, expect, it, vi } from 'vitest';
+import { Notification } from 'electron';
vi.mock('electron', () => ({
app: { isPackaged: true },
- Notification: { isSupported: () => true },
+ Notification: { isSupported: vi.fn(() => true) },
shell: { openExternal: vi.fn() },
}));
@@ -11,6 +12,7 @@ vi.mock('../../../src/main/logger', () => ({
}));
import {
+ getSystemNotificationPermission,
markSystemNotificationDelivered,
markSystemNotificationFailed,
permissionFromMacNativeState,
@@ -24,6 +26,20 @@ describe('system notification permission helpers', () => {
afterEach(() => {
// Reset process-local delivery evidence between cases.
markSystemNotificationFailed();
+ vi.restoreAllMocks();
+ });
+
+ it.runIf(process.platform === 'darwin')('reads macOS permission without initializing Electron authorization', async () => {
+ // Electron 42's support probe creates the macOS presenter, which requests
+ // authorization. Merely opening Settings must never consume that choice.
+ const supportProbe = vi.spyOn(Notification, 'isSupported').mockImplementation(() => {
+ throw new Error('Unexpected authorization-capable support probe');
+ });
+ const permission = await getSystemNotificationPermission();
+ expect(permission.can_open_settings).toBe(true);
+ expect(['granted', 'denied', 'presentation_disabled', 'not_determined', 'unknown'])
+ .toContain(permission.state);
+ expect(supportProbe).not.toHaveBeenCalled();
});
it('normalizes the macOS native authorization state', () => {