Skip to content

armgit / Orkas

Public Imported from GitHub
0

Orkas is an open-source (MIT), local-first AI team for your desktop: a Commander turns your goal into to-dos and coordinates 16 built-in specialist agents plus Claude Code, Codex, OpenCode, OpenClaw and Hermes, with projects, scheduled automations and connectors. Free app for macOS & Windows; built-in models or your own keys.

fix(video): preserve budget after full cache recovery

CloudTianTian625b1f3c028b
diff --git a/src/main/features/video_studio.ts b/src/main/features/video_studio.ts
index dd157ed2..bb5ba413 100644
--- a/src/main/features/video_studio.ts
+++ b/src/main/features/video_studio.ts
@@ -4896,14 +4896,28 @@ async function buildMediaQa(
};
}
-/** Did a resumable segment-assembly failure cache at least one NEW segment?
- * Forward progress means an unchanged-input retry genuinely advances, so the
- * draft repair budget must not count it as a repeated failure; zero-progress
- * repetition still spends the budget and stays bounded. */
+/** Did a resumable segment-assembly failure preserve useful render progress?
+ * A newly rendered segment advances the retry. A complete cache hit also
+ * proves that content rendering already succeeded and the failure happened in
+ * a later assembly/environment stage. Both are budget-neutral; incomplete or
+ * contradictory counters stay bounded by the ordinary repair budget. */
export function resumableRenderFailureMadeProgress(render: VideoStudioResult): boolean {
if (render.ok !== false || render.errorCode !== 'E_SEGMENT_ASSEMBLY_INCOMPLETE') return false;
- const rendered = (render.scene_segments as { rendered?: unknown } | undefined)?.rendered;
- return typeof rendered === 'number' && rendered > 0;
+ const segments = render.scene_segments as {
+ total?: unknown;
+ rendered?: unknown;
+ reused?: unknown;
+ failed?: unknown;
+ pending?: unknown;
+ } | undefined;
+ if (typeof segments?.rendered === 'number' && segments.rendered > 0) return true;
+ return typeof segments?.total === 'number'
+ && Number.isInteger(segments.total)
+ && segments.total > 0
+ && typeof segments.reused === 'number'
+ && segments.reused === segments.total
+ && segments.failed === 0
+ && segments.pending === 0;
}
async function failDraft(
diff --git a/test/main/features/video_studio_native_qa.test.ts b/test/main/features/video_studio_native_qa.test.ts
index 8e15f9ad..f4567773 100644
--- a/test/main/features/video_studio_native_qa.test.ts
+++ b/test/main/features/video_studio_native_qa.test.ts
@@ -6066,7 +6066,7 @@ describe('P3c R2 scene segment assembly', () => {
expect(new Set([key, ...variants]).size).toBe(variants.length + 1);
});
- it('spends the draft repair budget only on zero-progress resumable failures', () => {
+ it('spends the draft repair budget only when resumable evidence shows no content progress', () => {
// A resume that cached at least one NEW segment genuinely advanced, so it
// must not burn a content-repair pass; a zero-progress repeat must, or
// unchanged-input repetition would be unbounded.
@@ -6079,6 +6079,30 @@ describe('P3c R2 scene segment assembly', () => {
} as Parameters<typeof resumableRenderFailureMadeProgress>[0]);
expect(resumableRenderFailureMadeProgress(incomplete(2))).toBe(true);
expect(resumableRenderFailureMadeProgress(incomplete(0))).toBe(false);
+ // A complete cache hit means all content segments already rendered. A
+ // later concat/remux/probe failure is environmental and budget-neutral.
+ expect(resumableRenderFailureMadeProgress({
+ ok: false,
+ op: 'composition.render',
+ errorCode: 'E_SEGMENT_ASSEMBLY_INCOMPLETE',
+ message: 'concat failed',
+ scene_segments: { total: 3, rendered: 0, reused: 3, failed: 0, pending: 0, resumable: true },
+ } as Parameters<typeof resumableRenderFailureMadeProgress>[0])).toBe(true);
+ // Near-misses remain bounded: partial reuse, contradictory counters, and
+ // missing post-render counters cannot claim a completed content render.
+ for (const scene_segments of [
+ { total: 3, rendered: 0, reused: 2, failed: 0, pending: 1, resumable: true },
+ { total: 3, rendered: 0, reused: 3, failed: 1, pending: 0, resumable: true },
+ { total: 3, rendered: 0, reused: 3, resumable: true },
+ ]) {
+ expect(resumableRenderFailureMadeProgress({
+ ok: false,
+ op: 'composition.render',
+ errorCode: 'E_SEGMENT_ASSEMBLY_INCOMPLETE',
+ message: 'incomplete',
+ scene_segments,
+ } as Parameters<typeof resumableRenderFailureMadeProgress>[0])).toBe(false);
+ }
// Other render failures never skip the budget, whatever counters they carry.
expect(resumableRenderFailureMadeProgress({
ok: false,