Skip to content

armgit / Orkas

Public Imported from GitHub
0

Orkas is an open-source (MIT), local-first AI team for your desktop: a Commander turns your goal into to-dos and coordinates 16 built-in specialist agents plus Claude Code, Codex, OpenCode, OpenClaw and Hermes, with projects, scheduled automations and connectors. Free app for macOS & Windows; built-in models or your own keys.

Redact VideoStudio encode stderr paths

wyt91bf745ed0b2
diff --git a/src/main/features/video_studio.ts b/src/main/features/video_studio.ts
index e5294598..c55a8774 100644
--- a/src/main/features/video_studio.ts
+++ b/src/main/features/video_studio.ts
@@ -6,6 +6,7 @@ import { spawn } from 'node:child_process';
import type { BrowserWindow as ElectronBrowserWindow } from 'electron';
import { bundledFfmpegPaths } from '../util/bundled-runtime';
+import { redactPaths } from '../util/redact';
import { createLogger } from '../logger';
const log = createLogger('video-studio');
@@ -854,8 +855,9 @@ async function encodeFrames(opts: {
if (r.aborted) return { ok: false, op: 'composition.render', errorCode: 'E_RENDER_ABORTED', message: 'render aborted.' };
if (r.timedOut) return { ok: false, op: 'composition.render', errorCode: 'E_RENDER_TIMEOUT', message: 'ffmpeg encode timed out.' };
if (r.code !== 0) {
- log.warn('ffmpeg encode failed', { code: r.code, stderr: r.stderr.slice(-500) });
- return { ok: false, op: 'composition.render', errorCode: 'E_RENDER_ENCODE_FAILED', message: `ffmpeg exited ${r.code}. ${r.stderr.slice(-1200)}` };
+ const stderrTail = redactPaths(r.stderr.slice(-1200));
+ log.warn('ffmpeg encode failed', { code: r.code, stderr_chars: r.stderr.length, stderr_tail: stderrTail.slice(-500) });
+ return { ok: false, op: 'composition.render', errorCode: 'E_RENDER_ENCODE_FAILED', message: `ffmpeg exited ${r.code}. ${stderrTail}` };
}
return { ok: true, op: 'composition.render' };
}
diff --git a/test/main/util/log-redact.test.ts b/test/main/util/log-redact.test.ts
index 9c59cfe8..fb8d64b5 100644
--- a/test/main/util/log-redact.test.ts
+++ b/test/main/util/log-redact.test.ts
@@ -1,4 +1,5 @@
import { describe, expect, it } from 'vitest';
+import { redactPaths } from '../../../src/main/util/redact';
import { logErrorSummary, maskId, safeUrlAction } from '../../../src/main/util/log-redact';
describe('log-redact', () => {
@@ -29,4 +30,15 @@ describe('log-redact', () => {
expect(JSON.stringify(summary)).not.toContain('private prompt fragment');
expect(JSON.stringify(summary)).not.toContain('sk-secret1234567890');
});
+
+ it('redacts local paths in subprocess stderr tails', () => {
+ const out = redactPaths(
+ "ffmpeg failed for /Users/user/Private Clips/demo.mov and C:\\Users\\user\\Videos\\secret.mp4",
+ );
+
+ expect(out).toContain('<path>');
+ expect(out).not.toContain('/Users/user');
+ expect(out).not.toContain('user\\Videos');
+ expect(out).not.toContain('secret.mp4');
+ });
});