Orkas is an open-source (MIT), local-first AI team for your desktop: a Commander turns your goal into to-dos and coordinates 16 built-in specialist agents plus Claude Code, Codex, OpenCode, OpenClaw and Hermes, with projects, scheduled automations and connectors. Free app for macOS & Windows; built-in models or your own keys.
JavaScript agent-collaborationagent-harnessagent-orchestrationagent-teamagent-workflowai-assistantai-automationai-employeeai-productivityai-teamai-workflowautonomous-agentsclaude-code-guiclaude-coworkdesktop-agentlocal-firstmulti-agentmulti-agent-systemself-evolving-agentstask-automation
fix(browser): preserve tabs through page state updates
CloudTianTianb2c0a0b838b0
diff --git a/src/renderer/modules/web-assist.js b/src/renderer/modules/web-assist.jsindex 4e2d897d..7923346e 100644--- a/src/renderer/modules/web-assist.js+++ b/src/renderer/modules/web-assist.js@@ -98,33 +98,46 @@function renderTabs() {if (!tabsEl) return;- tabsEl.replaceChildren();+ // Keep live nodes during status updates: clearing the strip can reset its+ // scroll position and detach the focused or currently pressed tab.+ const items = new Map(Array.from(tabsEl.children, (item) => [item.dataset.tabId, item]));+ const tabs = tabsForConversation();+ const liveIds = new Set(tabs.map((tab) => tab.tab_id));+ for (const [id, item] of items) if (!liveIds.has(id)) item.remove();const selected = selectedTab();- for (const tab of tabsForConversation()) {- const item = document.createElement('div');- item.className = 'web-assist-tab';+ let next = tabsEl.firstElementChild;+ for (const tab of tabs) {+ let item = items.get(tab.tab_id);+ if (!item) {+ item = document.createElement('div');+ item.className = 'web-assist-tab';+ item.dataset.tabId = tab.tab_id;+ item.setAttribute('role', 'tab');++ const title = document.createElement('span');+ title.className = 'web-assist-tab-title';+ item.appendChild(title);++ const close = document.createElement('button');+ close.type = 'button';+ close.className = 'web-assist-tab-close';+ close.dataset.closeTab = tab.tab_id;+ close.innerHTML = icon('x', 'web-assist-tab-close-icon');+ item.appendChild(close);+ }item.classList.toggle('is-active', tab.tab_id === selected?.tab_id);item.classList.toggle('is-loading', tab.loading === true);item.classList.toggle('is-suspended', tab.suspended === true);- item.dataset.tabId = tab.tab_id;- item.setAttribute('role', 'tab');item.setAttribute('aria-selected', tab.tab_id === selected?.tab_id ? 'true' : 'false');item.tabIndex = tab.tab_id === selected?.tab_id ? 0 : -1;- const title = document.createElement('span');- title.className = 'web-assist-tab-title';- title.textContent = tabTitle(tab);+ const title = item.querySelector('.web-assist-tab-title');+ const text = tabTitle(tab);+ if (title.textContent !== text) title.textContent = text;title.title = tab.suspended ? `${title.textContent} — ${label('web_assist.suspended', 'Inactive — reloads when opened')}` : title.textContent;- item.appendChild(title);-- const close = document.createElement('button');- close.type = 'button';- close.className = 'web-assist-tab-close';- close.dataset.closeTab = tab.tab_id;- close.innerHTML = icon('x', 'web-assist-tab-close-icon');- setButtonCopy(close, 'web_assist.close_tab', 'Close tab');- item.appendChild(close);- tabsEl.appendChild(item);+ setButtonCopy(item.querySelector('.web-assist-tab-close'), 'web_assist.close_tab', 'Close tab');+ if (item !== next) tabsEl.insertBefore(item, next);+ next = item.nextElementSibling;}}diff --git a/test/e2e/web_assist_e2e_address.spec.ts b/test/e2e/web_assist_e2e_address.spec.tsindex 7a33a1f8..91e1a5ce 100644--- a/test/e2e/web_assist_e2e_address.spec.ts+++ b/test/e2e/web_assist_e2e_address.spec.ts@@ -1,5 +1,114 @@import { createServer } from 'node:http';-import { expect, test } from './fixtures/orkas';+import { expect, OrkasTestApp, test as base } from './fixtures/orkas';++// These journeys verify browser chrome and navigation, not GPU overlays.+// Hidden native pages can otherwise emit Chromium mailbox errors.+const test = base.extend({+ orkas: async ({}, use, testInfo) => {+ const app = new OrkasTestApp(testInfo, { softwareRendering: true });+ try { await app.launch(); await use(app); } finally { await app.dispose(); }+ },+});++test('scrolled browser tabs stay in place through page updates, activation and tab changes', async ({ orkas }) => {+ const server = createServer((_req, res) => {+ res.setHeader('Content-Type', 'text/html');+ res.end('<title>Scroll fixture ready</title><h1>Ready</h1>');+ });+ await new Promise<void>(resolve => server.listen(0, '127.0.0.1', resolve));+ const page = orkas.page!;+ try {+ const cid = (await orkas.invoke<any>('conversations.create', { title: 'Browser tab scrolling' })).conversation.conversation_id;+ await page.evaluate(async id => {+ await (window as any).loadConversations();+ (window as any).setView('conversation', id);+ (window as any).ConversationInfo.openAndSetTab('browser');+ }, cid);+ const tabs = page.locator('.web-assist-tab');+ await expect(tabs).toHaveCount(1);+ for (let index = 0; index < 9; index++) {+ expect(await orkas.invoke<any>('webAssist.addTab', { conversationId: cid })).toMatchObject({ ok: true });+ }+ await expect(tabs).toHaveCount(10);+ const state = (await orkas.invoke<any>('webAssist.state')).state;+ const tabId = state.active_tab_id;+ const url = `http://127.0.0.1:${(server.address() as { port: number }).port}/ready`;+ expect(await orkas.invoke<any>('webAssist.navigateTo', { tabId, url })).toMatchObject({ ok: true });+ const active = page.locator(`.web-assist-tab[data-tab-id="${tabId}"]`);+ await expect(active).toHaveText('Scroll fixture ready');+ const nativeId = await orkas.electronApp!.evaluate(({ webContents }, url) => (+ webContents.getAllWebContents().find(contents => contents.getURL() === url)!.id+ ), url);+ const strip = page.locator('.web-assist-tabs');+ const scroll = () => strip.evaluate(node => node.scrollLeft);+ const left = await strip.evaluate(node => {+ node.scrollLeft = 240;+ return node.scrollLeft;+ });+ expect(left).toBe(240); // Real overflow, away from either scroll boundary.+ await orkas.electronApp!.evaluate(async ({ webContents }, id) => {+ await webContents.fromId(id)!.executeJavaScript('document.title = "Scroll fixture updated"; void 0');+ }, nativeId);+ await expect(active).toHaveText('Scroll fixture updated');+ expect(await scroll()).toBe(left);+ // Observe several frames so a delayed layout/status update cannot undo it.+ expect(await strip.evaluate(async node => {+ const samples: number[] = [];+ for (let frame = 0; frame < 10; frame++) {+ await new Promise<void>(resolve => requestAnimationFrame(() => resolve()));+ samples.push(node.scrollLeft);+ }+ return samples;+ })).toEqual(Array(10).fill(left));++ // A state update during a pointer gesture must retain the clicked target.+ const targetId = await tabs.nth(3).getAttribute('data-tab-id');+ const target = page.locator(`.web-assist-tab[data-tab-id="${targetId}"]`);+ const box = (await target.boundingBox())!;+ await page.mouse.move(box.x + 15, box.y + box.height / 2);+ await page.mouse.down();+ await orkas.electronApp!.evaluate(async ({ webContents }, id) => {+ await webContents.fromId(id)!.executeJavaScript('document.title = "Scroll fixture clicked"; void 0');+ }, nativeId);+ await expect(active).toHaveText('Scroll fixture clicked');+ await page.mouse.up();+ await expect(target).toHaveAttribute('aria-selected', 'true');+ await expect.poll(async () => (await orkas.invoke<any>('webAssist.state')).state.active_tab_id).toBe(targetId);+ expect(await scroll()).toBe(left);++ expect(await orkas.invoke<any>('webAssist.addTab', { conversationId: cid })).toMatchObject({ ok: true });+ await expect(tabs).toHaveCount(11);+ expect(await scroll()).toBe(left);+ const lastId = await tabs.last().getAttribute('data-tab-id');+ expect(await orkas.invoke<any>('webAssist.closeTab', { tabId: lastId })).toMatchObject({ ok: true });+ await expect(tabs).toHaveCount(10);+ expect(await scroll()).toBe(left);++ // Keyboard focus survives unrelated page updates and still closes its tab.+ const close = target.locator('.web-assist-tab-close');+ await close.focus();+ const focusedLeft = await scroll();+ const firstId = await tabs.first().getAttribute('data-tab-id');+ expect(await orkas.invoke<any>('webAssist.closeTab', { tabId: firstId })).toMatchObject({ ok: true });+ await expect(tabs).toHaveCount(9);+ await expect(close).toBeFocused();+ expect(await scroll()).toBe(focusedLeft);+ await orkas.electronApp!.evaluate(async ({ webContents }, id) => {+ await webContents.fromId(id)!.executeJavaScript('document.title = "Scroll fixture focused"; void 0');+ }, nativeId);+ await expect(active).toHaveText('Scroll fixture focused');+ await expect(close).toBeFocused();+ expect(await scroll()).toBe(focusedLeft);+ await close.press('Enter');+ await expect(page.locator(`.web-assist-tab[data-tab-id="${targetId}"]`)).toHaveCount(0);+ await expect(tabs).toHaveCount(8);+ expect(await scroll()).toBe(focusedLeft);+ } finally {+ await orkas.invoke('webAssist.close', {});+ server.closeAllConnections();+ await new Promise<void>(resolve => server.close(() => resolve()));+ }+});for (const kind of ['URL', 'search'] as const) {test(`browser address stays visible while a ${kind} waits for its first response`, async ({ orkas }) => {