Skip to content

armgit / Orkas

Public Imported from GitHub
0

Orkas is an open-source (MIT), local-first AI team for your desktop: a Commander turns your goal into to-dos and coordinates 16 built-in specialist agents plus Claude Code, Codex, OpenCode, OpenClaw and Hermes, with projects, scheduled automations and connectors. Free app for macOS & Windows; built-in models or your own keys.

fix(settings): hide unresolved notification warning

YToolboxccab985a1c04
diff --git a/src/renderer/style.css b/src/renderer/style.css
index 624683f1..44d4ad09 100644
--- a/src/renderer/style.css
+++ b/src/renderer/style.css
@@ -11993,6 +11993,7 @@ body.model-not-configured .main-content { flex-direction: column; }
gap: 12px;
margin-bottom: 10px;
}
+.settings-row[hidden] { display: none !important; }
.settings-row:last-child { margin-bottom: 0; }
.settings-row > label {
flex: 0 0 80px;
diff --git a/test/renderer/settings-task-notifications.test.ts b/test/renderer/settings-task-notifications.test.ts
index 7840ff6e..d7cc364e 100644
--- a/test/renderer/settings-task-notifications.test.ts
+++ b/test/renderer/settings-task-notifications.test.ts
@@ -8,6 +8,7 @@ const settingsSource = readFileSync(
'utf8',
);
const htmlSource = readFileSync(resolve(__dirname, '../../src/renderer/index.html'), 'utf8');
+const styleSource = readFileSync(resolve(__dirname, '../../src/renderer/style.css'), 'utf8');
function loadHarness(
setResult: { ok: boolean; enabled?: boolean; error?: string; code?: string },
@@ -99,6 +100,12 @@ describe('Settings → General task notification toggle', () => {
expect(htmlSource).toMatch(/id="settings-task-notifications-toggle" checked/);
});
+ it('keeps a non-actionable permission row actually hidden', () => {
+ expect(styleSource).toMatch(
+ /\.settings-row\[hidden\]\s*{[^}]*display:\s*none\s*!important\s*;/s,
+ );
+ });
+
it('loads the persisted value and saves a user change', async () => {
const { sandbox, checkbox, listeners, invoke, click, event, logger } = loadHarness({ ok: true });
await sandbox._settingsRefreshTaskNotifications();
@@ -210,6 +217,18 @@ describe('Settings → General task notification toggle', () => {
expect(warning.hidden).toBe(true);
});
+ it('does not present a permission that has never been requested as disabled', async () => {
+ const { sandbox, warning } = loadHarness(
+ { ok: true },
+ { state: 'not_determined', can_open_settings: true },
+ true,
+ );
+ await sandbox._settingsRefreshTaskNotifications();
+ sandbox._settingsRenderTaskNotifications();
+
+ expect(warning.hidden).toBe(true);
+ });
+
it('does not claim system settings disabled Orkas when no per-app settings destination is available', async () => {
const { sandbox, warning, openButton } = loadHarness(
{ ok: true },