Orkas is an open-source (MIT), local-first AI team for your desktop: a Commander turns your goal into to-dos and coordinates 16 built-in specialist agents plus Claude Code, Codex, OpenCode, OpenClaw and Hermes, with projects, scheduled automations and connectors. Free app for macOS & Windows; built-in models or your own keys.
JavaScript agent-collaborationagent-harnessagent-orchestrationagent-teamagent-workflowai-assistantai-automationai-employeeai-productivityai-teamai-workflowautonomous-agentsclaude-code-guiclaude-coworkdesktop-agentlocal-firstmulti-agentmulti-agent-systemself-evolving-agentstask-automation
fix(projects): update open title after sidebar rename
CloudTianTiandaa8aaa4e0dd
diff --git a/src/renderer/modules/projects.js b/src/renderer/modules/projects.jsindex 5e7f1e6a..4223ecea 100644--- a/src/renderer/modules/projects.js+++ b/src/renderer/modules/projects.js@@ -653,6 +653,7 @@ function _bindInlineRenameInput(input) {_projectsInlineRenameDraft = '';_projectsInlineRenameError = '';_projectsInlineRenameSubmitting = false;+ _applyProjectRename(pid, res.project.name);await loadProjects(true);} catch (err) {if (@@ -978,6 +979,20 @@ window.openProjectsSurface = async function openProjectsSurface(request) {return false;};+function _applyProjectRename(projectId, name) {+ const cached = Array.isArray(_projectsCache)+ ? _projectsCache.find((project) => project?.project_id === projectId) : null;+ if (cached) cached.name = name;+ // Update only the title; reloading the detail would replace active editors.+ if (typeof _projectDetailPid !== 'undefined' && _projectDetailPid === projectId+ && typeof _projectDetailMeta !== 'undefined' && _projectDetailMeta?.project) {+ _projectDetailMeta.project.name = name;+ const title = document.getElementById('project-detail-title');+ if (title) title.textContent = name;+ }+ renderProjectsSection();+}+// ── Init ────────────────────────────────────────────────────────────────document.addEventListener('DOMContentLoaded', () => {diff --git a/test/e2e/projects_e2e_smoke.spec.ts b/test/e2e/projects_e2e_smoke.spec.tsindex 893a92f9..1d5f43ca 100644--- a/test/e2e/projects_e2e_smoke.spec.ts+++ b/test/e2e/projects_e2e_smoke.spec.ts@@ -764,36 +764,52 @@ test.describe('projects', () => {expect(afterCancel.projects.some((project) => project.name === draftName)).toBe(false);});- test('renames a project and keeps the new name after relaunch', async ({ orkas }) => {- const originalName = 'E2E Project Before Rename';- const renamedName = 'E2E Project After Rename';- await createProject(orkas, originalName);- if (!orkas.page) throw new Error('Orkas renderer is unavailable');-- const originalRow = orkas.page.locator('.project-row', {- has: orkas.page.locator('.project-name', { hasText: originalName }),+ for (const [locale, width, height] of [['zh', 1280, 900], ['en', 960, 720]] as const) {+ test(`renames a project and keeps the new name after relaunch (${locale})`, async ({ orkas }, testInfo) => {+ const originalName = 'E2E Project Before Rename';+ const renamedName = 'E2E Project After Rename';+ await createProject(orkas, originalName);+ if (!orkas.page) throw new Error('Orkas renderer is unavailable');++ await orkas.page.setViewportSize({ width, height });+ await orkas.page.evaluate(lang => (window as any).setLang(lang), locale);+ const composer = orkas.page.locator('#project-chat-input');+ await composer.fill('Keep this unsent project draft');+ await orkas.page.evaluate(() => (window as any).composerSetSelection('project-chat-input', 3, 7));+ const composerNode = await composer.elementHandle();++ const originalRow = orkas.page.locator('.project-row', {+ has: orkas.page.locator('.project-name', { hasText: originalName }),+ });+ await originalRow.hover();+ const renameMenuButton = originalRow.locator('[data-project-menu]');+ await expect(renameMenuButton).toBeVisible();+ await renameMenuButton.click();+ await orkas.page.locator('#project-row-menu [data-action="rename"]').click();+ const renameInput = orkas.page.locator('input.project-rename-input[data-rename-pid]');+ await expect(renameInput).toBeFocused();+ await renameInput.fill(renamedName);+ await renameInput.press('Enter');++ await expect(orkas.page.locator('.project-name', { hasText: originalName })).toHaveCount(0);+ await expect(orkas.page.locator('.project-name', { hasText: renamedName })).toHaveCount(1);++ await expect(orkas.page.locator('#project-detail-title')).toHaveText(renamedName);+ expect(await orkas.page.evaluate(() => (window as any).composerText('project-chat-input'))).toBe('Keep this unsent project draft');+ expect(await composerNode!.evaluate(el => el === document.getElementById('project-chat-input'))).toBe(true);+ expect(await orkas.page.evaluate(() => (window as any).composerSelection('project-chat-input'))).toEqual({ start: 3, end: 7 });+ await orkas.page.screenshot({ path: testInfo.outputPath(`project-sidebar-rename-${locale}.png`) });++ const relaunchedPage = await orkas.relaunch();+ const renamedRow = relaunchedPage.locator('.project-row', {+ has: relaunchedPage.locator('.project-name', { hasText: renamedName }),+ });+ await expect(renamedRow).toHaveCount(1);+ await renamedRow.click();+ await expect(relaunchedPage.locator('#project-detail-title')).toHaveText(renamedName);});- await originalRow.hover();- const renameMenuButton = originalRow.locator('[data-project-menu]');- await expect(renameMenuButton).toBeVisible();- await renameMenuButton.click();- await orkas.page.locator('#project-row-menu [data-action="rename"]').click();- const renameInput = orkas.page.locator('input.project-rename-input[data-rename-pid]');- await expect(renameInput).toBeFocused();- await renameInput.fill(renamedName);- await renameInput.press('Enter');- await expect(orkas.page.locator('.project-name', { hasText: originalName })).toHaveCount(0);- await expect(orkas.page.locator('.project-name', { hasText: renamedName })).toHaveCount(1);-- const relaunchedPage = await orkas.relaunch();- const renamedRow = relaunchedPage.locator('.project-row', {- has: relaunchedPage.locator('.project-name', { hasText: renamedName }),- });- await expect(renamedRow).toHaveCount(1);- await renamedRow.click();- await expect(relaunchedPage.locator('#project-detail-title')).toHaveText(renamedName);- });+ }// The project page header keeps only the title; rename and delete live in its// "⋯" menu, and "Done" stands in for the menu while the title is edited.diff --git a/test/renderer/project-sidebar-navigation.test.ts b/test/renderer/project-sidebar-navigation.test.tsindex c11e3ffa..d838a639 100644--- a/test/renderer/project-sidebar-navigation.test.ts+++ b/test/renderer/project-sidebar-navigation.test.ts@@ -44,7 +44,7 @@ function mount({ cached = true, collapsed = false, previous = '' } = {}) {_composerNavigationEpoch: 0, composerBindOwner() {}, _saveLastView() {},_bootLog: { info() {}, warn() {} }, createLogger: () => ({ info() {}, warn() {} }),_clearLazyFeatureError() {}, _showLazyFeatureError() {},- setTimeout: () => 0, clearTimeout() {}, t: String, escapeHtml: String,+ setTimeout: () => 0, clearTimeout() {}, performance, t: String, escapeHtml: String,localStorage: { getItem: () => null, setItem() {} },document: {addEventListener() {}, getElementById: (id: string) => nodes.get(id) || null,@@ -65,10 +65,78 @@ function mount({ cached = true, collapsed = false, previous = '' } = {}) {if (cached) vm.runInContext(`_projectsCache = ${JSON.stringify(projects)}`, context);const selected = () => [...list.innerHTML.matchAll(/class="project-row active" data-pid="([^"]+)"/g)].map(match => match[1]);- return { context, list, toggle, scrolled, selected, deferred, featureLoads, loadProjectDetail };+ return { context, nodes, projects, list, toggle, scrolled, selected, deferred, featureLoads, loadProjectDetail };}describe('project navigation follows the destination in the sidebar', () => {+ it('updates the open detail immediately after a sidebar rename, preserving drafts while the list refresh waits', async () => {+ const h = mount({ previous: 'alpha' });+ h.context.currentView = 'project';+ h.context._projectDetailMeta = {+ project: { project_id: 'alpha', name: 'alpha' },+ draft: 'Keep editing',+ };+ const draft = { value: 'Unsubmitted title', selectionStart: 3 };+ h.nodes.set('project-detail-title-input', draft);+ h.nodes.get('project-detail-title').textContent = 'alpha';+ h.nodes.get('project-detail-content').innerHTML = 'Unsaved workspace';+ const renamed = { ...h.context._projectDetailMeta.project, name: 'Release readiness' };+ let releaseList!: (value: any) => void;+ const listResult = new Promise(resolve => { releaseList = resolve; });+ h.context.orkas.invoke.mockImplementation(async (channel: string) => {+ if (channel === 'projects.rename') return { ok: true, project: renamed };+ if (channel === 'projects.list') return listResult;+ throw new Error(`Unexpected channel: ${channel}`);+ });+ h.context._startProjectInlineRename('alpha');+ const listeners = new Map<string, (...args: any[]) => any>();+ h.context._bindInlineRenameInput({+ dataset: { renamePid: 'alpha' }, value: 'Release readiness',+ addEventListener: (name: string, listener: any) => listeners.set(name, listener),+ });+ const rename = listeners.get('blur')!();+ await new Promise(resolve => setImmediate(resolve));++ // Saved identity is visible before an unrelated list read finishes.+ expect(h.nodes.get('project-detail-title').textContent).toBe('Release readiness');+ expect(h.context._projectDetailMeta.project.name).toBe('Release readiness');+ expect(h.list.innerHTML).toContain('Release readiness');+ expect(h.context._projectDetailMeta.draft).toBe('Keep editing');+ expect(h.nodes.get('project-detail-content').innerHTML).toBe('Unsaved workspace');+ expect(draft).toEqual({ value: 'Unsubmitted title', selectionStart: 3 });+ expect(h.loadProjectDetail).not.toHaveBeenCalled();+ releaseList({ ok: true, projects: [renamed, h.projects[1]] });+ await rename;+ expect(h.nodes.get('project-detail-title').textContent).toBe('Release readiness');+ });++ it.each([true, false])('preserves the displayed project on another project rename or a rejected rename (success=%s)', async success => {+ const openProject = success ? 'beta' : 'alpha';+ const h = mount({ previous: openProject });+ h.context._projectDetailMeta = { project: { project_id: openProject, name: openProject } };+ h.nodes.get('project-detail-title').textContent = openProject;+ h.context.orkas.invoke.mockImplementation(async (channel: string) => {+ if (channel === 'projects.rename') return success+ ? { ok: true, project: { project_id: 'alpha', name: 'Renamed alpha' } }+ : { ok: false, error: 'name_dup' };+ return { ok: true, projects: [{ project_id: 'alpha', name: 'Renamed alpha' }, h.projects[1]] };+ });+ h.context._startProjectInlineRename('alpha');+ const listeners = new Map<string, (...args: any[]) => any>();+ h.context._bindInlineRenameInput({+ dataset: { renamePid: 'alpha' }, value: 'Renamed alpha',+ addEventListener: (name: string, listener: any) => listeners.set(name, listener),+ });+ await listeners.get('blur')!();+ expect(h.nodes.get('project-detail-title').textContent).toBe(openProject);+ expect(h.context._projectDetailMeta.project).toEqual({ project_id: openProject, name: openProject });+ if (!success) {+ expect(vm.runInContext('_projectsCache[0].name', h.context)).toBe('alpha');+ expect(h.context._renderProjectRow(h.projects[0], [])).toContain('project.name_dup_inline');+ }+ });++it.each(['', 'alpha'])('selects and reveals the target before detail loading, with previous detail %j', previous => {const h = mount({ previous, collapsed: true });h.context.setView('project', 'beta');