Skip to content

armgit / Orkas

Public Imported from GitHub
0

Orkas is an open-source (MIT), local-first AI team for your desktop: a Commander turns your goal into to-dos and coordinates 16 built-in specialist agents plus Claude Code, Codex, OpenCode, OpenClaw and Hermes, with projects, scheduled automations and connectors. Free app for macOS & Windows; built-in models or your own keys.

fix: commander-created agent/skill is reachable from the same conversation

wyte83c87d338bf
diff --git a/src/main/features/group_chat/bus.ts b/src/main/features/group_chat/bus.ts
index d3b8a1fb..348621e5 100644
--- a/src/main/features/group_chat/bus.ts
+++ b/src/main/features/group_chat/bus.ts
@@ -1152,6 +1152,22 @@ async function runTurn(state: CidState, w: WorkerState, item: QueueItem): Promis
const ag = await agentsFeat.createAgentFromBlocks(fields);
if (ag) {
createdAgents.push({ agent_id: ag.agent_id, name: ag.name, kind: 'created' });
+ // Project-scoped conv: auto-bind the new agent into the project's
+ // bindings.json so it's actually reachable from this conversation
+ // (commander picker filters by `_pickerBoundAgentIds`; LLM
+ // dispatch is gated by the same project scope per CLAUDE.md §5).
+ // Without this hop the user creates an agent and immediately
+ // can't @-mention it from the same conv — observed bug shape
+ // when the project's bindings predate the new agent.
+ if (turnProjectId) {
+ try {
+ const projectsFeatBind = await import('../projects');
+ await projectsFeatBind.addAgentBinding(uid, turnProjectId, ag.agent_id);
+ log.info(`auto-bound agent ${ag.agent_id} to project ${turnProjectId} after commander creation`);
+ } catch (err) {
+ log.warn(`auto-bind agent failed cid=${cid} pid=${turnProjectId} aid=${ag.agent_id}: ${(err as Error).message}`);
+ }
+ }
} else {
workingText = `${workingText}\n\n<span style="color:var(--danger)">⚠️ Agent creation failed: missing required field(s) (name / workflow).</span>`;
}
@@ -1187,6 +1203,20 @@ async function runTurn(state: CidState, w: WorkerState, item: QueueItem): Promis
const list = result.rejected.map((p) => `\`${p}\``).join(', ');
workingText = `${workingText}\n\n<span style="color:var(--danger)">⚠️ Some skill files were rejected: ${list}</span>`;
}
+ // Project-scoped conv: auto-bind the new skill so the LLM in this
+ // conv actually sees it via getSystemPromptBlock allowlist. Same
+ // bug shape as the agent auto-bind above — without this the user
+ // creates a skill, the file lands on disk, but the LLM in this
+ // project conv can never invoke it (allowlist excludes it).
+ if (turnProjectId && result.kind === 'created') {
+ try {
+ const projectsFeatBind = await import('../projects');
+ await projectsFeatBind.addSkillBinding(uid, turnProjectId, result.skillId);
+ log.info(`auto-bound skill ${result.skillId} to project ${turnProjectId} after commander creation`);
+ } catch (err) {
+ log.warn(`auto-bind skill failed cid=${cid} pid=${turnProjectId} sid=${result.skillId}: ${(err as Error).message}`);
+ }
+ }
} else {
workingText = `${workingText}\n\n<span style="color:var(--danger)">⚠️ ${result.error || 'Skill operation failed.'}</span>`;
}
diff --git a/src/renderer/modules/boot.js b/src/renderer/modules/boot.js
index 0e16bf80..a71bf61b 100644
--- a/src/renderer/modules/boot.js
+++ b/src/renderer/modules/boot.js
@@ -216,10 +216,20 @@ function setView(view, cid, opts = {}) {
setTimeout(() => document.getElementById('new-chat-input')?.focus(), 50);
} else if (view === 'agents') {
currentCid = null;
- loadAgents();
+ // Force-refresh on every tab visit. The mid-stream chip handler in
+ // `conversation.js::_mountCreatedAgentChip` already calls `loadAgents(true)`
+ // when an agent is created via commander, but that only fires while the
+ // user is on the conversation view. If the user navigates to the agents
+ // tab between or during creation streams, the chip path may not run /
+ // may have raced, leaving `_agentsCache` stale and the tab missing the
+ // newly-created agents. Cheap (one IPC + dir scan), and the tab is the
+ // user's recovery path when something looks off — making it always show
+ // ground truth.
+ loadAgents(true);
} else if (view === 'skills') {
currentCid = null;
- loadSkills();
+ // Same reasoning as the agents branch above.
+ loadSkills(true);
} else if (view === 'contexts') {
currentCid = null;
loadContexts();