Orkas is an open-source (MIT), local-first AI team for your desktop: a Commander turns your goal into to-dos and coordinates 16 built-in specialist agents plus Claude Code, Codex, OpenCode, OpenClaw and Hermes, with projects, scheduled automations and connectors. Free app for macOS & Windows; built-in models or your own keys.
JavaScript agent-collaborationagent-harnessagent-orchestrationagent-teamagent-workflowai-assistantai-automationai-employeeai-productivityai-teamai-workflowautonomous-agentsclaude-code-guiclaude-coworkdesktop-agentlocal-firstmulti-agentmulti-agent-systemself-evolving-agentstask-automation
fix: polling rescue doesn't recognize GroupMessage + stop button stuck
wytffb99d1ecd67
diff --git a/src/renderer/modules/conversation.js b/src/renderer/modules/conversation.jsindex dc6e0708..aeea1d5d 100644--- a/src/renderer/modules/conversation.js+++ b/src/renderer/modules/conversation.js@@ -4188,7 +4188,23 @@ function abortConvStream(cid) {// queues. Cancelling just the IPC stream would leave agents running in the// background. Fire-and-forget — no need to block the UI on the response.try { apiFetch(`/api/conversations/${cid}/abort`, { method: 'POST' }); } catch (_) {}- if (!state || !state.controller) return;+ if (!state) return;+ // No-controller case: the pendingConvs entry was minted by+ // `loadConversationHistory`'s polling-rescue branch (user opened a conv+ // whose worker was started from outside this renderer — scheduled-task+ // fire, or a refresh mid-turn). There's no in-process stream to cancel;+ // the bus.abort POST above does the actual work. Clear the placeholder+ // and the pending entry so the send button flips back to "send" and the+ // sidebar badge drops. Without this, the button stayed pinned as "stop"+ // and re-clicks were no-ops.+ if (!state.controller) {+ pendingConvs.delete(cid);+ stopPolling(cid);+ if (state.loadingEl && state.loadingEl.isConnected) state.loadingEl.remove();+ _updateConvSidebarBadge(cid, false);+ if (cid === currentCid) _updateConvSendUI(cid);+ return;+ }state.aborted = true;try { state.controller.abort(); } catch (_) {}// Repaint the sidebar badge now — `_updateConvSidebarBadge` readsdiff --git a/src/renderer/modules/state.js b/src/renderer/modules/state.jsindex e30de12e..998b337e 100644--- a/src/renderer/modules/state.js+++ b/src/renderer/modules/state.js@@ -31,6 +31,20 @@ const pollMsgCounts = new Map(); // cid → last known message count// `loadConversationHistory` call. True for conversations with no agent_id.const convAgentEnabledByCid = new Map();+// Backend `/api/conversations/<cid>/history` returns raw GroupMessage+// records (`{id, ts, from, to, text, ...}`) — NOT the legacy+// `{role, content, time}` shape. `loadConversationHistory` translates via+// `_groupMsgToLegacy`; the polling rescue path forgot to. Polling now+// looks at `from` directly: anything not `'user'` is an assistant-side+// reply (commander or any agent), and `from === 'user'` is a user+// message. Without this, polling never recognised the agent's reply, so+// the "thinking…" loadingEl created for mid-turn opens stayed pinned+// forever (visible as a stuck `智能体 思考中…` bubble below the actual+// reply — the symptom that surfaced once scheduled-task fires made the+// "open conv mid-turn without a local ctrl" path common).+function _isPolledAssistantMsg(m) { return !!(m && m.from && m.from !== 'user'); }+function _isPolledUserMsg(m) { return !!(m && m.from === 'user'); }+function startPolling(cid) {if (pollTimers.has(cid)) return;const timer = setInterval(async () => {@@ -43,16 +57,16 @@ function startPolling(cid) {const last = msgs[msgs.length - 1];const known = pollMsgCounts.get(cid) || 0;- if (msgs.length > known && last?.role === 'assistant') {+ if (msgs.length > known && _isPolledAssistantMsg(last)) {// New assistant message arrivedpollMsgCounts.set(cid, msgs.length);stopPolling(cid);- _onPolledResponse(cid, last.content);+ _onPolledResponse(cid, last.text);return;}// If server is no longer processing but last message is still user → request was lost- if (last?.role === 'user' && data.conversation?.processing === false) {+ if (_isPolledUserMsg(last) && data.conversation?.processing === false) {stopPolling(cid);_onPolledResponse(cid, t('chat.reply_interrupted'), true);return;@@ -62,7 +76,7 @@ function startPolling(cid) {// model idle watchdog (10 min) + a small buffer. Shorter thresholds would// trip on genuine long agent runs.const since = data.conversation?.processing_since;- if (last?.role === 'user' && data.conversation?.processing === true && since) {+ if (_isPolledUserMsg(last) && data.conversation?.processing === true && since) {const elapsedSec = (Date.now() - new Date(since).getTime()) / 1000;if (elapsedSec > 720) {stopPolling(cid);