Skip to content

ActivityPub-federated video streaming platform using P2P directly in your web browser

Fix pause bezel on video change

Chocobozzz1472356e6028
diff --git a/client/src/standalone/player/src/shared/bezels/bezels-plugin.ts b/client/src/standalone/player/src/shared/bezels/bezels-plugin.ts
index 0de47c53c8..6691fc1135 100644
--- a/client/src/standalone/player/src/shared/bezels/bezels-plugin.ts
+++ b/client/src/standalone/player/src/shared/bezels/bezels-plugin.ts
@@ -15,7 +15,10 @@ class BezelsPlugin extends Plugin {
const component = new PauseBezel(player, options)
player.addChild(component)
- this.on('dispose', () => player.removeChild(component))
+ this.on('dispose', () => {
+ // Component will remove itself from the player
+ component.dispose()
+ })
}
}
diff --git a/client/src/standalone/player/src/shared/bezels/pause-bezel.ts b/client/src/standalone/player/src/shared/bezels/pause-bezel.ts
index c921ead4dc..d63c8b7812 100644
--- a/client/src/standalone/player/src/shared/bezels/pause-bezel.ts
+++ b/client/src/standalone/player/src/shared/bezels/pause-bezel.ts
@@ -81,7 +81,7 @@ export class PauseBezel extends Component {
this.firstPlayDone = false
}
- player.on('video-change', () => this.videoChangeHandler)
+ player.on('video-change', this.videoChangeHandler)
player.on('pause', this.playerPauseHandler)
player.on('play', this.playerPlayHandler)
}
diff --git a/client/src/standalone/player/src/shared/upnext/upnext-plugin.ts b/client/src/standalone/player/src/shared/upnext/upnext-plugin.ts
index 24571b4a2b..363367eda5 100644
--- a/client/src/standalone/player/src/shared/upnext/upnext-plugin.ts
+++ b/client/src/standalone/player/src/shared/upnext/upnext-plugin.ts
@@ -26,7 +26,7 @@ class UpNextPlugin extends Plugin {
const component = new EndCard(player, settings)
player.addChild(component)
- this.on('dispose', () => player.removeChild(component))
+ this.on('dispose', () => component.dispose())
}
}