Self-hosted, Self-Improving, Federated Everything App — dev management, agent orchestration, persistent mind, digital twin, second brain, and creative pipeline from a single dashboard over Tailscale to port the user into the OS
JavaScript ai-agentsdashboarddeveloper-toolsdigital-twinquantified-selfsecond-brainself-hostedtailscale
import { describe, it, expect, vi, beforeEach, afterEach } from 'vitest';
import { act, render, screen, fireEvent, waitFor, within } from '@testing-library/react';
import { MemoryRouter, useLocation, useNavigate } from 'react-router';
import PromptManager from './PromptManager';
import toast from '../components/ui/Toast';
// The Stages pane is the subject: 100+ rows with no way to reach one (#3284).
// Only the list-shaping API calls need real fixtures; everything else resolves
// empty so the page mounts.
const getPrompts = vi.fn();
const getPrompt = vi.fn();
const getPromptUsage = vi.fn();
const savePrompt = vi.fn();
const previewPrompt = vi.fn();
const deletePrompt = vi.fn();
const createPrompt = vi.fn();
const getPromptVariables = vi.fn();
const createPromptVariable = vi.fn();
const savePromptVariable = vi.fn();
const deletePromptVariable = vi.fn();
const getJobSkills = vi.fn(() => Promise.resolve({ skills: [] }));
const getJobSkill = vi.fn(() => Promise.resolve({}));
const saveJobSkill = vi.fn();
const previewJobSkill = vi.fn();
vi.mock('../services/apiPrompts', () => ({
getPrompts: (...a) => getPrompts(...a),
getPrompt: (...a) => getPrompt(...a),
createPrompt: (...a) => createPrompt(...a),
savePrompt: (...a) => savePrompt(...a),
deletePrompt: (...a) => deletePrompt(...a),
previewPrompt: (...a) => previewPrompt(...a),
getPromptUsage: (...a) => getPromptUsage(...a),
getPromptVariables: (...a) => getPromptVariables(...a),
createPromptVariable: (...a) => createPromptVariable(...a),
savePromptVariable: (...a) => savePromptVariable(...a),
deletePromptVariable: (...a) => deletePromptVariable(...a),
getJobSkills: (...a) => getJobSkills(...a),
getJobSkill: (...a) => getJobSkill(...a),
saveJobSkill: (...a) => saveJobSkill(...a),
previewJobSkill: (...a) => previewJobSkill(...a),
}));
vi.mock('../services/apiProviders', () => ({
getProviders: vi.fn(() => Promise.resolve({ providers: [], activeProvider: null })),
}));
vi.mock('../services/api', async (importOriginal) => ({
...await importOriginal(),
getInstanceFeatures: vi.fn().mockResolvedValue({ features: [], groups: [] }),
}));
vi.mock('../components/ui/Toast', () => ({
default: { success: vi.fn(), error: vi.fn() },
}));
const STAGES = {
'pipeline-prose-draft': { name: 'Pipeline — Prose Draft', description: 'Draft the prose' },
'pipeline-comic-script': { name: 'Pipeline — Comic Book Script', description: 'Panels and balloons' },
'creative-director-treatment': { name: 'Creative Director — Treatment', description: 'Treatment doc' },
'brain-classifier': { name: 'Brain Classifier', description: 'Classify a thought' },
};
// The system-stage list is served, not mirrored client-side (#3314) — the page
// badges and filters exactly what GET /api/prompts names in `systemStages`.
const SYSTEM_STAGES = ['brain-classifier'];
// Surfaces the live search string so URL-driven selection can be asserted on.
const LocationProbe = () => {
const { search } = useLocation();
const navigate = useNavigate();
return <>
<div data-testid="location-search">{search}</div>
<button onClick={() => navigate(-1)}>History Back</button>
<button onClick={() => navigate(1)}>History Forward</button>
</>;
};
const renderPage = async (entry = '/prompts') => {
const result = render(
<MemoryRouter initialEntries={[entry]}>
<PromptManager />
<LocationProbe />
</MemoryRouter>,
);
await act(async () => {});
return result;
};
const currentSearch = () => screen.getByTestId('location-search').textContent;
// File-level defaults so every describe mounts against the same empty-ish page;
// individual suites override only what they assert on.
beforeEach(() => {
getPromptVariables.mockReset().mockResolvedValue({ variables: {} });
createPromptVariable.mockReset().mockResolvedValue({ success: true });
savePromptVariable.mockReset().mockResolvedValue({ success: true });
deletePromptVariable.mockReset().mockResolvedValue({ success: true });
});
const searchBox = () => screen.getByLabelText('Search prompt stages');
const groupHeader = (label) => screen.getByRole('button', { name: new RegExp(`^${label}, \\d+ stages?$`, 'i') });
describe('PromptManager stage list', () => {
beforeEach(() => {
getPrompts.mockReset().mockResolvedValue({ stages: STAGES, systemStages: SYSTEM_STAGES });
getPrompt.mockReset().mockResolvedValue({ name: 'Pipeline — Prose Draft', template: 'body', variables: [] });
getPromptUsage.mockReset().mockResolvedValue({
isSystemStage: false, usedBy: [], referencedBy: [], canDelete: true,
});
});
it('shows collapsed groups and a stage count instead of a flat 100-row list', async () => {
await renderPage();
await screen.findByText('Prompt Stages');
// Group headers, not rows.
expect(groupHeader('Pipeline')).toBeTruthy();
expect(groupHeader('Brain').getAttribute('aria-label')).toBe('Brain, 1 stage');
expect(groupHeader('Pipeline').getAttribute('aria-label')).toBe('Pipeline, 2 stages');
expect(screen.getByText('4 stages')).toBeTruthy();
expect(screen.queryByText('Pipeline — Prose Draft')).toBeNull();
});
it('expands and re-collapses a group on click', async () => {
await renderPage();
await screen.findByText('Prompt Stages');
const header = groupHeader('Pipeline');
expect(header.getAttribute('aria-expanded')).toBe('false');
fireEvent.click(header);
expect(header.getAttribute('aria-expanded')).toBe('true');
expect(screen.getByText('Pipeline — Prose Draft')).toBeTruthy();
fireEvent.click(header);
expect(screen.queryByText('Pipeline — Prose Draft')).toBeNull();
});
it('filters rows on the title as the user types, auto-revealing matches', async () => {
await renderPage();
await screen.findByText('Prompt Stages');
fireEvent.change(searchBox(), { target: { value: 'comic' } });
// No manual expand needed — a filtered group shows its matches.
expect(screen.getByText('Pipeline — Comic Book Script')).toBeTruthy();
expect(screen.queryByText('Pipeline — Prose Draft')).toBeNull();
expect(screen.queryByText('Brain Classifier')).toBeNull();
expect(screen.getByText('1 of 4')).toBeTruthy();
});
it('keeps the group toggle live while filtering so a broad query can be folded', async () => {
await renderPage();
await screen.findByText('Prompt Stages');
// A query matching everything must not become an uncollapsible wall.
fireEvent.change(searchBox(), { target: { value: 'e' } });
expect(screen.getByText('4 of 4')).toBeTruthy();
expect(groupHeader('Pipeline').getAttribute('aria-expanded')).toBe('true');
expect(screen.getByText('Pipeline — Prose Draft')).toBeTruthy();
fireEvent.click(groupHeader('Pipeline'));
expect(groupHeader('Pipeline').getAttribute('aria-expanded')).toBe('false');
expect(screen.queryByText('Pipeline — Prose Draft')).toBeNull();
// Folding one group leaves the others open.
expect(screen.getByText('Brain Classifier')).toBeTruthy();
});
it('forgets a filter-scoped collapse once the filter clears', async () => {
await renderPage();
await screen.findByText('Prompt Stages');
fireEvent.change(searchBox(), { target: { value: 'e' } });
fireEvent.click(groupHeader('Pipeline'));
expect(groupHeader('Pipeline').getAttribute('aria-expanded')).toBe('false');
// Clearing returns to the collapsed-by-default view...
fireEvent.change(searchBox(), { target: { value: '' } });
expect(groupHeader('Pipeline').getAttribute('aria-expanded')).toBe('false');
// ...and the stale fold does not carry into the NEXT filter session. This
// is the assertion that actually observes the set — while no filter is on,
// `collapsedWhileFiltering` is never read, so clearing it is invisible.
fireEvent.change(searchBox(), { target: { value: 'e' } });
expect(groupHeader('Pipeline').getAttribute('aria-expanded')).toBe('true');
});
it('drops a fold when the query is refined, so the new match cannot hide behind it', async () => {
await renderPage();
await screen.findByText('Prompt Stages');
fireEvent.change(searchBox(), { target: { value: 'e' } });
fireEvent.click(groupHeader('Pipeline'));
expect(screen.queryByText('Pipeline — Comic Book Script')).toBeNull();
// Refining to a query whose ONLY hit lives in the folded group must show it.
fireEvent.change(searchBox(), { target: { value: 'comic' } });
expect(screen.getByText('1 of 4')).toBeTruthy();
expect(screen.getByText('Pipeline — Comic Book Script')).toBeTruthy();
});
it('drops a fold when the SYSTEM toggle changes the filter', async () => {
await renderPage();
await screen.findByText('Prompt Stages');
fireEvent.change(searchBox(), { target: { value: 'e' } });
fireEvent.click(groupHeader('Brain'));
expect(screen.queryByText('Brain Classifier')).toBeNull();
fireEvent.click(screen.getByRole('button', { name: /system only/i }));
expect(screen.getByText('Brain Classifier')).toBeTruthy();
});
it('folds two spellings of the same family into one group', async () => {
getPrompts.mockResolvedValue({
stages: {
...STAGES,
'pipeline-lowercase': { name: 'pipeline — hand typed', description: 'user made' },
},
systemStages: SYSTEM_STAGES,
});
await renderPage();
await screen.findByText('Prompt Stages');
// One PIPELINE header, holding all three — not two headers that render alike.
expect(screen.getAllByRole('button', { name: /^Pipeline, \d+ stages?$/i })).toHaveLength(1);
fireEvent.click(groupHeader('Pipeline'));
expect(screen.getByText('pipeline — hand typed')).toBeTruthy();
expect(screen.getByText('Pipeline — Prose Draft')).toBeTruthy();
});
it('filters on the description too', async () => {
await renderPage();
await screen.findByText('Prompt Stages');
fireEvent.change(searchBox(), { target: { value: 'balloons' } });
expect(screen.getByText('Pipeline — Comic Book Script')).toBeTruthy();
expect(screen.getByText('1 of 4')).toBeTruthy();
});
it('reports an empty result rather than a silently blank pane', async () => {
await renderPage();
await screen.findByText('Prompt Stages');
fireEvent.change(searchBox(), { target: { value: 'zzzz' } });
expect(screen.getByText('No stages match that search')).toBeTruthy();
});
it('clears the query from the clear button', async () => {
await renderPage();
await screen.findByText('Prompt Stages');
fireEvent.change(searchBox(), { target: { value: 'comic' } });
fireEvent.click(screen.getByLabelText('Clear stage search'));
expect(searchBox().value).toBe('');
expect(screen.getByText('4 stages')).toBeTruthy();
// Rows the filter revealed go back into their collapsed groups.
expect(screen.queryByText('Pipeline — Comic Book Script')).toBeNull();
});
it('narrows to system stages with the SYSTEM-only toggle', async () => {
await renderPage();
await screen.findByText('Prompt Stages');
const toggle = screen.getByRole('button', { name: /system only/i });
expect(toggle.getAttribute('aria-pressed')).toBe('false');
fireEvent.click(toggle);
expect(toggle.getAttribute('aria-pressed')).toBe('true');
expect(screen.getByText('Brain Classifier')).toBeTruthy();
expect(screen.queryByText('Pipeline — Prose Draft')).toBeNull();
expect(screen.getByText('1 of 4')).toBeTruthy();
});
// The badge and the filter follow the SERVED list, not a client-side copy of
// it (#3314) — a stage the server names is reachable even though no hardcoded
// client array ever mentioned it.
it('badges and filters whatever the server names in systemStages', async () => {
getPrompts.mockResolvedValue({ stages: STAGES, systemStages: ['creative-director-treatment'] });
await renderPage();
await screen.findByText('Prompt Stages');
fireEvent.click(screen.getByRole('button', { name: /system only/i }));
expect(screen.getByText('Creative Director — Treatment')).toBeTruthy();
expect(screen.queryByText('Brain Classifier')).toBeNull();
expect(screen.getByText('1 of 4')).toBeTruthy();
expect(screen.getAllByText('System')).toHaveLength(1);
});
// An older server (or a failed load) sends no list: badge nothing, filter to
// nothing — never crash on a missing key.
it('degrades to no system stages when the server omits the list', async () => {
getPrompts.mockResolvedValue({ stages: STAGES });
await renderPage();
await screen.findByText('Prompt Stages');
fireEvent.click(screen.getByRole('button', { name: /system only/i }));
expect(screen.getByText('No stages match that search')).toBeTruthy();
expect(screen.getByText('0 of 4')).toBeTruthy();
});
it('selects a stage into the URL from a filtered row', async () => {
await renderPage();
await screen.findByText('Prompt Stages');
fireEvent.change(searchBox(), { target: { value: 'comic' } });
fireEvent.click(screen.getByText('Pipeline — Comic Book Script'));
await waitFor(() => expect(getPrompt).toHaveBeenCalledWith('pipeline-comic-script', { silent: true }));
});
it('opens the group holding a deep-linked stage', async () => {
await renderPage('/prompts?stage=brain-classifier');
await screen.findByText('Prompt Stages');
await waitFor(() => expect(groupHeader('Brain').getAttribute('aria-expanded')).toBe('true'));
expect(screen.getByText('Brain Classifier')).toBeTruthy();
// Sibling groups stay closed.
expect(groupHeader('Pipeline').getAttribute('aria-expanded')).toBe('false');
});
});
describe('PromptManager delete demotion', () => {
beforeEach(() => {
getPrompts.mockReset().mockResolvedValue({ stages: STAGES, systemStages: SYSTEM_STAGES });
getPrompt.mockReset().mockResolvedValue({ name: 'Brain Classifier', template: 'body', variables: [] });
// Mirrors the exact wire body of GET /api/prompts/:stage/usage — pinned
// server-side in server/routes/prompts.test.js.
getPromptUsage.mockReset().mockResolvedValue({
isSystemStage: true,
usedBy: ['Brain thought classification'],
referencedBy: ['server/services/brain.js'],
canDelete: false,
});
deletePrompt.mockReset().mockResolvedValue({ success: true });
});
it('keeps delete — or any other control — out of the list rows entirely', async () => {
await renderPage();
await screen.findByText('Prompt Stages');
fireEvent.click(groupHeader('Pipeline'));
// Count buttons rather than probe for a label: a re-added row control
// fails this however it happens to be named.
const rows = screen.getByText('Pipeline — Prose Draft').closest('div[class*="space-y-1"]');
expect(within(rows).getAllByRole('button')).toHaveLength(2);
expect(within(rows).getByText('Pipeline — Comic Book Script')).toBeTruthy();
});
it('offers delete from the selected stage detail pane', async () => {
await renderPage('/prompts?stage=brain-classifier');
await screen.findByText('Prompt Stages');
const del = await screen.findByRole('button', { name: /^delete$/i });
fireEvent.click(del);
await waitFor(() => expect(getPromptUsage).toHaveBeenCalledWith('brain-classifier', { silent: true }));
expect(await screen.findByText('Delete System Stage?')).toBeTruthy();
});
// #3335: protection is wider than the SYSTEM badge. A pipeline stage carries
// no badge but is still undeletable without ?force=true, so the dialog has to
// warn AND the confirm has to send force — otherwise every delete 400s.
it('warns and names the source files for a referenced non-system stage', async () => {
getPromptUsage.mockResolvedValue({
isSystemStage: false,
usedBy: [],
referencedBy: ['server/services/pipeline/textStages.js', 'server/services/pipeline/pipelineJudge.js'],
canDelete: false,
});
await renderPage('/prompts?stage=pipeline-comic-script');
await screen.findByText('Prompt Stages');
fireEvent.click(await screen.findByRole('button', { name: /^delete$/i }));
expect(await screen.findByText('Delete Referenced Stage?')).toBeTruthy();
expect(screen.getByText('server/services/pipeline/textStages.js')).toBeTruthy();
expect(screen.getByText('server/services/pipeline/pipelineJudge.js')).toBeTruthy();
// The modal's confirm is the last "Delete" in the tree (the detail pane
// keeps its own trigger mounted behind the backdrop).
fireEvent.click(screen.getAllByRole('button', { name: /^delete$/i }).at(-1));
await waitFor(() => expect(deletePrompt).toHaveBeenCalledWith(
'pipeline-comic-script', { force: true }, { silent: true },
));
});
it('deletes a user-authored stage without force', async () => {
getPromptUsage.mockResolvedValue({ isSystemStage: false, usedBy: [], referencedBy: [], canDelete: true });
await renderPage('/prompts?stage=pipeline-comic-script');
await screen.findByText('Prompt Stages');
fireEvent.click(await screen.findByRole('button', { name: /^delete$/i }));
expect(await screen.findByText('Delete Stage?')).toBeTruthy();
fireEvent.click(screen.getAllByRole('button', { name: /^delete$/i }).at(-1));
await waitFor(() => expect(deletePrompt).toHaveBeenCalledWith(
'pipeline-comic-script', { force: false }, { silent: true },
));
});
});
// #3935: the row trash icon used to fire DELETE on the first click, so a
// mis-click on a 14px target destroyed the variable with no undo.
describe('PromptManager stage save/create/delete feedback (#6022)', () => {
beforeEach(() => {
getPrompts.mockReset().mockResolvedValue({ stages: STAGES, systemStages: SYSTEM_STAGES });
getPrompt.mockReset().mockResolvedValue({ name: 'Pipeline — Comic Book Script', template: 'body', variables: [] });
getPromptUsage.mockReset().mockResolvedValue({
isSystemStage: false, usedBy: [], referencedBy: [], canDelete: true,
});
savePrompt.mockReset().mockResolvedValue({ success: true });
createPrompt.mockReset().mockResolvedValue({ success: true, stageName: 'my-new-stage' });
deletePrompt.mockReset().mockResolvedValue({ success: true });
toast.error.mockReset();
toast.success.mockReset();
});
it('confirms a successful stage save with a named toast', async () => {
await renderPage('/prompts?stage=pipeline-comic-script');
await screen.findByText('Prompt Stages');
await screen.findByRole('button', { name: /^save$/i });
fireEvent.click(screen.getByRole('button', { name: /^save$/i }));
await waitFor(() => expect(toast.success).toHaveBeenCalledWith('Stage "Pipeline — Comic Book Script" saved'));
expect(toast.error).not.toHaveBeenCalled();
});
it('confirms stage creation with a named toast and deep-links straight to the new stage', async () => {
await renderPage('/prompts');
await screen.findByText('Prompt Stages');
fireEvent.click(screen.getByRole('button', { name: 'New Stage' }));
fireEvent.change(screen.getByPlaceholderText('my-stage'), { target: { value: 'my-new-stage' } });
fireEvent.change(screen.getByPlaceholderText('Pipeline — My Stage'), { target: { value: 'My New Stage' } });
fireEvent.click(screen.getByRole('button', { name: /create stage/i }));
await waitFor(() => expect(toast.success).toHaveBeenCalledWith('Stage "My New Stage" created'));
await waitFor(() => expect(currentSearch()).toContain('stage=my-new-stage'));
});
it('confirms a successful stage delete with a named toast', async () => {
await renderPage('/prompts?stage=pipeline-comic-script');
await screen.findByText('Prompt Stages');
fireEvent.click(await screen.findByRole('button', { name: /^delete$/i }));
expect(await screen.findByText('Delete Stage?')).toBeTruthy();
fireEvent.click(screen.getAllByRole('button', { name: /^delete$/i }).at(-1));
await waitFor(() => expect(toast.success).toHaveBeenCalledWith('Stage "pipeline-comic-script" deleted'));
});
});
describe('PromptManager variable deletion', () => {
const VARIABLES = {
'tone-guide': { name: 'Tone Guide', category: 'style', content: 'stay wry' },
'house-style': { name: 'House Style', category: 'style', content: 'oxford comma' },
};
beforeEach(() => {
getPrompts.mockReset().mockResolvedValue({ stages: STAGES, systemStages: SYSTEM_STAGES });
getPromptVariables.mockResolvedValue({ variables: VARIABLES });
});
const openVariables = async () => {
await renderPage('/prompts?tab=variables');
return screen.findByText('Tone Guide');
};
it('arms an inline confirm instead of deleting on the trash click', async () => {
await openVariables();
fireEvent.click(screen.getByLabelText('Delete variable Tone Guide'));
expect(deletePromptVariable).not.toHaveBeenCalled();
expect(screen.getByText('Delete "Tone Guide"?')).toBeTruthy();
// Only the armed row confirms; its sibling stays a normal row.
expect(screen.getByLabelText('Delete variable House Style')).toBeTruthy();
});
it('deletes only after the inline confirm', async () => {
await openVariables();
fireEvent.click(screen.getByLabelText('Delete variable Tone Guide'));
fireEvent.click(within(screen.getByLabelText('Confirm delete variable Tone Guide'))
.getByRole('button', { name: /^delete$/i }));
await waitFor(() => expect(deletePromptVariable).toHaveBeenCalledWith('tone-guide', { silent: true }));
});
it('leaves the variable intact when the confirm is cancelled', async () => {
await openVariables();
fireEvent.click(screen.getByLabelText('Delete variable Tone Guide'));
fireEvent.click(screen.getByRole('button', { name: /^cancel$/i }));
expect(deletePromptVariable).not.toHaveBeenCalled();
expect(screen.queryByText('Delete "Tone Guide"?')).toBeNull();
expect(screen.getByLabelText('Delete variable Tone Guide')).toBeTruthy();
});
it('arms one row at a time', async () => {
await openVariables();
fireEvent.click(screen.getByLabelText('Delete variable Tone Guide'));
fireEvent.click(screen.getByLabelText('Delete variable House Style'));
expect(screen.queryByText('Delete "Tone Guide"?')).toBeNull();
expect(screen.getByText('Delete "House Style"?')).toBeTruthy();
});
});
// Saving a variable used to deselect it and blank the editor with no toast, so
// a successful save read as a crash; switching variables threw unsaved edits
// away silently (#6023).
describe('PromptManager variable editing', () => {
const VARIABLES = {
'tone-guide': { name: 'Tone Guide', category: 'style', content: 'stay wry' },
'house-style': { name: 'House Style', category: 'style', content: 'oxford comma' },
};
beforeEach(() => {
getPrompts.mockReset().mockResolvedValue({ stages: STAGES, systemStages: SYSTEM_STAGES });
getPromptVariables.mockResolvedValue({ variables: VARIABLES });
toast.success.mockReset();
});
const contentBox = () => screen.getByPlaceholderText('Variable content...');
const saveButton = () => screen.getByRole('button', { name: /^save$/i });
// Waits on the hydrated CONTENT, not just the heading: the heading renders
// from the URL param a commit before the effect fills the form, so keying off
// it makes every later assertion a race against an empty editor.
const openVariable = async (key = 'tone-guide') => {
await renderPage(`/prompts?tab=variables&var=${key}`);
await screen.findByDisplayValue(VARIABLES[key].content);
};
it('keeps the saved variable open in the editor and confirms with a toast', async () => {
await openVariable();
// Re-stub AFTER the mount load, so only the post-save refetch carries the
// extra sibling — staging it with mockResolvedValueOnce instead would bake
// in an assumption about how many times the page loads before the save.
getPromptVariables.mockResolvedValue({ variables: { ...VARIABLES, 'aside-voice': { name: 'Aside Voice', content: 'wink' } } });
fireEvent.change(contentBox(), { target: { value: 'stay dry' } });
fireEvent.click(saveButton());
await waitFor(() => expect(toast.success).toHaveBeenCalledWith('Variable "Tone Guide" saved'));
expect(savePromptVariable).toHaveBeenCalledWith(
'tone-guide', expect.objectContaining({ content: 'stay dry' }), { silent: true },
);
// The refetch still carries the PRE-save content, so the editor must NOT be
// re-hydrated from it, deselected, or blanked. The toast fires BEFORE that
// refetch, so waiting on it asserts ahead of the very state change under
// test — the sibling above is what makes the refresh's arrival observable,
// and #6023 slips through this test unnoticed without it (#6189).
await screen.findByText('Aside Voice');
expect(currentSearch()).toContain('var=tone-guide');
expect(screen.getByText('Edit: tone-guide')).toBeTruthy();
expect(contentBox().value).toBe('stay dry');
expect(screen.queryByText('Unsaved changes')).toBeNull();
});
it('selects the created variable in the URL and confirms with a toast', async () => {
// The list only holds the new key after the post-create refetch, which is
// what the URL waits for.
getPromptVariables
.mockResolvedValueOnce({ variables: VARIABLES })
.mockResolvedValue({ variables: { ...VARIABLES, 'aside-voice': { name: 'Aside Voice', content: 'wink' } } });
await renderPage('/prompts?tab=variables');
await screen.findByText('Tone Guide');
fireEvent.change(screen.getByPlaceholderText('variableKey'), { target: { value: 'aside-voice' } });
fireEvent.change(contentBox(), { target: { value: 'wink' } });
fireEvent.click(saveButton());
await waitFor(() => expect(toast.success).toHaveBeenCalledWith('Variable "aside-voice" created'));
expect(createPromptVariable).toHaveBeenCalledWith(
expect.objectContaining({ key: 'aside-voice', content: 'wink' }), { silent: true },
);
// Both halves in ONE barrier: neither settles last on its own (#6189).
// The post-create refetch re-runs the hydration effect while the selection
// is still null, which resets the form to BLANK — the URL adopts the new key
// only afterwards, and re-hydrating from the refetched record is a further
// commit still. So waiting on the URL alone reads a blanked textarea. But
// waiting on the textarea alone is a barrier already open, since it holds
// 'wink' from the typing above, leaving the URL as the racing read instead.
await waitFor(() => {
expect(currentSearch()).toContain('var=aside-voice');
expect(contentBox().value).toBe('wink');
});
expect(screen.getByText('Edit: aside-voice')).toBeTruthy();
});
it('confirms a delete with a toast', async () => {
await renderPage('/prompts?tab=variables');
await screen.findByText('Tone Guide');
fireEvent.click(screen.getByLabelText('Delete variable Tone Guide'));
fireEvent.click(within(screen.getByLabelText('Confirm delete variable Tone Guide'))
.getByRole('button', { name: /^delete$/i }));
await waitFor(() => expect(toast.success).toHaveBeenCalledWith('Variable "Tone Guide" deleted'));
});
it('asks before another variable replaces unsaved edits', async () => {
await openVariable();
fireEvent.change(contentBox(), { target: { value: 'stay dry' } });
fireEvent.click(screen.getByText('House Style'));
// Parked, not switched: the discard question takes over the clicked row.
expect(screen.getByText('Discard unsaved changes to "Tone Guide"?')).toBeTruthy();
expect(currentSearch()).toContain('var=tone-guide');
expect(contentBox().value).toBe('stay dry');
});
it('keeps the edits when the discard prompt is cancelled', async () => {
await openVariable();
fireEvent.change(contentBox(), { target: { value: 'stay dry' } });
fireEvent.click(screen.getByText('House Style'));
fireEvent.click(screen.getByRole('button', { name: /^keep editing$/i }));
expect(screen.queryByText('Discard unsaved changes to "Tone Guide"?')).toBeNull();
expect(currentSearch()).toContain('var=tone-guide');
expect(contentBox().value).toBe('stay dry');
expect(screen.getByText('House Style')).toBeTruthy();
});
it('switches to the clicked variable once the discard is confirmed', async () => {
await openVariable();
fireEvent.change(contentBox(), { target: { value: 'stay dry' } });
fireEvent.click(screen.getByText('House Style'));
fireEvent.click(screen.getByRole('button', { name: /^discard$/i }));
await screen.findByDisplayValue('oxford comma');
expect(currentSearch()).toContain('var=house-style');
expect(screen.getByText('Edit: house-style')).toBeTruthy();
});
it('asks before the add button discards an unsaved draft', async () => {
await openVariable();
fireEvent.change(contentBox(), { target: { value: 'stay dry' } });
fireEvent.click(screen.getByLabelText('Add variable'));
expect(screen.getByText('Discard unsaved changes to "Tone Guide"?')).toBeTruthy();
expect(currentSearch()).toContain('var=tone-guide');
fireEvent.click(screen.getByRole('button', { name: /^discard$/i }));
await screen.findByText('New Variable');
expect(currentSearch()).not.toContain('var=');
expect(contentBox().value).toBe('');
});
it('does not ask when the edit is undone back to the saved value', async () => {
await openVariable();
fireEvent.change(contentBox(), { target: { value: 'stay dry' } });
expect(screen.getByText('Unsaved changes')).toBeTruthy();
fireEvent.change(contentBox(), { target: { value: 'stay wry' } });
fireEvent.click(screen.getByText('House Style'));
expect(screen.queryByText('Discard unsaved changes to "Tone Guide"?')).toBeNull();
await waitFor(() => expect(currentSearch()).toContain('var=house-style'));
});
});
// Job skill selection lives in `?skill=` so the open editor is deep-linkable and
// survives a reload or a tab round-trip (#3936).
describe('PromptManager job skill selection', () => {
const SKILLS = [
{ name: 'code-fixer', jobId: 'job-code-fixer', hasTemplate: true },
{ name: 'doc-writer', jobId: 'job-doc-writer', hasTemplate: false },
];
beforeEach(() => {
getPrompts.mockReset().mockResolvedValue({ stages: STAGES, systemStages: SYSTEM_STAGES });
getJobSkills.mockReset().mockResolvedValue({ skills: SKILLS });
getJobSkill.mockReset().mockImplementation((name) => Promise.resolve({
content: `# ${name} template`,
jobName: `Job ${name}`,
jobId: `job-${name}`,
category: 'maintenance',
interval: 'daily',
}));
});
it('writes the picked skill to the URL instead of local state', async () => {
await renderPage('/prompts?tab=job-skills');
await screen.findByText('code-fixer');
fireEvent.click(screen.getByText('code-fixer'));
await waitFor(() => expect(currentSearch()).toContain('skill=code-fixer'));
expect(currentSearch()).toContain('tab=job-skills');
await screen.findByText('Job code-fixer');
});
it('loads the skill named by a deep link on mount', async () => {
await renderPage('/prompts?tab=job-skills&skill=doc-writer');
await screen.findByText('Job doc-writer');
expect(getJobSkill).toHaveBeenCalledWith('doc-writer', { silent: true });
expect(screen.getByDisplayValue('# doc-writer template')).toBeTruthy();
});
it('keeps the open skill editor across a tab round-trip', async () => {
await renderPage('/prompts?tab=job-skills&skill=code-fixer');
await screen.findByText('Job code-fixer');
fireEvent.click(screen.getByRole('button', { name: /variables/i }));
fireEvent.click(screen.getByRole('button', { name: /job skills/i }));
await screen.findByText('Job code-fixer');
expect(currentSearch()).toContain('skill=code-fixer');
});
it('does not leave the previous skill rendered when the next fetch fails', async () => {
await renderPage('/prompts?tab=job-skills&skill=code-fixer');
await screen.findByText('Job code-fixer');
getJobSkill.mockRejectedValueOnce(new Error('gone'));
fireEvent.click(screen.getByText('doc-writer'));
// The heading falls back to the raw param, and the editor is empty — never
// the previous skill's template under the new skill's name.
await screen.findByText('doc-writer', { selector: 'h3' });
expect(screen.queryByDisplayValue('# code-fixer template')).toBeNull();
expect(screen.queryByText('Job code-fixer')).toBeNull();
});
it('shows the placeholder when no skill is named in the URL', async () => {
await renderPage('/prompts?tab=job-skills');
await screen.findByText('code-fixer');
expect(getJobSkill).not.toHaveBeenCalled();
expect(screen.getByText('Select a job skill to edit its prompt template')).toBeTruthy();
});
});
// A failed PUT used to be swallowed entirely: the Save button re-enabled and the
// user believed the edit had persisted (#3937).
describe('PromptManager job skill save feedback', () => {
const SKILLS = [{ name: 'code-fixer', jobId: 'job-code-fixer', hasTemplate: true }];
beforeEach(() => {
getPrompts.mockReset().mockResolvedValue({ stages: STAGES, systemStages: SYSTEM_STAGES });
getJobSkills.mockReset().mockResolvedValue({ skills: SKILLS });
getJobSkill.mockReset().mockResolvedValue({
content: '# code-fixer template', jobName: 'Job code-fixer', jobId: 'job-code-fixer',
});
saveJobSkill.mockReset().mockResolvedValue({ success: true });
previewJobSkill.mockReset().mockResolvedValue({ preview: 'rendered' });
toast.error.mockReset();
toast.success.mockReset();
});
const openEditor = async () => {
await renderPage('/prompts?tab=job-skills&skill=code-fixer');
await screen.findByText('Job code-fixer');
};
it('toasts the failure message when the save rejects', async () => {
saveJobSkill.mockRejectedValueOnce(new Error('boom'));
await openEditor();
fireEvent.click(screen.getByRole('button', { name: /save/i }));
await waitFor(() => expect(toast.error).toHaveBeenCalledWith('Failed to save job skill: boom'));
expect(toast.success).not.toHaveBeenCalled();
});
it('re-enables Save after a failure so the user can retry', async () => {
saveJobSkill.mockRejectedValueOnce(new Error('boom'));
await openEditor();
const save = screen.getByRole('button', { name: /save/i });
fireEvent.click(save);
await waitFor(() => expect(toast.error).toHaveBeenCalled());
await waitFor(() => expect(save.disabled).toBe(false));
});
it('confirms a successful save', async () => {
await openEditor();
fireEvent.click(screen.getByRole('button', { name: /save/i }));
await waitFor(() => expect(toast.success).toHaveBeenCalledWith('Job skill saved'));
expect(saveJobSkill).toHaveBeenCalledWith('code-fixer', '# code-fixer template', { silent: true });
expect(toast.error).not.toHaveBeenCalled();
});
it('toasts a failed preview instead of blanking the panel', async () => {
previewJobSkill.mockRejectedValueOnce(new Error('nope'));
await openEditor();
fireEvent.click(screen.getByRole('button', { name: /preview/i }));
await waitFor(() => expect(toast.error).toHaveBeenCalledWith('Failed to preview: nope'));
});
});
// Clicking another skill used to overwrite the editor outright, silently
// discarding whatever the user had typed (#3939).
describe('PromptManager job skill unsaved-edit guard', () => {
const SKILLS = [
{ name: 'code-fixer', jobId: 'job-code-fixer', hasTemplate: true },
{ name: 'doc-writer', jobId: 'job-doc-writer', hasTemplate: false },
];
beforeEach(() => {
getPrompts.mockReset().mockResolvedValue({ stages: STAGES, systemStages: SYSTEM_STAGES });
getJobSkills.mockReset().mockResolvedValue({ skills: SKILLS });
getJobSkill.mockReset().mockImplementation((name) => Promise.resolve({
content: `# ${name} template`,
jobName: `Job ${name}`,
jobId: `job-${name}`,
}));
saveJobSkill.mockReset().mockResolvedValue({ success: true });
toast.error.mockReset();
toast.success.mockReset();
});
const editor = () => screen.getByLabelText('Skill Template (Markdown)');
const openDirtyEditor = async () => {
await renderPage('/prompts?tab=job-skills&skill=code-fixer');
await screen.findByText('Job code-fixer');
fireEvent.change(editor(), { target: { value: '# edited by hand' } });
await screen.findByText('Unsaved changes');
};
it('marks the editor dirty once the template is modified', async () => {
await renderPage('/prompts?tab=job-skills&skill=code-fixer');
await screen.findByText('Job code-fixer');
expect(screen.queryByText('Unsaved changes')).toBeNull();
fireEvent.change(editor(), { target: { value: '# edited by hand' } });
expect(screen.getByText('Unsaved changes')).toBeTruthy();
});
it('treats an edit reverted to the loaded text as clean again', async () => {
await openDirtyEditor();
fireEvent.change(editor(), { target: { value: '# code-fixer template' } });
expect(screen.queryByText('Unsaved changes')).toBeNull();
});
it('asks before discarding unsaved edits when another skill is clicked', async () => {
await openDirtyEditor();
fireEvent.click(screen.getByText('doc-writer'));
expect(screen.getByText('Discard unsaved changes to "Job code-fixer"?')).toBeTruthy();
// Nothing switched yet: the URL, the fetch, and the typed text all hold.
expect(currentSearch()).toContain('skill=code-fixer');
expect(getJobSkill).not.toHaveBeenCalledWith('doc-writer', { silent: true });
expect(screen.getByDisplayValue('# edited by hand')).toBeTruthy();
});
it('keeps the edits when the discard prompt is cancelled', async () => {
await openDirtyEditor();
fireEvent.click(screen.getByText('doc-writer'));
fireEvent.click(screen.getByRole('button', { name: 'Keep editing' }));
expect(screen.queryByText(/Discard unsaved changes/)).toBeNull();
expect(screen.getByDisplayValue('# edited by hand')).toBeTruthy();
expect(currentSearch()).toContain('skill=code-fixer');
});
it('switches skills after the discard is confirmed', async () => {
await openDirtyEditor();
fireEvent.click(screen.getByText('doc-writer'));
fireEvent.click(screen.getByRole('button', { name: 'Discard' }));
await waitFor(() => expect(currentSearch()).toContain('skill=doc-writer'));
await screen.findByText('Job doc-writer');
expect(screen.getByDisplayValue('# doc-writer template')).toBeTruthy();
expect(screen.queryByText('Unsaved changes')).toBeNull();
});
it('switches without prompting once the edits are saved', async () => {
await openDirtyEditor();
// Exact match: the dirty list row is labelled "… Unsaved", which /save/i
// would also match.
fireEvent.click(screen.getByRole('button', { name: /^Save$/ }));
await waitFor(() => expect(toast.success).toHaveBeenCalled());
expect(screen.queryByText('Unsaved changes')).toBeNull();
fireEvent.click(screen.getByText('doc-writer'));
expect(screen.queryByText(/Discard unsaved changes/)).toBeNull();
await waitFor(() => expect(currentSearch()).toContain('skill=doc-writer'));
});
it('drops the armed prompt when the edit is undone back to the saved text', async () => {
await openDirtyEditor();
fireEvent.click(screen.getByText('doc-writer'));
expect(screen.getByText(/Discard unsaved changes/)).toBeTruthy();
fireEvent.change(editor(), { target: { value: '# code-fixer template' } });
expect(screen.queryByText(/Discard unsaved changes/)).toBeNull();
expect(screen.getByText('doc-writer')).toBeTruthy();
});
it('does not re-arm the old prompt when the editor goes dirty a second time', async () => {
await openDirtyEditor();
fireEvent.click(screen.getByText('doc-writer'));
fireEvent.change(editor(), { target: { value: '# code-fixer template' } });
fireEvent.change(editor(), { target: { value: '# a different edit' } });
// The question only ever appears in response to a click on another skill.
expect(screen.queryByText(/Discard unsaved changes/)).toBeNull();
expect(screen.getByText('Unsaved changes')).toBeTruthy();
});
it('drops the armed prompt when the edits are saved instead of discarded', async () => {
await openDirtyEditor();
fireEvent.click(screen.getByText('doc-writer'));
expect(screen.getByText(/Discard unsaved changes/)).toBeTruthy();
fireEvent.click(screen.getByRole('button', { name: /^Save$/ }));
await waitFor(() => expect(screen.queryByText(/Discard unsaved changes/)).toBeNull());
expect(currentSearch()).toContain('skill=code-fixer');
});
it('disarms the prompt when the already-open skill is clicked', async () => {
await openDirtyEditor();
fireEvent.click(screen.getByText('doc-writer'));
fireEvent.click(screen.getByText('code-fixer'));
expect(screen.queryByText(/Discard unsaved changes/)).toBeNull();
expect(screen.getByDisplayValue('# edited by hand')).toBeTruthy();
});
it('does not adopt an in-flight save as the next skill\'s baseline', async () => {
let resolveSave;
saveJobSkill.mockImplementationOnce(() => new Promise((r) => { resolveSave = r; }));
await openDirtyEditor();
fireEvent.click(screen.getByRole('button', { name: /^Save$/ }));
// Switch away while the PUT is still open, then let it land.
fireEvent.click(screen.getByText('doc-writer'));
fireEvent.click(screen.getByRole('button', { name: 'Discard' }));
await screen.findByText('Job doc-writer');
resolveSave({ success: true });
await waitFor(() => expect(toast.success).toHaveBeenCalled());
// The old skill's text must not become the new skill's clean baseline.
expect(screen.queryByText('Unsaved changes')).toBeNull();
});
it('never renders the outgoing skill\'s text or dirty badge under the new skill', async () => {
await openDirtyEditor();
fireEvent.click(screen.getByText('doc-writer'));
fireEvent.click(screen.getByRole('button', { name: 'Discard' }));
// Synchronously after the switch — before the fetch resolves — the editor is
// already empty and clean rather than still showing code-fixer's edit.
expect(screen.queryByDisplayValue('# edited by hand')).toBeNull();
expect(screen.queryByText('Unsaved changes')).toBeNull();
// Settle the in-flight load so the fetch's state updates land inside act().
await screen.findByText('Job doc-writer');
});
it('drops a preview that resolves after the user switched skills', async () => {
let resolvePreview;
previewJobSkill.mockReset().mockImplementationOnce(() => new Promise((r) => { resolvePreview = r; }));
await renderPage('/prompts?tab=job-skills&skill=code-fixer');
await screen.findByText('Job code-fixer');
fireEvent.click(screen.getByRole('button', { name: /preview/i }));
fireEvent.click(screen.getByText('doc-writer'));
await screen.findByText('Job doc-writer');
await act(async () => { resolvePreview({ preview: 'code-fixer rendered' }); });
expect(screen.queryByText('code-fixer rendered')).toBeNull();
expect(screen.getByText('Job doc-writer')).toBeTruthy();
});
it('does not prompt when a clean editor switches skills', async () => {
await renderPage('/prompts?tab=job-skills&skill=code-fixer');
await screen.findByText('Job code-fixer');
fireEvent.click(screen.getByText('doc-writer'));
expect(screen.queryByText(/Discard unsaved changes/)).toBeNull();
await waitFor(() => expect(currentSearch()).toContain('skill=doc-writer'));
});
it('disables Preview button while request is in flight and re-enables when complete', async () => {
let resolvePreview;
previewJobSkill.mockReset().mockImplementationOnce(() => new Promise((r) => { resolvePreview = r; }));
await renderPage('/prompts?tab=job-skills&skill=code-fixer');
await screen.findByText('Job code-fixer');
const previewBtn = screen.getByRole('button', { name: /preview/i });
expect(previewBtn.disabled).toBe(false);
fireEvent.click(previewBtn);
expect(previewBtn.disabled).toBe(true);
resolvePreview({ preview: 'latest preview content' });
await waitFor(() => expect(previewBtn.disabled).toBe(false));
expect(screen.getByText('latest preview content')).toBeTruthy();
});
it('sequences preview requests for the same skill and ignores stale out-of-order responses', async () => {
let resolveFirst;
let resolveSecond;
let previewBtn;
previewJobSkill
.mockReset()
.mockImplementationOnce(() => {
fireEvent.click(previewBtn);
return new Promise((r) => { resolveFirst = r; });
})
.mockImplementationOnce(() => new Promise((r) => { resolveSecond = r; }));
await renderPage('/prompts?tab=job-skills&skill=code-fixer');
await screen.findByText('Job code-fixer');
previewBtn = screen.getByRole('button', { name: /preview/i });
// Trigger first request (which synchronously triggers second request)
fireEvent.click(previewBtn);
// Resolve second request first
resolveSecond({ preview: 'second response' });
await waitFor(() => expect(screen.getByText('second response')).toBeTruthy());
// Resolve first request later (stale out-of-order response)
resolveFirst({ preview: 'stale first response' });
// Verify stale response is ignored and second response remains rendered
expect(screen.queryByText('stale first response')).toBeNull();
expect(screen.getByText('second response')).toBeTruthy();
});
});
// The page hosts SettingsTabsHeader; before #5653 it also hand-rolled a
// `Settings` title bar above it, so every render stacked two h1s and pushed the
// first prompt group off a phone viewport.
describe('PromptManager page header', () => {
beforeEach(() => {
getPrompts.mockReset().mockResolvedValue({ stages: STAGES, systemStages: SYSTEM_STAGES });
});
it('renders exactly one h1, naming the page rather than the settings section', async () => {
await renderPage();
await screen.findByLabelText('Search prompt stages');
const headings = screen.getAllByRole('heading', { level: 1 });
expect(headings).toHaveLength(1);
expect(headings[0]).toHaveAccessibleName('Prompt Manager');
});
});
// Clicking another stage used to overwrite the editor outright, silently
// discarding whatever template/config edits the user had in flight (#6021).
// Mirrors the job-skill guard above (#3939).
describe('PromptManager stage unsaved-edit guard', () => {
beforeEach(() => {
getPrompts.mockReset().mockResolvedValue({ stages: STAGES, systemStages: SYSTEM_STAGES });
getPrompt.mockReset().mockImplementation((name) => Promise.resolve({
name: STAGES[name]?.name || name,
description: STAGES[name]?.description,
template: `${name} template`,
variables: [],
}));
savePrompt.mockReset().mockResolvedValue({ success: true });
getPromptUsage.mockReset().mockResolvedValue({
isSystemStage: false, usedBy: [], referencedBy: [], canDelete: true,
});
toast.error.mockReset();
toast.success.mockReset();
});
const templateBox = () => screen.getByLabelText('Template');
// A deep link expands the group holding the open stage, so the sibling row
// under test is on screen without any manual disclosure click.
const openDirtyEditor = async () => {
await renderPage('/prompts?stage=pipeline-prose-draft');
await screen.findByDisplayValue('pipeline-prose-draft template');
fireEvent.change(templateBox(), { target: { value: 'edited by hand' } });
await screen.findByText('Unsaved changes');
};
it('marks the stage editor dirty once the template is modified', async () => {
await renderPage('/prompts?stage=pipeline-prose-draft');
await screen.findByDisplayValue('pipeline-prose-draft template');
expect(screen.queryByText('Unsaved changes')).toBeNull();
expect(screen.queryByText('Unsaved')).toBeNull();
fireEvent.change(templateBox(), { target: { value: 'edited by hand' } });
// Header badge and the list-row badge on the open stage.
expect(screen.getByText('Unsaved changes')).toBeTruthy();
expect(screen.getByText('Unsaved')).toBeTruthy();
});
it('marks the editor dirty on a config-only change', async () => {
await renderPage('/prompts?stage=pipeline-prose-draft');
await screen.findByDisplayValue('pipeline-prose-draft template');
fireEvent.change(screen.getByLabelText('Model tier'), { target: { value: 'quick' } });
expect(screen.getByText('Unsaved changes')).toBeTruthy();
});
it('treats an edit reverted to the loaded template as clean again', async () => {
await openDirtyEditor();
fireEvent.change(templateBox(), { target: { value: 'pipeline-prose-draft template' } });
expect(screen.queryByText('Unsaved changes')).toBeNull();
});
it('asks before discarding unsaved edits when another stage is clicked', async () => {
await openDirtyEditor();
fireEvent.click(screen.getByText('Pipeline — Comic Book Script'));
expect(screen.getByText('Discard unsaved changes to "Pipeline — Prose Draft"?')).toBeTruthy();
// Nothing switched yet: the URL, the fetch, and the typed text all hold.
expect(currentSearch()).toContain('stage=pipeline-prose-draft');
expect(getPrompt).not.toHaveBeenCalledWith('pipeline-comic-script', { silent: true });
expect(screen.getByDisplayValue('edited by hand')).toBeTruthy();
});
it('keeps the edits when the discard prompt is cancelled', async () => {
await openDirtyEditor();
fireEvent.click(screen.getByText('Pipeline — Comic Book Script'));
fireEvent.click(screen.getByRole('button', { name: 'Keep editing' }));
expect(screen.queryByText(/Discard unsaved changes/)).toBeNull();
expect(screen.getByDisplayValue('edited by hand')).toBeTruthy();
expect(currentSearch()).toContain('stage=pipeline-prose-draft');
});
it('switches stages after the discard is confirmed', async () => {
await openDirtyEditor();
fireEvent.click(screen.getByText('Pipeline — Comic Book Script'));
fireEvent.click(screen.getByRole('button', { name: 'Discard' }));
await waitFor(() => expect(currentSearch()).toContain('stage=pipeline-comic-script'));
await screen.findByDisplayValue('pipeline-comic-script template');
expect(screen.queryByText('Unsaved changes')).toBeNull();
});
it('switches without prompting once the edits are saved', async () => {
await openDirtyEditor();
// Exact match: the dirty list row is labelled "… Unsaved", which /save/i
// would also match.
fireEvent.click(screen.getByRole('button', { name: /^Save$/ }));
await waitFor(() => expect(savePrompt).toHaveBeenCalled());
await waitFor(() => expect(screen.queryByText('Unsaved changes')).toBeNull());
fireEvent.click(screen.getByText('Pipeline — Comic Book Script'));
expect(screen.queryByText(/Discard unsaved changes/)).toBeNull();
await waitFor(() => expect(currentSearch()).toContain('stage=pipeline-comic-script'));
});
it('drops the armed prompt when the edit is undone back to the saved template', async () => {
await openDirtyEditor();
fireEvent.click(screen.getByText('Pipeline — Comic Book Script'));
expect(screen.getByText(/Discard unsaved changes/)).toBeTruthy();
fireEvent.change(templateBox(), { target: { value: 'pipeline-prose-draft template' } });
expect(screen.queryByText(/Discard unsaved changes/)).toBeNull();
// The row the question had taken over comes back.
expect(screen.getByText('Pipeline — Comic Book Script')).toBeTruthy();
});
it('backs out of the prompt when the already-open stage is re-clicked', async () => {
await openDirtyEditor();
fireEvent.click(screen.getByText('Pipeline — Comic Book Script'));
// By role, not text: the editor heading renders the same label.
fireEvent.click(screen.getByRole('button', { name: /Pipeline — Prose Draft/ }));
expect(screen.queryByText(/Discard unsaved changes/)).toBeNull();
expect(currentSearch()).toContain('stage=pipeline-prose-draft');
expect(screen.getByDisplayValue('edited by hand')).toBeTruthy();
});
it('does not prompt when a clean editor switches stages', async () => {
await renderPage('/prompts?stage=pipeline-prose-draft');
await screen.findByDisplayValue('pipeline-prose-draft template');
fireEvent.click(await screen.findByText('Pipeline — Comic Book Script'));
expect(screen.queryByText(/Discard unsaved changes/)).toBeNull();
await waitFor(() => expect(currentSearch()).toContain('stage=pipeline-comic-script'));
await screen.findByDisplayValue('pipeline-comic-script template');
});
});
// Each public editor boundary rejects writes before a successful detail read,
// then restores intentional editing without changing server persistence rules.
describe.each([
{ kind: 'stage', entry: '/prompts?stage=pipeline-prose-draft', detail: getPrompt, save: savePrompt, preview: previewPrompt, label: 'Template', first: 'pipeline-prose-draft', second: 'pipeline-comic-script', secondLabel: 'Pipeline — Comic Book Script', param: 'stage' },
{ kind: 'job skill', entry: '/prompts?tab=job-skills&skill=code-fixer', detail: getJobSkill, save: saveJobSkill, preview: previewJobSkill, label: 'Skill Template (Markdown)', first: 'code-fixer', second: 'doc-writer', secondLabel: 'doc-writer', param: 'skill' },
])('PromptManager $kind detail admission', ({ kind, entry, detail, save, preview: previewApi, label, first, second, secondLabel, param }) => {
const response = (text) => kind === 'stage'
? { name: 'Loaded stage', template: text, model: 'default', variables: [] }
: { jobName: 'Loaded skill', content: text };
const box = () => screen.getByLabelText(label);
const saveButton = () => screen.getByRole('button', { name: /^Save$/ });
const previewButton = () => screen.getByRole('button', { name: /^Preview$/ });
beforeEach(() => {
getPrompts.mockReset().mockResolvedValue({ stages: STAGES, systemStages: SYSTEM_STAGES });
getJobSkills.mockReset().mockResolvedValue({ skills: [{ name: 'code-fixer' }, { name: 'doc-writer' }] });
detail.mockReset();
save.mockReset().mockResolvedValue({ success: true });
previewApi.mockReset().mockResolvedValue({ preview: 'rendered' });
});
it('blocks pending and failed reads, exposes Retry, and permits editing only after hydration', async () => {
let rejectRead;
let resolveRetry;
detail.mockImplementationOnce(() => new Promise((_resolve, reject) => { rejectRead = reject; }))
.mockImplementationOnce(() => new Promise((resolve) => { resolveRetry = resolve; }));
await renderPage(entry);
expect(box().disabled).toBe(true);
expect(saveButton().disabled).toBe(true);
expect(previewButton().disabled).toBe(true);
if (kind === 'stage') {
expect(screen.getByLabelText('Model tier').disabled).toBe(true);
expect(screen.getByLabelText('Timeout override (ms)').disabled).toBe(true);
expect(screen.getByRole('button', { name: 'Tier' }).disabled).toBe(true);
}
fireEvent.click(saveButton());
fireEvent.click(previewButton());
expect(save).not.toHaveBeenCalled();
expect(previewApi).not.toHaveBeenCalled();
await act(async () => rejectRead(new Error('503 unavailable')));
expect(screen.getByRole('alert').textContent).toContain('503 unavailable');
expect(box().disabled).toBe(true);
fireEvent.click(saveButton());
expect(save).not.toHaveBeenCalled();
fireEvent.click(screen.getByRole('button', { name: 'Retry' }));
expect(saveButton().disabled).toBe(true);
await act(async () => resolveRetry(response('Original content')));
expect(screen.queryByRole('alert')).toBeNull();
expect(box().disabled).toBe(false);
// Clearing a loaded stage is deliberate and remains a valid write.
fireEvent.change(box(), { target: { value: kind === 'stage' ? '' : 'Edited skill' } });
fireEvent.click(saveButton());
await waitFor(() => expect(save).toHaveBeenCalled());
if (kind === 'stage') expect(save).toHaveBeenCalledWith(first, expect.objectContaining({ template: '', provider: null }), { silent: true });
else expect(save).toHaveBeenCalledWith(first, 'Edited skill', { silent: true });
});
it('revokes admission on list and history navigation and ignores superseded detail responses', async () => {
let resolveSecond;
let resolveBack;
let resolveForward;
detail.mockResolvedValueOnce(response('First content'))
.mockImplementationOnce(() => new Promise((resolve) => { resolveSecond = resolve; }))
.mockImplementationOnce(() => new Promise((resolve) => { resolveBack = resolve; }))
.mockImplementationOnce(() => new Promise((resolve) => { resolveForward = resolve; }));
await renderPage(entry);
await screen.findByDisplayValue('First content');
fireEvent.click(screen.getByText(secondLabel));
expect(currentSearch()).toContain(`${param}=${second}`);
expect(box().value).toBe('');
expect(box().disabled).toBe(true);
expect(saveButton().disabled).toBe(true);
fireEvent.click(screen.getByRole('button', { name: 'History Back' }));
expect(currentSearch()).toContain(`${param}=${first}`);
expect(box().disabled).toBe(true);
await act(async () => resolveSecond(response('Stale second content')));
expect(box().value).toBe('');
expect(saveButton().disabled).toBe(true);
await act(async () => resolveBack(response('Fresh first content')));
expect(box().value).toBe('Fresh first content');
expect(saveButton().disabled).toBe(false);
fireEvent.click(screen.getByRole('button', { name: 'History Forward' }));
expect(currentSearch()).toContain(`${param}=${second}`);
expect(box().disabled).toBe(true);
expect(previewButton().disabled).toBe(true);
await act(async () => resolveForward(response('Fresh second content')));
expect(box().value).toBe('Fresh second content');
expect(box().disabled).toBe(false);
});
});
describe('PromptManager unavailable catalogues (#11143)', () => {
const SKILLS = [{ name: 'code-fixer', jobId: 'job-code-fixer', hasTemplate: true }];
const VARS = { 'tone-guide': { name: 'Tone Guide', category: 'style', content: 'Be brief' } };
const down = () => Promise.reject(new Error('503'));
beforeEach(() => {
getPrompts.mockReset().mockResolvedValue({ stages: STAGES, systemStages: SYSTEM_STAGES });
getPrompt.mockReset().mockResolvedValue({ name: 'Pipeline — Prose Draft', template: 'body', variables: [] });
getPromptUsage.mockReset().mockResolvedValue({ isSystemStage: false, usedBy: [], referencedBy: [], canDelete: true });
getPromptVariables.mockReset().mockResolvedValue({ variables: VARS });
getJobSkills.mockReset().mockResolvedValue({ skills: SKILLS });
getJobSkill.mockReset().mockResolvedValue({ content: '# t', jobName: 'Job', jobId: 'job-code-fixer' });
});
it('names a failed stage catalogue without claiming the deep-linked stage was deleted, and recovers on Retry', async () => {
getPrompts.mockReset().mockImplementationOnce(down).mockResolvedValue({ stages: STAGES, systemStages: SYSTEM_STAGES });
await renderPage('/prompts?stage=pipeline-prose-draft');
await screen.findByText(/Stages are unavailable/);
expect(screen.queryByText('No prompt stages found')).toBeNull();
expect(screen.queryByText(/could not be found/)).toBeNull();
fireEvent.click(screen.getByRole('button', { name: 'Retry stages' }));
await screen.findByText('4 stages');
expect(screen.queryByText(/Stages are unavailable/)).toBeNull();
});
it('keeps other catalogues usable when only the variables read fails', async () => {
getPromptVariables.mockReset().mockImplementation(down);
await renderPage('/prompts?tab=variables&var=tone-guide');
await screen.findByText(/Variables are unavailable/);
expect(screen.queryByText(/could not be found/)).toBeNull();
expect(screen.getAllByRole('button', { name: 'Retry variables' }).length).toBe(2);
// Skills were never touched.
fireEvent.click(screen.getByRole('button', { name: /Job Skills/i }));
await screen.findByText('code-fixer');
expect(screen.queryByText(/Job skills are unavailable/)).toBeNull();
});
it('shows the genuine empty state for a successful empty skills read', async () => {
getJobSkills.mockReset().mockResolvedValue({ skills: [] });
await renderPage('/prompts?tab=job-skills');
await screen.findByText('No job skill templates found');
expect(screen.queryByText(/Job skills are unavailable/)).toBeNull();
});
it('names a failed skills read instead of "No job skill templates found"', async () => {
getJobSkills.mockReset().mockImplementation(down);
await renderPage('/prompts?tab=job-skills');
await screen.findByText(/Job skills are unavailable/);
expect(screen.queryByText('No job skill templates found')).toBeNull();
});
it('keeps rows and the open variable when a refresh fails, flagging them stale', async () => {
await renderPage('/prompts?tab=variables&var=tone-guide');
await screen.findByText('Edit: tone-guide');
getPromptVariables.mockReset().mockImplementation(down);
fireEvent.click(screen.getByLabelText('Reload'));
await screen.findByText(/Variables may be out of date/);
expect(screen.getByText('Edit: tone-guide')).toBeTruthy();
expect(screen.getByText('Tone Guide')).toBeTruthy();
getPromptVariables.mockReset().mockResolvedValue({ variables: VARS });
fireEvent.click(screen.getByRole('button', { name: 'Retry variables' }));
await waitFor(() => expect(screen.queryByText(/may be out of date/)).toBeNull());
});
});
// Below the split-pane width the selected editor leads and the catalogue moves
// behind a Drawer (#11142). happy-dom has no layout, so the page's measured
// content width is injected through a ResizeObserver stand-in.
describe('PromptManager narrow layout (#11142)', () => {
const NARROW_PX = 500;
const realResizeObserver = globalThis.ResizeObserver;
const VARIABLES = {
'tone-guide': { name: 'Tone Guide', category: 'style', content: 'stay wry' },
'house-style': { name: 'House Style', category: 'style', content: 'oxford comma' },
};
const SKILLS = [
{ name: 'code-fixer', jobId: 'job-code-fixer', hasTemplate: true },
{ name: 'doc-writer', jobId: 'job-doc-writer', hasTemplate: false },
];
beforeEach(() => {
globalThis.ResizeObserver = class {
constructor(cb) { this.cb = cb; }
observe() { this.cb([{ contentRect: { width: NARROW_PX } }]); }
disconnect() {}
};
getPrompts.mockReset().mockResolvedValue({ stages: STAGES, systemStages: SYSTEM_STAGES });
getPrompt.mockReset().mockImplementation((name) => Promise.resolve({
name: STAGES[name]?.name || name, description: STAGES[name]?.description, template: `${name} template`, variables: [],
}));
getPromptVariables.mockReset().mockResolvedValue({ variables: VARIABLES });
getJobSkills.mockReset().mockResolvedValue({ skills: SKILLS });
getJobSkill.mockReset().mockImplementation((name) => Promise.resolve({
content: `# ${name} template`, jobName: `Job ${name}`, jobId: `job-${name}`, category: 'maintenance', interval: 'daily',
}));
});
afterEach(() => {
globalThis.ResizeObserver = realResizeObserver;
});
const chooser = (noun) => screen.getByRole('button', { name: new RegExp(`Choose another ${noun}`) });
it('leads with the selected stage editor and keeps the catalogue out of the page flow', async () => {
await renderPage('/prompts?stage=pipeline-prose-draft');
await screen.findByDisplayValue('pipeline-prose-draft template');
expect(screen.getByRole('button', { name: /^save$/i })).toBeTruthy();
expect(screen.queryByLabelText('Search prompt stages')).toBeNull();
expect(chooser('stage')).toBeTruthy();
});
it('opens the catalogue in a drawer, keeps unsaved edits, and switches stage from it', async () => {
await renderPage('/prompts?stage=pipeline-prose-draft');
await screen.findByDisplayValue('pipeline-prose-draft template');
fireEvent.change(screen.getByLabelText('Template'), { target: { value: 'edited by hand' } });
fireEvent.click(chooser('stage'));
const drawer = screen.getByRole('dialog', { name: 'Prompt Stages' });
expect(within(drawer).getByLabelText('Search prompt stages')).toBeTruthy();
// Opening the chooser alone must not touch the edit.
expect(screen.getByLabelText('Template').value).toBe('edited by hand');
// The unsaved-edit guard runs inside the drawer, in the clicked row's slot.
fireEvent.click(within(drawer).getByText('Pipeline — Comic Book Script'));
expect(within(drawer).getByText(/Discard unsaved changes/)).toBeTruthy();
fireEvent.click(within(drawer).getByRole('button', { name: 'Keep editing' }));
expect(screen.getByLabelText('Template').value).toBe('edited by hand');
fireEvent.click(within(drawer).getByText('Pipeline — Comic Book Script'));
fireEvent.click(within(drawer).getByRole('button', { name: 'Discard' }));
await screen.findByDisplayValue('pipeline-comic-script template');
expect(currentSearch()).toContain('stage=pipeline-comic-script');
expect(screen.queryByRole('dialog')).toBeNull();
});
it('shows the catalogue alone when nothing is selected', async () => {
await renderPage('/prompts');
expect(await screen.findByLabelText('Search prompt stages')).toBeTruthy();
expect(screen.queryByRole('button', { name: /Choose another/ })).toBeNull();
expect(screen.queryByText('Select a stage to edit')).toBeNull();
});
it('offers Retry in the active workspace when the selected stage fails to load', async () => {
getPrompt.mockReset().mockRejectedValue(new Error('boom'));
await renderPage('/prompts?stage=pipeline-prose-draft');
expect(await screen.findByRole('button', { name: 'Retry' })).toBeTruthy();
expect(screen.queryByLabelText('Search prompt stages')).toBeNull();
});
it('opens a variable editor first, and a blank draft from the catalogue add button', async () => {
await renderPage('/prompts?tab=variables');
await screen.findByText('Tone Guide');
expect(screen.queryByPlaceholderText('Variable content...')).toBeNull();
fireEvent.click(screen.getByRole('button', { name: 'Add variable' }));
expect(screen.getByText('New Variable')).toBeTruthy();
expect(screen.queryByText('Tone Guide')).toBeNull();
fireEvent.click(chooser('variable'));
const drawer = screen.getByRole('dialog', { name: 'Variables' });
fireEvent.click(within(drawer).getByText('House Style'));
await screen.findByDisplayValue('oxford comma');
expect(currentSearch()).toContain('var=house-style');
expect(screen.queryByRole('dialog')).toBeNull();
});
it('opens a job skill editor first with the skills behind the chooser', async () => {
await renderPage('/prompts?tab=job-skills&skill=code-fixer');
await screen.findByDisplayValue('# code-fixer template');
expect(screen.queryByText('doc-writer')).toBeNull();
fireEvent.click(chooser('job skill'));
fireEvent.click(within(screen.getByRole('dialog')).getByText('doc-writer'));
await screen.findByDisplayValue('# doc-writer template');
expect(currentSearch()).toContain('skill=doc-writer');
});
});